ReplaysEvents::determineAfterEventId() - Code Metrics - Inspection of "improve commands" - spatie/laravel-event-projector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 64d9c2...789991 )

by Freek

created 2018-06-05 19:48 UTC

ReplaysEvents::determineAfterEventId() A

↳ Parent: ReplaysEvents

Complexity

Conditions	2
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	1
nop	1

<?php

namespace Spatie\EventProjector\Console\Concerns;

use Illuminate\Support\Collection;
use Spatie\EventProjector\Models\StoredEvent;
use Spatie\EventProjector\Projectors\Projector;

trait ReplaysEvents
{
    public function replayEvents(Collection $projectors)
    {
        $afterEventId = $this->determineAfterEventId($projectors);

        if ($afterEventId === StoredEvent::getMaxId()) {
            $this->warn('There are no events to replay.');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        $replayEventsCount = StoredEvent::after($afterEventId)->count();

        if ($replayEventsCount === 0) {
            $this->warn('There are no events to replay');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            return;
        }

        $afterEventId === 0
            ? $this->comment('Replaying all events...')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            : $this->comment("Replaying events after stored event id {$afterEventId}...");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->emptyLine();

        $bar = $this->output->createProgressBar(StoredEvent::after($afterEventId)->count());
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $onEventReplayed = function () use ($bar) {
            $bar->advance();
        };

        $this->eventProjectionist->replayEvents($projectors, $afterEventId, $onEventReplayed);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $bar->finish();

        $this->emptyLine(2);
        $this->comment('All done!');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function determineAfterEventId(Collection $projectors): int
    {
        return $projectors
            ->map(function ($projector) {
                if (is_string($projector)) {
                    $projector = app($projector);
                }

                return $projector;
            })
            ->map(function (Projector $projector) {
                return $projector->getLastProcessedEventId();
            })
            ->min();
    }

    protected function emptyLine(int $amount = 1)
    {
        foreach (range(1, $amount) as $i) {
            $this->line('');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}

1			<?php
2
3			namespace Spatie\EventProjector\Console\Concerns;
4
5			use Illuminate\Support\Collection;
6			use Spatie\EventProjector\Models\StoredEvent;
7			use Spatie\EventProjector\Projectors\Projector;
8
9			trait ReplaysEvents
10			{
11			public function replayEvents(Collection $projectors)
12			{
13			$afterEventId = $this->determineAfterEventId($projectors);
14
15			if ($afterEventId === StoredEvent::getMaxId()) {
16			$this->warn('There are no events to replay.');
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report It seems like `warn()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			}
18
19			$replayEventsCount = StoredEvent::after($afterEventId)->count();
20
21			if ($replayEventsCount === 0) {
22			$this->warn('There are no events to replay');
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report It seems like `warn()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23
24			return;
25			}
26
27			$afterEventId === 0
28			? $this->comment('Replaying all events...')
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report It seems like `comment()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			: $this->comment("Replaying events after stored event id {$afterEventId}...");
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report It seems like `comment()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30			$this->emptyLine();
31
32			$bar = $this->output->createProgressBar(StoredEvent::after($afterEventId)->count());
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report The property `output` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33			$onEventReplayed = function () use ($bar) {
34			$bar->advance();
35			};
36
37			$this->eventProjectionist->replayEvents($projectors, $afterEventId, $onEventReplayed);
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report The property `eventProjectionist` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38
39			$bar->finish();
40
41			$this->emptyLine(2);
42			$this->comment('All done!');
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report It seems like `comment()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			}
44
45			protected function determineAfterEventId(Collection $projectors): int
46			{
47			return $projectors
48			->map(function ($projector) {
49			if (is_string($projector)) {
50			$projector = app($projector);
51			}
52
53			return $projector;
54			})
55			->map(function (Projector $projector) {
56			return $projector->getLastProcessedEventId();
57			})
58			->min();
59			}
60
61			protected function emptyLine(int $amount = 1)
62			{
63			foreach (range(1, $amount) as $i) {
64			$this->line('');
			0 ignored issues – show Bug introduced 2018-06-05 19:50 UTC by Report Bug Copy Issue Report It seems like `line()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
65			}
66			}
67			}

spatie / laravel-event-projector

Push — master ( 64d9c2...789991 )

ReplaysEvents::determineAfterEventId() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like