Issues in EnumCast.php (master) - Issues in master - spatie/laravel-enum - Measure and Improve Code Quality continuously with Scrutinizer

Issues (14)

src/Casts/EnumCast.php (2 issues)

Labels

Bug 2

Severity

Minor 2

<?php

namespace Spatie\Enum\Laravel\Casts;

class EnumCast extends Cast
{
    /**
     * @param \Illuminate\Database\Eloquent\Model $model
     * @param string $key
     * @param int|string|null|mixed $value
     * @param array $attributes
     *
     * @return \Spatie\Enum\Enum|null
     *
     * @throws \BadMethodCallException
     * @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
     */
    public function get($model, string $key, $value, array $attributes)
    {
        if (is_null($value)) {
            return $this->handleNullValue($model, $key);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        return $this->asEnum($value);
    }

    /**
     * @param \Illuminate\Database\Eloquent\Model $model
     * @param string $key
     * @param int|string|\Spatie\Enum\Enum|null|mixed $value
     * @param array $attributes
     *
     * @return int|string|null
     *
     * @throws \BadMethodCallException
     * @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
     */
    public function set($model, string $key, $value, array $attributes)
    {
        if (is_null($value)) {
            return $this->handleNullValue($model, $key);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        return $this->asEnum($value)->value;
    }
}


1			<?php
2
3			namespace Spatie\Enum\Laravel\Casts;
4
5			class EnumCast extends Cast
6			{
7			/**
8			* @param \Illuminate\Database\Eloquent\Model $model
9			* @param string $key
10			* @param int\|string\|null\|mixed $value
11			* @param array $attributes
12			*
13			* @return \Spatie\Enum\Enum\|null
14			*
15			* @throws \BadMethodCallException
16			* @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
17			*/
18			public function get($model, string $key, $value, array $attributes)
19			{
20			if (is_null($value)) {
21			return $this->handleNullValue($model, $key);
			0 ignored issues – show Bug introduced 2020-09-17 10:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->handleNullValue($model, $key)` targeting `Spatie\Enum\Laravel\Casts\Cast::handleNullValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
22			}
23
24			return $this->asEnum($value);
25			}
26
27			/**
28			* @param \Illuminate\Database\Eloquent\Model $model
29			* @param string $key
30			* @param int\|string\|\Spatie\Enum\Enum\|null\|mixed $value
31			* @param array $attributes
32			*
33			* @return int\|string\|null
34			*
35			* @throws \BadMethodCallException
36			* @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
37			*/
38			public function set($model, string $key, $value, array $attributes)
39			{
40			if (is_null($value)) {
41			return $this->handleNullValue($model, $key);
			0 ignored issues – show Bug introduced 2020-09-17 10:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->handleNullValue($model, $key)` targeting `Spatie\Enum\Laravel\Casts\Cast::handleNullValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
42			}
43
44			return $this->asEnum($value)->value;
45			}
46			}
47

GitHub Access Token became invalid

Issues (14)

src/Casts/EnumCast.php (2 issues)

Labels

Severity

Introduced By

spatie / laravel-enum

GitHub Access Token became invalid

Issues (14)

src/Casts/EnumCast.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like