EnumRequest::transformEnums() - Code Metrics - Inspection of "request transform" - spatie/laravel-enum - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Tom

created 2019-08-06 14:04 UTC

EnumRequest::transformEnums() C

↳ Parent: EnumRequest

Complexity

Conditions	12
Paths	1

Size

Total Lines

Duplication

Lines	34
Ratio	47.89 %

Code Coverage

Tests	38
CRAP Score	12.0024

Importance

Changes

Metric	Value
dl	34
loc	71
ccs	38
cts	39
cp	0.9744
rs	6.206
c	0
b	0
f	0
cc	12
nc	1
nop	0
crap	12.0024

How to fix Long Method Complexity

<?php

namespace Spatie\Enum\Laravel\Http;

use Closure;

/**
 * @internal This class is only used to get mixed into \Illuminate\Http\Request
 *
 * @mixin \Illuminate\Http\Request
 */
final class EnumRequest
{
    const REQUEST_ROUTE = 'route';
    const REQUEST_QUERY = 'query';
    const REQUEST_REQUEST = 'request';

    public function transformEnums(): Closure
    {
        return function (array $transformations) {
            if (isset($transformations[EnumRequest::REQUEST_ROUTE])) {
                $route = $this->route();


                foreach ($transformations[EnumRequest::REQUEST_ROUTE] as $key => $enumClass) {
                    if (! $route->hasParameter($key)) {
                        continue;
                    }

                    $route->setParameter(
                        $key,
                        forward_static_call(
                            $enumClass.'::make',
                            $route->parameter($key)
                        )
                    );
                }

                unset($transformations[EnumRequest::REQUEST_ROUTE]);
            }

            if (isset($transformations[EnumRequest::REQUEST_QUERY])) {

                foreach ($transformations[EnumRequest::REQUEST_QUERY] as $key => $enumClass) {
                    if (! $this->query->has($key)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                        continue;
                    }

                    $this->query->set(
                        $key,
                        forward_static_call(
                            $enumClass.'::make',
                            $this->query->get($key)
                        )
                    );
                }

                unset($transformations[EnumRequest::REQUEST_QUERY]);
            }

            if (isset($transformations[EnumRequest::REQUEST_REQUEST])) {

                foreach ($transformations[EnumRequest::REQUEST_REQUEST] as $key => $enumClass) {
                    if (! $this->request->has($key)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                        continue;
                    }

                    $this->request->set(
                        $key,
                        forward_static_call(
                            $enumClass.'::make',
                            $this->request->get($key)
                        )
                    );
                }

                unset($transformations[EnumRequest::REQUEST_REQUEST]);
            }

            foreach ($transformations as $key => $enumClass) {
                if (! isset($this[$key])) {
                    continue;
                }

                $this[$key] = forward_static_call(
                    $enumClass.'::make',
                    $this[$key]
                );
            }
        };
    }
}


1			<?php
2
3			namespace Spatie\Enum\Laravel\Http;
4
5			use Closure;
6
7			/**
8			* @internal This class is only used to get mixed into \Illuminate\Http\Request
9			*
10			* @mixin \Illuminate\Http\Request
11			*/
12			final class EnumRequest
13			{
14			const REQUEST_ROUTE = 'route';
15			const REQUEST_QUERY = 'query';
16			const REQUEST_REQUEST = 'request';
17
18	208		public function transformEnums(): Closure
19			{
20			return function (array $transformations) {
21	72		if (isset($transformations[EnumRequest::REQUEST_ROUTE])) {
22	8		$route = $this->route();
			0 ignored issues – show Bug introduced 2019-08-06 14:12 UTC by Report Bug Copy Issue Report The method `route()` does not seem to exist on `object<Spatie\Enum\Laravel\Http\EnumRequest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
23
24	8		foreach ($transformations[EnumRequest::REQUEST_ROUTE] as $key => $enumClass) {
25	8		if (! $route->hasParameter($key)) {
26	4		continue;
27			}
28
29	4		$route->setParameter(
30	4		$key,
31	4		forward_static_call(
32	4		$enumClass.'::make',
33	4		$route->parameter($key)
34			)
35			);
36			}
37
38	8		unset($transformations[EnumRequest::REQUEST_ROUTE]);
39			}
40
41	72	View Code Duplication	if (isset($transformations[EnumRequest::REQUEST_QUERY])) {
			0 ignored issues – show Duplication introduced 2019-08-06 14:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42	24		foreach ($transformations[EnumRequest::REQUEST_QUERY] as $key => $enumClass) {
43	24		if (! $this->query->has($key)) {
			0 ignored issues – show Bug introduced 2019-08-06 13:11 UTC by Report Bug Copy Issue Report The property `query` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44	8		continue;
45			}
46
47	16		$this->query->set(
48	16		$key,
49	16		forward_static_call(
50	16		$enumClass.'::make',
51	16		$this->query->get($key)
52			)
53			);
54			}
55
56	24		unset($transformations[EnumRequest::REQUEST_QUERY]);
57			}
58
59	72	View Code Duplication	if (isset($transformations[EnumRequest::REQUEST_REQUEST])) {
			0 ignored issues – show Duplication introduced 2019-08-06 14:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60	28		foreach ($transformations[EnumRequest::REQUEST_REQUEST] as $key => $enumClass) {
61	28		if (! $this->request->has($key)) {
			0 ignored issues – show Bug introduced 2019-08-06 13:11 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
62	12		continue;
63			}
64
65	16		$this->request->set(
66	16		$key,
67	16		forward_static_call(
68	16		$enumClass.'::make',
69	16		$this->request->get($key)
70			)
71			);
72			}
73
74	28		unset($transformations[EnumRequest::REQUEST_REQUEST]);
75			}
76
77	72		foreach ($transformations as $key => $enumClass) {
78	12		if (! isset($this[$key])) {
79			continue;
80			}
81
82	12		$this[$key] = forward_static_call(
83	12		$enumClass.'::make',
84	12		$this[$key]
85			);
86			}
87	208		};
88			}
89			}
90

spatie / laravel-enum

GitHub Access Token became invalid

Pull Request — master (#7)

EnumRequest::transformEnums() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like