EnumCast::get() - Code Metrics - Inspection of "v2" - spatie/laravel-enum - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#44)

by Tom

created 2020-09-17 10:28 UTC

EnumCast::get() A

↳ Parent: EnumCast

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	3
c	0
b	0
f	0
dl	0
loc	7
rs	10
cc	2
nc	2
nop	4

<?php

namespace Spatie\Enum\Laravel\Casts;

use Cast;

class EnumCast extends Cast
{
    /**
     * @param \Illuminate\Database\Eloquent\Model $model
     * @param string $key
     * @param int|string|null|mixed $value
     * @param array $attributes
     *
     * @return \Spatie\Enum\Enum|null
     *
     * @throws \BadMethodCallException
     * @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
     */
    public function get($model, string $key, $value, array $attributes)
    {
        if (is_null($value)) {
            return $this->handleNullValue($model, $key);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        return $this->asEnum($value);
    }

    /**
     * @param \Illuminate\Database\Eloquent\Model $model
     * @param string $key
     * @param int|string|\Spatie\Enum\Enum|null|mixed $value
     * @param array $attributes
     *
     * @return int|string|null
     *
     * @throws \BadMethodCallException
     * @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
     */
    public function set($model, string $key, $value, array $attributes)
    {
        if (is_null($value)) {
            return $this->handleNullValue($model, $key);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        return $this->asEnum($value)->value;
    }
}


1			<?php
2
3			namespace Spatie\Enum\Laravel\Casts;
4
5			use Cast;
6
7			class EnumCast extends Cast
8			{
9			/**
10			* @param \Illuminate\Database\Eloquent\Model $model
11			* @param string $key
12			* @param int\|string\|null\|mixed $value
13			* @param array $attributes
14			*
15			* @return \Spatie\Enum\Enum\|null
16			*
17			* @throws \BadMethodCallException
18			* @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
19			*/
20			public function get($model, string $key, $value, array $attributes)
21			{
22			if (is_null($value)) {
23			return $this->handleNullValue($model, $key);
			0 ignored issues – show Bug introduced 2020-09-17 10:37 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->handleNullValue($model, $key)` targeting `Cast::handleNullValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
24			}
25
26			return $this->asEnum($value);
27			}
28
29			/**
30			* @param \Illuminate\Database\Eloquent\Model $model
31			* @param string $key
32			* @param int\|string\|\Spatie\Enum\Enum\|null\|mixed $value
33			* @param array $attributes
34			*
35			* @return int\|string\|null
36			*
37			* @throws \BadMethodCallException
38			* @throws \Spatie\Enum\Laravel\Exceptions\NotNullableEnumField
39			*/
40			public function set($model, string $key, $value, array $attributes)
41			{
42			if (is_null($value)) {
43			return $this->handleNullValue($model, $key);
			0 ignored issues – show Bug introduced 2020-09-17 10:37 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->handleNullValue($model, $key)` targeting `Cast::handleNullValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
44			}
45
46			return $this->asEnum($value)->value;
47			}
48			}
49

spatie / laravel-enum

GitHub Access Token became invalid

Pull Request — master (#44)

EnumCast::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like