DemoModeController::catchFallback() - Code Metrics - spatie/laravel-demo-mode - Measure and Improve Code Quality continuously with Scrutinizer

DemoModeController::catchFallback() A
last analyzed 2020-09-08 10:48 UTC

↳ Parent: DemoModeController

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
c	0
b	0
f	0
nc	4
nop	1
dl	0
loc	13
rs	10

<?php

namespace Spatie\DemoMode;

use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;

class DemoModeController extends \Illuminate\Routing\Controller
{
    public function grantAccess(): RedirectResponse
    {
        session()->put('demo_access_route_visited', true);

        return new RedirectResponse(
            config('demo-mode.redirect_authorized_users_to_url')
        );
    }

    public function catchFallback(Request $request): RedirectResponse
    {
        if (!config('demo-mode.enabled')) {
            abort(404);
        }

        if (!app(DemoGuard::class)->hasDemoAccess($request)) {
            return new RedirectResponse(
                config('demo-mode.redirect_unauthorized_users_to_url')
            );
        }

        abort(404);
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1			<?php
2
3			namespace Spatie\DemoMode;
4
5			use Illuminate\Http\RedirectResponse;
6			use Illuminate\Http\Request;
7
8			class DemoModeController extends \Illuminate\Routing\Controller
9			{
10			public function grantAccess(): RedirectResponse
11			{
12			session()->put('demo_access_route_visited', true);
13
14			return new RedirectResponse(
15			config('demo-mode.redirect_authorized_users_to_url')
16			);
17			}
18
19			public function catchFallback(Request $request): RedirectResponse
20			{
21			if (!config('demo-mode.enabled')) {
22			abort(404);
23			}
24
25			if (!app(DemoGuard::class)->hasDemoAccess($request)) {
26			return new RedirectResponse(
27			config('demo-mode.redirect_unauthorized_users_to_url')
28			);
29			}
30
31			abort(404);
			0 ignored issues – show Bug Best Practice introduced 2020-09-08 10:48 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `Illuminate\Http\RedirectResponse`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
32			}
33			}
34

spatie / laravel-demo-mode

DemoModeController::catchFallback() A last analyzed 2020-09-08 10:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DemoModeController::catchFallback() A
last analyzed 2020-09-08 10:48 UTC