AddCspHeaders::getPolicys() - Code Metrics - Inspection of "fix directory name" - spatie/laravel-csp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 75955e...d5bb65 )

by Freek

created 2018-02-20 22:17 UTC

AddCspHeaders::getPolicys() B

↳ Parent: AddCspHeaders

Complexity

Conditions	4
Paths	5

Size

Total Lines	28
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	14
nc	5
nop	1
dl	0
loc	28
rs	8.5806
c	0
b	0
f	0

<?php

namespace Spatie\Csp;

use Closure;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;

class AddCspHeaders
{
    public function handle(Request $request, Closure $next, $customPolicyClass = null)
    {
        $response = $next($request);

        $this
            ->getPolicys($customPolicyClass, $response)

            ->filter->shouldBeApplied($request, $response)
            ->each->applyTo($response);

        return $response;
    }

    protected function getPolicys(string $customPolicyClass = null): Collection
    {
        $policys = collect();

        if ($customPolicyClass) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $policys->push(PolicyFactory::create($customPolicyClass));

            return $policys;
        }

        $policyClass = config('csp.policy');

        if (! empty($policyClass)) {
            $policys->push(PolicyFactory::create($policyClass));
        }

        $reportOnlyPolicyClass = config('csp.report_only_policy');

        if (! empty($reportOnlyPolicyClass)) {
            $policy = PolicyFactory::create($reportOnlyPolicyClass);

            $policy->reportOnly();

            $policys->push($policy);
        }

        return $policys;
    }
}


1			<?php
2
3			namespace Spatie\Csp;
4
5			use Closure;
6			use Illuminate\Http\Request;
7			use Illuminate\Support\Collection;
8
9			class AddCspHeaders
10			{
11			public function handle(Request $request, Closure $next, $customPolicyClass = null)
12			{
13			$response = $next($request);
14
15			$this
16			->getPolicys($customPolicyClass, $response)
			0 ignored issues – show Unused Code introduced 2018-02-20 22:18 UTC by Report Bug Copy Issue Report The call to `AddCspHeaders::getPolicys()` has too many arguments starting with `$response`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
17			->filter->shouldBeApplied($request, $response)
18			->each->applyTo($response);
19
20			return $response;
21			}
22
23			protected function getPolicys(string $customPolicyClass = null): Collection
24			{
25			$policys = collect();
26
27			if ($customPolicyClass) {
			0 ignored issues – show Bug Best Practice introduced 2018-02-20 22:18 UTC by Report Bug Copy Issue Report The expression `$customPolicyClass` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
28			$policys->push(PolicyFactory::create($customPolicyClass));
29
30			return $policys;
31			}
32
33			$policyClass = config('csp.policy');
34
35			if (! empty($policyClass)) {
36			$policys->push(PolicyFactory::create($policyClass));
37			}
38
39			$reportOnlyPolicyClass = config('csp.report_only_policy');
40
41			if (! empty($reportOnlyPolicyClass)) {
42			$policy = PolicyFactory::create($reportOnlyPolicyClass);
43
44			$policy->reportOnly();
45
46			$policys->push($policy);
47			}
48
49			return $policys;
50			}
51			}
52

spatie / laravel-csp

Push — master ( 75955e...d5bb65 )

AddCspHeaders::getPolicys() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like