CookieConsentMiddleware::handle() - Code Metrics - Inspection of "Add ability to inject the view content via middlew..." - spatie/laravel-cookie-consent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

by Mohamed

created 2016-09-22 20:26 UTC

CookieConsentMiddleware::handle() A

↳ Parent: CookieConsentMiddleware

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	21
rs	9.3142
cc	3
eloc	12
nc	3
nop	2

<?php

namespace Spatie\CookieConsent;

use Closure;
use Illuminate\Http\Response;
use Illuminate\Contracts\Foundation\Application;

class CookieConsentMiddleware
{
    /**
     * The application implementation.
     *
     * @var \Illuminate\Contracts\Foundation\Application
     */
    protected $app;

    /**
     * Create a new middleware instance.
     *
     * @param  \Illuminate\Contracts\Foundation\Application $app
     * @return void

     */
    public function __construct(Application $app)
    {
        $this->app = $app;
    }

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Closure $next
     * @return mixed
     *
     * @throws \Symfony\Component\HttpKernel\Exception\HttpException
     */
    public function handle($request, Closure $next)
    {
        $response = $next($request);

        if ($response instanceOf Response) {
            $content = $response->getContent();

            $cookieConsentHTML = view('cookieConsent::index')->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

            if (($bodyPosition = strripos($content, '</body>')) !== false) {
                $content = ''
                    .substr($content, 0, $bodyPosition)
                    .$cookieConsentHTML
                    .substr($content, $bodyPosition);
            }

            $response->setContent($content);
        }

        return $response;
    }
}


GitHub Access Token became invalid

Pull Request — master (#19)

CookieConsentMiddleware::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2
3			namespace Spatie\CookieConsent;
4
5			use Closure;
6			use Illuminate\Http\Response;
7			use Illuminate\Contracts\Foundation\Application;
8
9			class CookieConsentMiddleware
10			{
11			/**
12			* The application implementation.
13			*
14			* @var \Illuminate\Contracts\Foundation\Application
15			*/
16			protected $app;
17
18			/**
19			* Create a new middleware instance.
20			*
21			* @param \Illuminate\Contracts\Foundation\Application $app
22			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-09-22 20:34 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
23			*/
24			public function __construct(Application $app)
25			{
26			$this->app = $app;
27			}
28
29			/**
30			* Handle an incoming request.
31			*
32			* @param \Illuminate\Http\Request $request
33			* @param \Closure $next
34			* @return mixed
35			*
36			* @throws \Symfony\Component\HttpKernel\Exception\HttpException
37			*/
38			public function handle($request, Closure $next)
39			{
40			$response = $next($request);
41
42			if ($response instanceOf Response) {
43			$content = $response->getContent();
44
45			$cookieConsentHTML = view('cookieConsent::index')->render();
			0 ignored issues – show Bug introduced 2016-09-22 20:34 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
46
47			if (($bodyPosition = strripos($content, '</body>')) !== false) {
48			$content = ''
49			.substr($content, 0, $bodyPosition)
50			.$cookieConsentHTML
51			.substr($content, $bodyPosition);
52			}
53
54			$response->setContent($content);
55			}
56
57			return $response;
58			}
59			}
60

spatie / laravel-cookie-consent

GitHub Access Token became invalid

Pull Request — master (#19)

CookieConsentMiddleware::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like