CookieConsentMiddleware::addCookieConsentScriptToResponse() - Code Metrics - Inspection of "Add excluded routes functionality" - spatie/laravel-cookie-consent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#92)

unknown

created 2019-03-18 22:18 UTC

addCookieConsentScriptToResponse() A

↳ Parent: CookieConsentMiddleware

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0

<?php

namespace Spatie\CookieConsent;

use Closure;
use Illuminate\Http\Response;

class CookieConsentMiddleware
{
    public function handle($request, Closure $next)
    {
        $response = $next($request);

        if (! config('cookie-consent.enabled')) {
            return $response;
        }

        if (! $response instanceof Response) {
            return $response;
        }

        if ($this->excluded($request)) {
            return $response;
        }

        if (! $this->containsBodyTag($response)) {
            return $response;
        }

        return $this->addCookieConsentScriptToResponse($response);
    }

    /**
     * Excluded routes.
     *
     * @param $request
     * @return bool
     */
    protected function excluded($request): bool
    {
        return in_array($request->route()->getName(), config('cookie-consent.excluded' ?: []));
    }
    
    protected function containsBodyTag(Response $response): bool
    {
        return $this->getLastClosingBodyTagPosition($response->getContent()) !== false;
    }

    /**
     * @param \Illuminate\Http\Response $response
     *
     * @return $this
     */
    protected function addCookieConsentScriptToResponse(Response $response)
    {
        $content = $response->getContent();

        $closingBodyTagPosition = $this->getLastClosingBodyTagPosition($content);

        $content = ''
            .substr($content, 0, $closingBodyTagPosition)
            .view('cookieConsent::index')->render()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            .substr($content, $closingBodyTagPosition);

        return $response->setContent($content);
    }

    protected function getLastClosingBodyTagPosition(string $content = '')
    {
        return strripos($content, '</body>');
    }
}


1			<?php
2
3			namespace Spatie\CookieConsent;
4
5			use Closure;
6			use Illuminate\Http\Response;
7
8			class CookieConsentMiddleware
9			{
10			public function handle($request, Closure $next)
11			{
12			$response = $next($request);
13
14			if (! config('cookie-consent.enabled')) {
15			return $response;
16			}
17
18			if (! $response instanceof Response) {
19			return $response;
20			}
21
22			if ($this->excluded($request)) {
23			return $response;
24			}
25
26			if (! $this->containsBodyTag($response)) {
27			return $response;
28			}
29
30			return $this->addCookieConsentScriptToResponse($response);
31			}
32
33			/**
34			* Excluded routes.
35			*
36			* @param $request
37			* @return bool
38			*/
39			protected function excluded($request): bool
40			{
41			return in_array($request->route()->getName(), config('cookie-consent.excluded' ?: []));
42			}
43
44			protected function containsBodyTag(Response $response): bool
45			{
46			return $this->getLastClosingBodyTagPosition($response->getContent()) !== false;
47			}
48
49			/**
50			* @param \Illuminate\Http\Response $response
51			*
52			* @return $this
53			*/
54			protected function addCookieConsentScriptToResponse(Response $response)
55			{
56			$content = $response->getContent();
57
58			$closingBodyTagPosition = $this->getLastClosingBodyTagPosition($content);
59
60			$content = ''
61			.substr($content, 0, $closingBodyTagPosition)
62			.view('cookieConsent::index')->render()
			0 ignored issues – show Bug introduced 2016-09-23 07:06 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
63			.substr($content, $closingBodyTagPosition);
64
65			return $response->setContent($content);
66			}
67
68			protected function getLastClosingBodyTagPosition(string $content = '')
69			{
70			return strripos($content, '</body>');
71			}
72			}
73

spatie / laravel-cookie-consent

GitHub Access Token became invalid

Pull Request — master (#92)

addCookieConsentScriptToResponse() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like