CookieConsentMiddleware::handle() - Code Metrics - Inspection of "Remove Application dependency from middleware" - spatie/laravel-cookie-consent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#83)

by Sven

created 2018-11-20 12:42 UTC

CookieConsentMiddleware::handle() A

↳ Parent: CookieConsentMiddleware

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	3
nop	2
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0

<?php

namespace Spatie\CookieConsent;

use Closure;
use Illuminate\Http\Response;

class CookieConsentMiddleware
{
    public function handle($request, Closure $next)
    {
        $response = $next($request);

        if (! $response instanceof Response) {
            return $response;
        }

        if (! $this->containsBodyTag($response)) {
            return $response;
        }

        return $this->addCookieConsentScriptToResponse($response);
    }

    protected function containsBodyTag(Response $response): bool
    {
        return $this->getLastClosingBodyTagPosition($response->getContent()) !== false;
    }

    /**
     * @param \Illuminate\Http\Response $response
     *
     * @return $this
     */
    protected function addCookieConsentScriptToResponse(Response $response)
    {
        $content = $response->getContent();

        $closingBodyTagPosition = $this->getLastClosingBodyTagPosition($content);

        $content = ''
            .substr($content, 0, $closingBodyTagPosition)
            .view('cookieConsent::index')->render()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            .substr($content, $closingBodyTagPosition);

        return $response->setContent($content);
    }

    protected function getLastClosingBodyTagPosition(string $content = '')
    {
        return strripos($content, '</body>');
    }
}


1			<?php
2
3			namespace Spatie\CookieConsent;
4
5			use Closure;
6			use Illuminate\Http\Response;
7
8			class CookieConsentMiddleware
9			{
10			public function handle($request, Closure $next)
11			{
12			$response = $next($request);
13
14			if (! $response instanceof Response) {
15			return $response;
16			}
17
18			if (! $this->containsBodyTag($response)) {
19			return $response;
20			}
21
22			return $this->addCookieConsentScriptToResponse($response);
23			}
24
25			protected function containsBodyTag(Response $response): bool
26			{
27			return $this->getLastClosingBodyTagPosition($response->getContent()) !== false;
28			}
29
30			/**
31			* @param \Illuminate\Http\Response $response
32			*
33			* @return $this
34			*/
35			protected function addCookieConsentScriptToResponse(Response $response)
36			{
37			$content = $response->getContent();
38
39			$closingBodyTagPosition = $this->getLastClosingBodyTagPosition($content);
40
41			$content = ''
42			.substr($content, 0, $closingBodyTagPosition)
43			.view('cookieConsent::index')->render()
			0 ignored issues – show Bug introduced 2016-09-23 07:06 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44			.substr($content, $closingBodyTagPosition);
45
46			return $response->setContent($content);
47			}
48
49			protected function getLastClosingBodyTagPosition(string $content = '')
50			{
51			return strripos($content, '</body>');
52			}
53			}
54

spatie / laravel-cookie-consent

GitHub Access Token became invalid

Pull Request — master (#83)

CookieConsentMiddleware::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like