Validate::__invoke() - Code Metrics - Inspection of "refactor to invokable classes" - spatie/laravel-collection-macros - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#161)

unknown

created 2019-02-27 02:42 UTC

Validate::__invoke() B

↳ Parent: Validate

Complexity

Conditions	7
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	27
rs	8.5546
c	0
b	0
f	0
cc	7
nc	1
nop	0

<?php

namespace Spatie\CollectionMacros\Macros;

/*
 * Returns true if $callback returns true for every item. If $callback
 * is a string or an array, regard it as a validation rule.
 *
 * @param string|callable $callback
 *
 * @return bool
 */
class Validate {
    public function __invoke() {
        return function ($callback): bool {
            if (is_string($callback) || is_array($callback)) {
                $validationRule = $callback;

                $callback = function ($item) use ($validationRule) {
                    if (! is_array($item)) {
                        $item = ['default' => $item];
                    }

                    if (! is_array($validationRule)) {
                        $validationRule = ['default' => $validationRule];
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                    }

                    return app('validator')->make($item, $validationRule)->passes();
                };
            }

            foreach ($this->items as $item) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                if (! $callback($item)) {
                    return false;
                }
            }

            return true;
        };
    }
}


Pull Request — master (#161)

Validate::__invoke() B

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

1			<?php
2
3			namespace Spatie\CollectionMacros\Macros;
4
5			/*
6			* Returns true if $callback returns true for every item. If $callback
7			* is a string or an array, regard it as a validation rule.
8			*
9			* @param string\|callable $callback
10			*
11			* @return bool
12			*/
13			class Validate {
14			public function __invoke() {
15			return function ($callback): bool {
16			if (is_string($callback) \|\| is_array($callback)) {
17			$validationRule = $callback;
18
19			$callback = function ($item) use ($validationRule) {
20			if (! is_array($item)) {
21			$item = ['default' => $item];
22			}
23
24			if (! is_array($validationRule)) {
25			$validationRule = ['default' => $validationRule];
			0 ignored issues – show Bug introduced 2016-07-27 15:04 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$validationRule`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
26			}
27
28			return app('validator')->make($item, $validationRule)->passes();
29			};
30			}
31
32			foreach ($this->items as $item) {
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The property `items` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33			if (! $callback($item)) {
34			return false;
35			}
36			}
37
38			return true;
39			};
40			}
41			}
42

spatie / laravel-collection-macros

Pull Request — master (#161)

Validate::__invoke() B

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like