Transpose::__invoke() - Code Metrics - Inspection of "refactor to invokable classes" - spatie/laravel-collection-macros - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#161)

unknown

created 2019-02-27 02:42 UTC

Transpose::__invoke() B

↳ Parent: Transpose

Complexity

Conditions	7
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.5866
c	0
b	0
f	0
cc	7
nc	1
nop	0

<?php

namespace Spatie\CollectionMacros\Macros;

use Illuminate\Support\Collection;

/*
 * Transpose an array.
 *
 * @return \Illuminate\Support\Collection
 *
 * @throws \LengthException
 */
class Transpose {
    public function __invoke() {
        return function (): Collection {
            if ($this->isEmpty()) {

                return new static();
            }

            $firstItem = $this->first();


            $expectedLength = is_array($firstItem) || $firstItem instanceof Countable ? count($firstItem) : 0;
if ($x instanceof DoesNotExist) {
    // Do something.
}

            array_walk($this->items, function ($row) use ($expectedLength) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                if ((is_array($row) || $row instanceof Countable) && count($row) !== $expectedLength) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                    throw new \LengthException("Element's length must be equal.");
                }
            });

            $items = array_map(function (...$items) {
                return new static($items);

            }, ...array_map(function ($items) {
                return $this->getArrayableItems($items);

            }, array_values($this->items)));

            return new static($items);

        };
    }
}


1			<?php
2
3			namespace Spatie\CollectionMacros\Macros;
4
5			use Illuminate\Support\Collection;
6
7			/*
8			* Transpose an array.
9			*
10			* @return \Illuminate\Support\Collection
11			*
12			* @throws \LengthException
13			*/
14			class Transpose {
15			public function __invoke() {
16			return function (): Collection {
17			if ($this->isEmpty()) {
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `isEmpty()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\Transpose>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
18			return new static();
19			}
20
21			$firstItem = $this->first();
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `first()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\Transpose>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
22
23			$expectedLength = is_array($firstItem) \|\| $firstItem instanceof Countable ? count($firstItem) : 0;
			0 ignored issues – show Bug introduced 2019-02-27 02:43 UTC by Report Bug Copy Issue Report The class `Spatie\CollectionMacros\Macros\Countable` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
24
25			array_walk($this->items, function ($row) use ($expectedLength) {
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The property `items` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			if ((is_array($row) \|\| $row instanceof Countable) && count($row) !== $expectedLength) {
			0 ignored issues – show Bug introduced 2019-02-27 02:43 UTC by Report Bug Copy Issue Report The class `Spatie\CollectionMacros\Macros\Countable` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
27			throw new \LengthException("Element's length must be equal.");
28			}
29			});
30
31			$items = array_map(function (...$items) {
32			return new static($items);
			0 ignored issues – show Unused Code introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The call to `Transpose::__construct()` has too many arguments starting with `$items`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
33			}, ...array_map(function ($items) {
34			return $this->getArrayableItems($items);
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `getArrayableItems()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\Transpose>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35			}, array_values($this->items)));
36
37			return new static($items);
			0 ignored issues – show Unused Code introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The call to `Transpose::__construct()` has too many arguments starting with `$items`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
38			};
39			}
40			}
41

spatie / laravel-collection-macros

Pull Request — master (#161)

Transpose::__invoke() B

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like