Join::__invoke() - Code Metrics - Inspection of "refactor to invokable classes" - spatie/laravel-collection-macros - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#161)

unknown

created 2019-02-27 02:42 UTC

Join::__invoke() A

↳ Parent: Join

Complexity

Conditions	4
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.584
c	0
b	0
f	0
cc	4
nc	1
nop	0

<?php

namespace Spatie\CollectionMacros\Macros;

use Illuminate\Support\Collection;

/*
 * Join all items from the collection using a string. The final items can use a separate glue string.
 *
 */
class Join {
    public function __invoke() {
        return function (string $glue, string $finalGlue = ''): string {
            if ($finalGlue === '') {
                return $this->implode($glue);

            };

            if ($this->count() === 0) {

                return '';
            }

            if ($this->count() === 1) {

                return $this->last();

            }

            $collection = new Collection($this->items);
class MyClass { }

$x = new MyClass();
$x->foo = true;

            $finalItem = $collection->pop();

            return $collection->implode($glue) . $finalGlue . $finalItem;
        };
    }
}


1			<?php
2
3			namespace Spatie\CollectionMacros\Macros;
4
5			use Illuminate\Support\Collection;
6
7			/*
8			* Join all items from the collection using a string. The final items can use a separate glue string.
9			*
10			*/
11			class Join {
12			public function __invoke() {
13			return function (string $glue, string $finalGlue = ''): string {
14			if ($finalGlue === '') {
15			return $this->implode($glue);
			0 ignored issues – show Bug introduced 2019-02-27 02:43 UTC by Report Bug Copy Issue Report The method `implode()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\Join>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
16			};
17
18			if ($this->count() === 0) {
			0 ignored issues – show Bug introduced 2019-02-27 02:43 UTC by Report Bug Copy Issue Report The method `count()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\Join>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
19			return '';
20			}
21
22			if ($this->count() === 1) {
			0 ignored issues – show Bug introduced 2019-02-27 02:43 UTC by Report Bug Copy Issue Report The method `count()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\Join>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
23			return $this->last();
			0 ignored issues – show Bug introduced 2019-02-27 02:43 UTC by Report Bug Copy Issue Report The method `last()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\Join>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
24			}
25
26			$collection = new Collection($this->items);
			0 ignored issues – show Bug introduced 2019-02-27 02:43 UTC by Report Bug Copy Issue Report The property `items` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27
28			$finalItem = $collection->pop();
29
30			return $collection->implode($glue) . $finalGlue . $finalItem;
31			};
32			}
33			}
34

spatie / laravel-collection-macros

Pull Request — master (#161)

Join::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like