SectionBy::sectionBy() - Code Metrics - Inspection of "Use mixin." - spatie/laravel-collection-macros - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#156)

by Lucas

created 2019-02-25 16:56 UTC

SectionBy::sectionBy() A

↳ Parent: SectionBy

Complexity

Conditions	5
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.2408
c	0
b	0
f	0
cc	5
nc	1
nop	0

<?php namespace Spatie\CollectionMacros\Macros;

use Illuminate\Support\Collection;


class SectionBy
{
    /*
     * Splits a collection into sections grouped by a given key.
     *
     * @param mixed $key
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param bool $preserveKeys
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param mixed $sectionKey
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param mixed $itemsKey
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return \Illuminate\Support\Collection
     */
    public function sectionBy()
    {
        return function ($key, bool $preserveKeys = false, $sectionKey = 0, $itemsKey = 1): Collection {
            $sectionNameRetriever = $this->valueRetriever($key);


            $results = new Collection();

            foreach ($this->items as $key => $value) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $sectionName = $sectionNameRetriever($value);

                if (! $results->last() || $results->last()->get($sectionKey) !== $sectionName) {
                    $results->push(new Collection([
                        $sectionKey => $sectionName,
                        $itemsKey => new Collection(),
                    ]));
                }

                $results->last()->get($itemsKey)->offsetSet($preserveKeys ? $key : null, $value);
            }

            return $results;
        };
    }
}


1			<?php namespace Spatie\CollectionMacros\Macros;
2
3			use Illuminate\Support\Collection;
4
5
6			class SectionBy
7			{
8			/*
9			* Splits a collection into sections grouped by a given key.
10			*
11			* @param mixed $key
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report There is no parameter named `$key`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
12			* @param bool $preserveKeys
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report There is no parameter named `$preserveKeys`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
13			* @param mixed $sectionKey
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report There is no parameter named `$sectionKey`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
14			* @param mixed $itemsKey
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report There is no parameter named `$itemsKey`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
15			*
16			* @return \Illuminate\Support\Collection
17			*/
18			public function sectionBy()
19			{
20			return function ($key, bool $preserveKeys = false, $sectionKey = 0, $itemsKey = 1): Collection {
21			$sectionNameRetriever = $this->valueRetriever($key);
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `valueRetriever()` does not seem to exist on `object<Spatie\CollectionMacros\Macros\SectionBy>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
22
23			$results = new Collection();
24
25			foreach ($this->items as $key => $value) {
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The property `items` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			$sectionName = $sectionNameRetriever($value);
27
28			if (! $results->last() \|\| $results->last()->get($sectionKey) !== $sectionName) {
29			$results->push(new Collection([
30			$sectionKey => $sectionName,
31			$itemsKey => new Collection(),
32			]));
33			}
34
35			$results->last()->get($itemsKey)->offsetSet($preserveKeys ? $key : null, $value);
36			}
37
38			return $results;
39			};
40			}
41			}
42

spatie / laravel-collection-macros

Pull Request — master (#156)

SectionBy::sectionBy() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like