ParallelMap::parallelMap() - Code Metrics - Inspection of "Use mixin." - spatie/laravel-collection-macros - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#156)

by Lucas

created 2019-02-25 16:56 UTC

ParallelMap::parallelMap() A

↳ Parent: ParallelMap

Complexity

Conditions	3
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	3
nc	1
nop	0

<?php namespace Spatie\CollectionMacros\Macros;

use Amp\Parallel\Worker\Pool;
use function Amp\Promise\wait;
use Illuminate\Support\Collection;
use Amp\Parallel\Worker\DefaultPool;
use function Amp\ParallelFunctions\parallelMap;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php


class ParallelMap
{
    /*
     * Identical to map but each item will be processed in parallel.
     *
     * This function requires the installation of amphp/parallel-functions
     *
     * @param callable $callback
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return \Illuminate\Support\Collection
     */
    public function parallelMap()
    {
        return function (callable $callback, $workers = null): Collection {
            $pool = null;

            if ($workers instanceof Pool) {
                $pool = $workers;
            }

            if (is_int($workers)) {
                $pool = new DefaultPool($workers);
            }

            $promises = parallelMap($this->items, $callback, $pool);
class MyClass { }

$x = new MyClass();
$x->foo = true;

            return new static(wait($promises));

        };
    }
}


1			<?php namespace Spatie\CollectionMacros\Macros;
2
3			use Amp\Parallel\Worker\Pool;
4			use function Amp\Promise\wait;
5			use Illuminate\Support\Collection;
6			use Amp\Parallel\Worker\DefaultPool;
7			use function Amp\ParallelFunctions\parallelMap;
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Spatie\CollectionMacros\Macros\parallelMap`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8
9
10			class ParallelMap
11			{
12			/*
13			* Identical to map but each item will be processed in parallel.
14			*
15			* This function requires the installation of amphp/parallel-functions
16			*
17			* @param callable $callback
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report There is no parameter named `$callback`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
18			*
19			* @return \Illuminate\Support\Collection
20			*/
21			public function parallelMap()
22			{
23			return function (callable $callback, $workers = null): Collection {
24			$pool = null;
25
26			if ($workers instanceof Pool) {
27			$pool = $workers;
28			}
29
30			if (is_int($workers)) {
31			$pool = new DefaultPool($workers);
32			}
33
34			$promises = parallelMap($this->items, $callback, $pool);
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The property `items` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35
36			return new static(wait($promises));
			0 ignored issues – show Unused Code introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The call to `ParallelMap::__construct()` has too many arguments starting with `\Amp\Promise\wait($promises)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
37			};
38			}
39			}
40

spatie / laravel-collection-macros

Pull Request — master (#156)

ParallelMap::parallelMap() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like