SliceBefore - Code Metrics - Inspection of "Use mixin." - spatie/laravel-collection-macros - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#156)

by Lucas

created 2019-02-25 16:56 UTC

SliceBefore A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	0
dl	0
loc	49
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	sliceBefore()	0	38	5

<?php namespace Spatie\CollectionMacros\Macros;

use Illuminate\Support\Collection;


class SliceBefore
{
    /*
     * Slice a collection before a given callback is met into separate chunks
     *
     * @param callable $callback
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param bool $preserveKeys
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return \Illuminate\Support\Collection
     */
    public function sliceBefore()
    {
        return function ($callback, bool $preserveKeys = false): Collection {
            if ($this->isEmpty()) {

                return new static();
            }

            if (! $preserveKeys) {
                $sliced = new static([

                    new static([$this->first()]),

                ]);

                return $this->eachCons(2)->reduce(function ($sliced, $previousAndCurrent) use ($callback) {

                    list($previousItem, $item) = $previousAndCurrent;

                    $callback($item, $previousItem) ? $sliced->push(new static([$item])) : $sliced->last()->push($item);


                    return $sliced;
                }, $sliced);
            }

            $sliced = new static([$this->take(1)]);


            return $this->eachCons(2, $preserveKeys)->reduce(function ($sliced, $previousAndCurrent) use ($callback) {

                $previousItem = $previousAndCurrent->take(1);
                $item = $previousAndCurrent->take(-1);

                $itemKey = $item->keys()->first();
                $valuesItem = $item->first();
                $valuesPreviousItem = $previousItem->first();

                $callback($valuesItem, $valuesPreviousItem) ? $sliced->push($item) : $sliced->last()
                                                                                            ->put($itemKey, $valuesItem);

                return $sliced;
            }, $sliced);
        };
    }
}


1			<?php namespace Spatie\CollectionMacros\Macros;
2
3			use Illuminate\Support\Collection;
4
5
6			class SliceBefore
7			{
8			/*
9			* Slice a collection before a given callback is met into separate chunks
10			*
11			* @param callable $callback
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report There is no parameter named `$callback`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
12			* @param bool $preserveKeys
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report There is no parameter named `$preserveKeys`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
13			*
14			* @return \Illuminate\Support\Collection
15			*/
16			public function sliceBefore()
17			{
18			return function ($callback, bool $preserveKeys = false): Collection {
19			if ($this->isEmpty()) {
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `isEmpty()` does not seem to exist on `object<Spatie\Collection...ros\Macros\SliceBefore>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
20			return new static();
21			}
22
23			if (! $preserveKeys) {
24			$sliced = new static([
			0 ignored issues – show Unused Code introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The call to `SliceBefore::__construct()` has too many arguments starting with `array(new static(array($this->first())))`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
25			new static([$this->first()]),
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `first()` does not seem to exist on `object<Spatie\Collection...ros\Macros\SliceBefore>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Unused Code introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The call to `SliceBefore::__construct()` has too many arguments starting with `array($this->first())`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
26			]);
27
28			return $this->eachCons(2)->reduce(function ($sliced, $previousAndCurrent) use ($callback) {
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `eachCons()` does not seem to exist on `object<Spatie\Collection...ros\Macros\SliceBefore>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29			list($previousItem, $item) = $previousAndCurrent;
30
31			$callback($item, $previousItem) ? $sliced->push(new static([$item])) : $sliced->last()->push($item);
			0 ignored issues – show Unused Code introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The call to `SliceBefore::__construct()` has too many arguments starting with `array($item)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
32
33			return $sliced;
34			}, $sliced);
35			}
36
37			$sliced = new static([$this->take(1)]);
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `take()` does not seem to exist on `object<Spatie\Collection...ros\Macros\SliceBefore>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Unused Code introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The call to `SliceBefore::__construct()` has too many arguments starting with `array($this->take(1))`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
38
39			return $this->eachCons(2, $preserveKeys)->reduce(function ($sliced, $previousAndCurrent) use ($callback) {
			0 ignored issues – show Bug introduced 2019-02-25 16:59 UTC by Report Bug Copy Issue Report The method `eachCons()` does not seem to exist on `object<Spatie\Collection...ros\Macros\SliceBefore>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
40			$previousItem = $previousAndCurrent->take(1);
41			$item = $previousAndCurrent->take(-1);
42
43			$itemKey = $item->keys()->first();
44			$valuesItem = $item->first();
45			$valuesPreviousItem = $previousItem->first();
46
47			$callback($valuesItem, $valuesPreviousItem) ? $sliced->push($item) : $sliced->last()
48			->put($itemKey, $valuesItem);
49
50			return $sliced;
51			}, $sliced);
52			};
53			}
54			}
55

spatie / laravel-collection-macros

Pull Request — master (#156)

SliceBefore A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like