BladeX::component() - Code Metrics - Inspection of "commit" - spatie/laravel-blade-x - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 85ca6a...91d846 )

by Freek

created 2018-09-28 14:08 UTC

BladeX::component() A

↳ Parent: BladeX

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace Spatie\BladeX;

use Illuminate\Support\Facades\File;
use Spatie\BladeX\Exceptions\CouldNotRegisterComponent;
use Symfony\Component\Finder\SplFileInfo;
use Symfony\Component\DomCrawler\Crawler;

class BladeX
{
    /** @var array */
    public $registeredComponents = [];

    public function component(string $componentName, string $viewName)
    {
        if (! view()->exists($viewName)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            throw CouldNotRegisterComponent::viewNotFound($componentName, $viewName);
        }

        $this->registeredComponents[$componentName] = $viewName;
    }

    public function components(string $directory)
    {
        collect(File::allFiles($directory))
            ->filter(function (SplFileInfo $file) {
                return ends_with($file->getFilename(), '.blade.php');
            })

            ->each(function(SplFileInfo $fileInfo) {
                $componentName = rtrim($fileInfo->getFilename(), '.blade.php');

                $viewName = $this->getViewName($fileInfo->getPathname());

                dd($componentName, $viewName);
            });
    }

    private function getViewName(string $pathName): string
    {
        foreach (app('view.finder')->getPaths() as $registeredViewPath) {
            dump('foreach', $pathName, realpath($registeredViewPath), '---');
            $pathName = str_replace(realpath($registeredViewPath), '', $pathName);
        }

        return $pathName;
    }

    public function compile(string $view): string
    {
        $crawler = new Crawler($view);

        foreach($this->registeredComponents as $componentName => $classOrView) {
            $crawler
                ->filter($componentName)
                ->each(function (Crawler $subCrawler) use ($classOrView) {
                    $node = $subCrawler->getNode(0);

                    $node->parentNode->replaceChild(
                        $node->ownerDocument->createTextNode("@include({$classOrView})"), // TEMP: @include everything
                        $node
                    );
                });
        }

        return $crawler->html();
    }
}


1			<?php
2
3			namespace Spatie\BladeX;
4
5			use Illuminate\Support\Facades\File;
6			use Spatie\BladeX\Exceptions\CouldNotRegisterComponent;
7			use Symfony\Component\Finder\SplFileInfo;
8			use Symfony\Component\DomCrawler\Crawler;
9
10			class BladeX
11			{
12			/** @var array */
13			public $registeredComponents = [];
14
15			public function component(string $componentName, string $viewName)
16			{
17			if (! view()->exists($viewName)) {
			0 ignored issues – show Bug introduced 2018-09-28 14:10 UTC by Report Bug Copy Issue Report The method `exists` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
18			throw CouldNotRegisterComponent::viewNotFound($componentName, $viewName);
19			}
20
21			$this->registeredComponents[$componentName] = $viewName;
22			}
23
24			public function components(string $directory)
25			{
26			collect(File::allFiles($directory))
27			->filter(function (SplFileInfo $file) {
28			return ends_with($file->getFilename(), '.blade.php');
29			})
30
31			->each(function(SplFileInfo $fileInfo) {
32			$componentName = rtrim($fileInfo->getFilename(), '.blade.php');
33
34			$viewName = $this->getViewName($fileInfo->getPathname());
35
36			dd($componentName, $viewName);
37			});
38			}
39
40			private function getViewName(string $pathName): string
41			{
42			foreach (app('view.finder')->getPaths() as $registeredViewPath) {
43			dump('foreach', $pathName, realpath($registeredViewPath), '---');
44			$pathName = str_replace(realpath($registeredViewPath), '', $pathName);
45			}
46
47			return $pathName;
48			}
49
50			public function compile(string $view): string
51			{
52			$crawler = new Crawler($view);
53
54			foreach($this->registeredComponents as $componentName => $classOrView) {
55			$crawler
56			->filter($componentName)
57			->each(function (Crawler $subCrawler) use ($classOrView) {
58			$node = $subCrawler->getNode(0);
59
60			$node->parentNode->replaceChild(
61			$node->ownerDocument->createTextNode("@include({$classOrView})"), // TEMP: @include everything
62			$node
63			);
64			});
65			}
66
67			return $crawler->html();
68			}
69			}
70

spatie / laravel-blade-x

Push — master ( 85ca6a...91d846 )

BladeX::component() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like