spatie / laravel-blade-x

src/BladeXComponent.php

<?php

namespace Spatie\BladeX;

use Closure;
use Illuminate\Contracts\Support\Arrayable;
use Spatie\BladeX\Exceptions\CouldNotRegisterBladeXComponent;

class BladeXComponent
{
    /** @var string */
    public $bladeViewName;

    /** @var string */
    public $name;

    /** @var string */
    public $viewModel;

    public static function make(string $bladeViewName, string $name = '')

The parameter $name is not used and could be removed.

    {
        return new BladeXComponent($bladeViewName, $name = '');
    }

    public function __construct(string $bladeViewName, string $name = '')
    {
        $bladeViewName = str_replace('.', '/', $bladeViewName);

        if ($name === '') {
            $baseComponentName = explode('/', $bladeViewName);

            $name = kebab_case(end($baseComponentName));
        }

        if (! view()->exists($bladeViewName)) {

The method exists does only exist in Illuminate\Contracts\View\Factory, but not in Illuminate\View\View.

            throw CouldNotRegisterBladeXComponent::viewNotFound($bladeViewName, $name);
        }

        $this->bladeViewName = $bladeViewName;

        $this->name = $name;
    }

    /**
     * @param string|\Closure $viewModel
     *
     * @return $this
     */
    public function viewModel($viewModel)
    {
        if (is_callable($viewModel)) {
            $this->viewModel = $this->createClosureViewModel($viewModel);

It seems like $viewModel defined by parameter $viewModel on line 49 can also be of type string; however, Spatie\BladeX\BladeXComponent::createClosureViewModel() does only seem to accept object<Closure>, maybe add an additional type check?

            return $this;
        }

        if (! class_exists($viewModel)) {
            throw CouldNotRegisterBladeXComponent::viewModelNotFound($this->name, $viewModel);

It seems like $viewModel defined by parameter $viewModel on line 49 can also be of type object<Closure>; however, Spatie\BladeX\Exceptions\CouldNotRegisterBladeXComponent::viewModelNotFound() does only seem to accept string, maybe add an additional type check?

        }

        if (! is_a($viewModel, Arrayable::class, true)) {
            throw CouldNotRegisterBladeXComponent::viewModelNotArrayable($this->name, $viewModel);

It seems like $viewModel defined by parameter $viewModel on line 49 can also be of type object<Closure>; however, Spatie\BladeX\Exceptions\CouldNotRegisterBladeXComponent::viewModelNotArrayable() does only seem to accept string, maybe add an additional type check?

        }

        $this->viewModel = $viewModel;

It seems like $viewModel can also be of type object<Closure>. However, the property $viewModel is declared as type string. Maybe add an additional type check?

        return $this;
    }

    protected function createClosureViewModel(Closure $closure): string
    {
        static $viewModelCounter = 0;

        $viewModelClassName = 'bladex.viewModel.'.$viewModelCounter++;

        app()->bind($viewModelClassName, function ($app, $arguments) use ($closure) {
            return (new ClosureViewModel($arguments ?? []))
                ->withClosure($closure);
        });

        return $viewModelClassName;
    }
}