Issues in BladeXCompiler.php - Fixed Issues - Inspection of "Merge pull request #46 from spatie/v2" - spatie/laravel-blade-x - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d0a237...a1b9c8 )

by Freek

created 2018-10-08 07:47 UTC

src/BladeXCompiler.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Alex Vanderbist 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\BladeX;

class BladeXCompiler
{
    /** @var \Spatie\BladeX\BladeX */
    protected $bladeX;

    public function __construct(BladeX $bladeX)
    {
        return $this->bladeX = $bladeX;
    }

    public function compile(string $viewContents): string
    {
        return array_reduce(
            $this->bladeX->getRegisteredComponents(),
            [$this, 'parseComponentHtml'],
            $viewContents
        );
    }

    protected function parseComponentHtml(string $viewContents, BladeXComponent $bladeXComponent)
    {
        $viewContents = $this->parseSlots($viewContents);

        $viewContents = $this->parseSelfClosingTags($viewContents, $bladeXComponent);

        $viewContents = $this->parseOpeningTags($viewContents, $bladeXComponent);

        $viewContents = $this->parseClosingTags($viewContents, $bladeXComponent);

        return $viewContents;
    }

    protected function parseSelfClosingTags(string $viewContents, BladeXComponent $bladeXComponent): string

    {
        $prefix = $this->bladeX->getPrefix();

        $pattern = "/<\s*{$prefix}{$bladeXComponent->name}\s*(?<attributes>.*)\s*\/>/";

        return preg_replace_callback($pattern, function (array $matches) use ($bladeXComponent) {
            $attributes = $this->getAttributesFromAttributeString($matches['attributes']);

            return $this->componentString($bladeXComponent, $attributes);
        }, $viewContents);
    }

    protected function parseOpeningTags(string $viewContents, BladeXComponent $bladeXComponent): string

    {
        $prefix = $this->bladeX->getPrefix();

        $pattern = "/<\s*{$prefix}{$bladeXComponent->name}(?<attributes>(?:\s+[\w\-:]+=(?:\\\"[^\\\"]+\\\"|\'[^\']+\'|[^\'\\\"=<>]+))*\s*)(?<![\/=\-])>/";

        return preg_replace_callback($pattern, function (array $matches) use ($bladeXComponent) {
            $attributes = $this->getAttributesFromAttributeString($matches['attributes']);

            return $this->componentStartString($bladeXComponent, $attributes);
        }, $viewContents);
    }

    protected function parseClosingTags(string $viewContents, BladeXComponent $bladeXComponent): string
    {
        $prefix = $this->bladeX->getPrefix();

        $pattern = "/<\/\s*{$prefix}{$bladeXComponent->name}[^>]*>/";

        return preg_replace($pattern, $this->componentEndString($bladeXComponent), $viewContents);
    }

    protected function componentString(BladeXComponent $bladeXComponent, array $attributes = []): string
    {
        return $this->componentStartString($bladeXComponent, $attributes).$this->componentEndString($bladeXComponent);
    }

    protected function componentStartString(BladeXComponent $bladeXComponent, array $attributes = []): string
    {
        $attributesString = $this->attributesToString($attributes);

        $componentAttributeString = "[{$attributesString}]";

        if ($bladeXComponent->bladeViewName === 'bladex::context') {
            return "@php(app(Spatie\BladeX\ContextStack::class)->push({$componentAttributeString}))";
        }

        if ($bladeXComponent->viewModel) {
            $componentAttributeString = "
                array_merge(
                    app(Spatie\BladeX\ContextStack::class)->read(),
                    {$componentAttributeString},
                    app(
                        '{$bladeXComponent->viewModel}',
                        array_merge(
                            app(Spatie\BladeX\ContextStack::class)->read(),
                            {$componentAttributeString}
                        )
                    )->toArray()
                )";
        }

        return " @component(
           '{$bladeXComponent->bladeViewName}',
           array_merge(app(Spatie\BladeX\ContextStack::class)->read(), {$componentAttributeString})) ";
    }

    protected function componentEndString(BladeXComponent $bladeXComponent): string
    {
        if ($bladeXComponent->bladeViewName === 'bladex::context') {
            return "@php(app(Spatie\BladeX\ContextStack::class)->pop())";
        }

        return ' @endcomponent ';
    }

    protected function getAttributesFromAttributeString(string $attributeString): array
    {
        $attributeString = $this->parseBindAttributes($attributeString);

        $pattern = '/(?<attribute>[\w:-]+)(=(?<value>(\"[^\"]+\"|\\\'[^\\\']+\\\'|[^\s>]+)))?/';

        if (! preg_match_all($pattern, $attributeString, $matches, PREG_SET_ORDER)) {
            return [];
        }

        return collect($matches)->mapWithKeys(function ($match) {
            $attribute = camel_case($match['attribute']);
            $value = $match['value'] ?? null;

            if (is_null($value)) {
                $value = 'true';
                $attribute = str_start($attribute, 'bind:');
            }

            $value = $this->stripQuotes($value);

            if (! starts_with($attribute, 'bind:')) {
                $value = str_replace("'", "\\'", $value);
                $value = "'{$value}'";
            }

            if (starts_with($attribute, 'bind:')) {
                $attribute = str_after($attribute, 'bind:');
            }

            return [$attribute => $value];
        })->toArray();
    }

    protected function parseSlots(string $viewContents): string
    {
        $openingPattern = '/<\s*slot\s+name=(?<name>(\"[^\"]+\"|\\\'[^\\\']+\\\'|[^\s>]+))\s*>/';
        $viewContents = preg_replace_callback($openingPattern, function ($matches) {
            $name = $this->stripQuotes($matches['name']);

            return " @slot('{$name}') ";
        }, $viewContents);

        $closingPattern = '/<\/\s*slot[^>]*>/';
        $viewContents = preg_replace($closingPattern, ' @endslot', $viewContents);

        return $viewContents;
    }

    protected function isOpeningHtmlTag(string $tagName, string $html): bool
    {
        return ! ends_with($html, ["</{$tagName}>", '/>']);
    }

    protected function parseBindAttributes(string $attributeString): string
    {
        return preg_replace("/\s*:([\w-]+)=/m", ' bind:$1=', $attributeString);
    }

    protected function attributesToString(array $attributes): string
    {
        return collect($attributes)
            ->map(function (string $value, string $attribute) {
                return "'{$attribute}' => {$value}";
            })
            ->implode(',');
    }

    protected function stripQuotes(string $string): string
    {
        if (starts_with($string, ['"', '\''])) {
            return substr($string, 1, -1);
        }

        return $string;
    }
}


1		<?php
2
3		namespace Spatie\BladeX;
4
5		class BladeXCompiler
6		{
7		/** @var \Spatie\BladeX\BladeX */
8		protected $bladeX;
9
10		public function __construct(BladeX $bladeX)
11		{
12		return $this->bladeX = $bladeX;
13		}
14
15		public function compile(string $viewContents): string
16		{
17		return array_reduce(
18		$this->bladeX->getRegisteredComponents(),
19		[$this, 'parseComponentHtml'],
20		$viewContents
21		);
22		}
23
24		protected function parseComponentHtml(string $viewContents, BladeXComponent $bladeXComponent)
25		{
26		$viewContents = $this->parseSlots($viewContents);
27
28		$viewContents = $this->parseSelfClosingTags($viewContents, $bladeXComponent);
29
30		$viewContents = $this->parseOpeningTags($viewContents, $bladeXComponent);
31
32		$viewContents = $this->parseClosingTags($viewContents, $bladeXComponent);
33
34		return $viewContents;
35		}
36
37	View Code Duplication	protected function parseSelfClosingTags(string $viewContents, BladeXComponent $bladeXComponent): string
		0 ignored issues – show Duplication introduced 2018-10-07 09:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$prefix = $this->bladeX->getPrefix();
40
41		$pattern = "/<\s{$prefix}{$bladeXComponent->name}\s(?<attributes>.)\s\/>/";
42
43		return preg_replace_callback($pattern, function (array $matches) use ($bladeXComponent) {
44		$attributes = $this->getAttributesFromAttributeString($matches['attributes']);
45
46		return $this->componentString($bladeXComponent, $attributes);
47		}, $viewContents);
48		}
49
50	View Code Duplication	protected function parseOpeningTags(string $viewContents, BladeXComponent $bladeXComponent): string
		0 ignored issues – show Duplication introduced 2018-10-07 09:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		$prefix = $this->bladeX->getPrefix();
53
54		$pattern = "/<\s{$prefix}{$bladeXComponent->name}(?<attributes>(?:\s+[\w\-:]+=(?:\\\"[^\\\"]+\\\"\|\'[^\']+\'\|[^\'\\\"=<>]+))\s*)(?<![\/=\-])>/";
55
56		return preg_replace_callback($pattern, function (array $matches) use ($bladeXComponent) {
57		$attributes = $this->getAttributesFromAttributeString($matches['attributes']);
58
59		return $this->componentStartString($bladeXComponent, $attributes);
60		}, $viewContents);
61		}
62
63		protected function parseClosingTags(string $viewContents, BladeXComponent $bladeXComponent): string
64		{
65		$prefix = $this->bladeX->getPrefix();
66
67		$pattern = "/<\/\s{$prefix}{$bladeXComponent->name}[^>]>/";
68
69		return preg_replace($pattern, $this->componentEndString($bladeXComponent), $viewContents);
70		}
71
72		protected function componentString(BladeXComponent $bladeXComponent, array $attributes = []): string
73		{
74		return $this->componentStartString($bladeXComponent, $attributes).$this->componentEndString($bladeXComponent);
75		}
76
77		protected function componentStartString(BladeXComponent $bladeXComponent, array $attributes = []): string
78		{
79		$attributesString = $this->attributesToString($attributes);
80
81		$componentAttributeString = "[{$attributesString}]";
82
83		if ($bladeXComponent->bladeViewName === 'bladex::context') {
84		return "@php(app(Spatie\BladeX\ContextStack::class)->push({$componentAttributeString}))";
85		}
86
87		if ($bladeXComponent->viewModel) {
88		$componentAttributeString = "
89		array_merge(
90		app(Spatie\BladeX\ContextStack::class)->read(),
91		{$componentAttributeString},
92		app(
93		'{$bladeXComponent->viewModel}',
94		array_merge(
95		app(Spatie\BladeX\ContextStack::class)->read(),
96		{$componentAttributeString}
97		)
98		)->toArray()
99		)";
100		}
101
102		return " @component(
103		'{$bladeXComponent->bladeViewName}',
104		array_merge(app(Spatie\BladeX\ContextStack::class)->read(), {$componentAttributeString})) ";
105		}
106
107		protected function componentEndString(BladeXComponent $bladeXComponent): string
108		{
109		if ($bladeXComponent->bladeViewName === 'bladex::context') {
110		return "@php(app(Spatie\BladeX\ContextStack::class)->pop())";
111		}
112
113		return ' @endcomponent ';
114		}
115
116		protected function getAttributesFromAttributeString(string $attributeString): array
117		{
118		$attributeString = $this->parseBindAttributes($attributeString);
119
120		$pattern = '/(?<attribute>[\w:-]+)(=(?<value>(\"[^\"]+\"\|\\\'[^\\\']+\\\'\|[^\s>]+)))?/';
121
122		if (! preg_match_all($pattern, $attributeString, $matches, PREG_SET_ORDER)) {
123		return [];
124		}
125
126		return collect($matches)->mapWithKeys(function ($match) {
127		$attribute = camel_case($match['attribute']);
128		$value = $match['value'] ?? null;
129
130		if (is_null($value)) {
131		$value = 'true';
132		$attribute = str_start($attribute, 'bind:');
133		}
134
135		$value = $this->stripQuotes($value);
136
137		if (! starts_with($attribute, 'bind:')) {
138		$value = str_replace("'", "\\'", $value);
139		$value = "'{$value}'";
140		}
141
142		if (starts_with($attribute, 'bind:')) {
143		$attribute = str_after($attribute, 'bind:');
144		}
145
146		return [$attribute => $value];
147		})->toArray();
148		}
149
150		protected function parseSlots(string $viewContents): string
151		{
152		$openingPattern = '/<\sslot\s+name=(?<name>(\"[^\"]+\"\|\\\'[^\\\']+\\\'\|[^\s>]+))\s>/';
153		$viewContents = preg_replace_callback($openingPattern, function ($matches) {
154		$name = $this->stripQuotes($matches['name']);
155
156		return " @slot('{$name}') ";
157		}, $viewContents);
158
159		$closingPattern = '/<\/\sslot[^>]>/';
160		$viewContents = preg_replace($closingPattern, ' @endslot', $viewContents);
161
162		return $viewContents;
163		}
164
165		protected function isOpeningHtmlTag(string $tagName, string $html): bool
166		{
167		return ! ends_with($html, ["</{$tagName}>", '/>']);
168		}
169
170		protected function parseBindAttributes(string $attributeString): string
171		{
172		return preg_replace("/\s*:([\w-]+)=/m", ' bind:$1=', $attributeString);
173		}
174
175		protected function attributesToString(array $attributes): string
176		{
177		return collect($attributes)
178		->map(function (string $value, string $attribute) {
179		return "'{$attribute}' => {$value}";
180		})
181		->implode(',');
182		}
183
184		protected function stripQuotes(string $string): string
185		{
186		if (starts_with($string, ['"', '\''])) {
187		return substr($string, 1, -1);
188		}
189
190		return $string;
191		}
192		}
193

spatie / laravel-blade-x

Push — master ( d0a237...a1b9c8 )

src/BladeXCompiler.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like