BladeXCompiler::getComponentAttributes() - Code Metrics - Inspection of "refactor" - spatie/laravel-blade-x - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5837bb...ec7182 )

by Freek

created 2018-09-28 20:54 UTC

BladeXCompiler::getComponentAttributes() A

↳ Parent: BladeXCompiler

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace Spatie\BladeX;

use SimpleXMLElement;

class BladeXCompiler
{
    /** @var \Spatie\BladeX\BladeX */
    protected $bladeX;

    public function __construct(BladeX $bladeX)
    {
        return $this->bladeX = $bladeX;

    }

    public function compile(string $viewContents): string
    {
        foreach ($this->bladeX->getRegisteredComponents() as $componentName => $viewPath) {
            $pattern = '/<\s*' . $componentName . '[^>]*>((.|\n)*?)<\s*\/\s*' . $componentName . '>/m';

            $viewContents = preg_replace_callback($pattern, function (array $regexResult) use ($viewPath) {
                [$componentHtml, $componentInnerHtml] = $regexResult;
function someFunction() {
    $x = 5;
    echo $x;
}

                $pattern = '/<\s*slot[^>]*name=[\'"](.*)[\'"][^>]*>((.|\n)*?)<\s*\/\s*slot>/m';

                $componentInnerHtml = preg_replace_callback($pattern, function ($result) {
                    [$slot, $name, $contents] = $result;


                    return "@slot('{$name}'){$contents}@endslot";
                }, $componentInnerHtml);
function someFunction() {
    $x = 5;
    echo $x;
}

                return "@component('{$viewPath}', [{$this->getComponentAttributes($componentHtml)}])" . $componentInnerHtml . '@endcomponent';
            }, $viewContents);
        }

        return $viewContents;
    }

    protected function getComponentAttributes(string $componentHtml): string
    {
        $componentXml = new SimpleXMLElement($componentHtml);

        return collect($componentXml->attributes())
            ->map(function ($value, $attribute) {
                $value = str_replace("'", "\\'", $value);

                return "'{$attribute}' => '{$value}',";
            })->implode('');
    }
}


1			<?php
2
3			namespace Spatie\BladeX;
4
5			use SimpleXMLElement;
6
7			class BladeXCompiler
8			{
9			/** @var \Spatie\BladeX\BladeX */
10			protected $bladeX;
11
12			public function __construct(BladeX $bladeX)
13			{
14			return $this->bladeX = $bladeX;
			0 ignored issues – show Bug introduced 2018-09-28 20:26 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
15			}
16
17			public function compile(string $viewContents): string
18			{
19			foreach ($this->bladeX->getRegisteredComponents() as $componentName => $viewPath) {
20			$pattern = '/<\s' . $componentName . '[^>]>((.\|\n)?)<\s\/\s*' . $componentName . '>/m';
21
22			$viewContents = preg_replace_callback($pattern, function (array $regexResult) use ($viewPath) {
23			[$componentHtml, $componentInnerHtml] = $regexResult;
			0 ignored issues – show Bug introduced 2018-09-28 20:55 UTC by Report Bug Copy Issue Report The variable `$componentHtml` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-09-28 20:55 UTC by Report Bug Copy Issue Report The variable `$componentInnerHtml` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
24
25			$pattern = '/<\sslot[^>]name=[\'"](.)[\'"][^>]>((.\|\n)?)<\s\/\s*slot>/m';
26
27			$componentInnerHtml = preg_replace_callback($pattern, function ($result) {
28			[$slot, $name, $contents] = $result;
			0 ignored issues – show Bug introduced 2018-09-28 20:15 UTC by Report Bug Copy Issue Report The variable `$slot` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-09-28 20:15 UTC by Report Bug Copy Issue Report The variable `$name` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-09-28 20:15 UTC by Report Bug Copy Issue Report The variable `$contents` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
29
30			return "@slot('{$name}'){$contents}@endslot";
31			}, $componentInnerHtml);
			0 ignored issues – show Bug introduced 2018-09-28 20:55 UTC by Report Bug Copy Issue Report The variable `$componentInnerHtml` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
32
33			return "@component('{$viewPath}', [{$this->getComponentAttributes($componentHtml)}])" . $componentInnerHtml . '@endcomponent';
34			}, $viewContents);
35			}
36
37			return $viewContents;
38			}
39
40			protected function getComponentAttributes(string $componentHtml): string
41			{
42			$componentXml = new SimpleXMLElement($componentHtml);
43
44			return collect($componentXml->attributes())
45			->map(function ($value, $attribute) {
46			$value = str_replace("'", "\\'", $value);
47
48			return "'{$attribute}' => '{$value}',";
49			})->implode('');
50			}
51			}
52

spatie / laravel-blade-x

Push — master ( 5837bb...ec7182 )

BladeXCompiler::getComponentAttributes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like