CleanupCommand::handle() - Code Metrics - Inspection of "add no-notifications flag for backup:run command,..." - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 198554...54d251 )

by Freek

created 2017-06-15 17:35 UTC

CleanupCommand::handle() B

↳ Parent: CleanupCommand

Complexity

Conditions	3
Paths	13

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	14
nc	13
nop	0
dl	0
loc	26
rs	8.8571
c	0
b	0
f	0

<?php

namespace Spatie\Backup\Commands;

use Exception;
use Spatie\Backup\Events\CleanupHasFailed;
use Spatie\Backup\Tasks\Cleanup\CleanupJob;
use Spatie\Backup\BackupDestination\BackupDestinationFactory;

class CleanupCommand extends BaseCommand
{
    /** @var string */
    protected $signature = 'backup:clean {--disable-notifications}';

    /** @var string */
    protected $description = 'Remove all backups older than specified number of days in config.';

    public function handle()
    {
        consoleOutput()->comment('Starting cleanup...');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $disableNotifications = $this->option('disable-notifications');

        try {
            $config = config('laravel-backup');

            $backupDestinations = BackupDestinationFactory::createFromArray($config['backup']);

            $strategy = app($config['cleanup']['strategy']);

            $cleanupJob = new CleanupJob($backupDestinations, $strategy, $disableNotifications);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $cleanupJob->run();

            consoleOutput()->comment('Cleanup completed!');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } catch (Exception $exception) {
            if (! $disableNotifications) {
                event(new CleanupHasFailed($exception));
            }

            return -1;
        }
    }
}


1			<?php
2
3			namespace Spatie\Backup\Commands;
4
5			use Exception;
6			use Spatie\Backup\Events\CleanupHasFailed;
7			use Spatie\Backup\Tasks\Cleanup\CleanupJob;
8			use Spatie\Backup\BackupDestination\BackupDestinationFactory;
9
10			class CleanupCommand extends BaseCommand
11			{
12			/** @var string */
13			protected $signature = 'backup:clean {--disable-notifications}';
14
15			/** @var string */
16			protected $description = 'Remove all backups older than specified number of days in config.';
17
18			public function handle()
19			{
20			consoleOutput()->comment('Starting cleanup...');
			0 ignored issues – show Documentation Bug introduced 2016-03-07 17:59 UTC by Report Bug Copy Issue Report The method `comment` does not exist on `object<Spatie\Backup\Helpers\ConsoleOutput>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
21
22			$disableNotifications = $this->option('disable-notifications');
23
24			try {
25			$config = config('laravel-backup');
26
27			$backupDestinations = BackupDestinationFactory::createFromArray($config['backup']);
28
29			$strategy = app($config['cleanup']['strategy']);
30
31			$cleanupJob = new CleanupJob($backupDestinations, $strategy, $disableNotifications);
			0 ignored issues – show Documentation introduced 2017-06-14 05:59 UTC by Report Bug Copy Issue Report `$disableNotifications` is of type `string\|array`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32
33			$cleanupJob->run();
34
35			consoleOutput()->comment('Cleanup completed!');
			0 ignored issues – show Documentation Bug introduced 2016-03-07 17:59 UTC by Report Bug Copy Issue Report The method `comment` does not exist on `object<Spatie\Backup\Helpers\ConsoleOutput>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
36			} catch (Exception $exception) {
37			if (! $disableNotifications) {
38			event(new CleanupHasFailed($exception));
39			}
40
41			return -1;
42			}
43			}
44			}
45

spatie / laravel-backup

Push — master ( 198554...54d251 )

CleanupCommand::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like