Pushover::send() - Code Metrics - Inspection of "Added the ability to change the pushover notificat..." - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#104)

by Tyler

created 2016-03-29 19:28 UTC

Pushover::send() A

↳ Parent: Pushover

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	16
rs	9.4285
cc	1
eloc	12
nc	1
nop	0

<?php

namespace Spatie\Backup\Notifications\Senders;

use Illuminate\Contracts\Config\Repository;
use Spatie\Backup\Notifications\BaseSender;

class Pushover extends BaseSender
{
    /** @var array */
    protected $config;

    /**
     * @param Repository $config
     */
    public function __construct(Repository $config)
    {
        $this->config = $config->get('laravel-backup.notifications.pushover');

    }

    /**
     * Sends the message to the Pushover API
     * @return void
     */
    public function send()
    {
        curl_setopt_array($ch = curl_init(), [
            CURLOPT_URL => 'https://api.pushover.net/1/messages.json',
            CURLOPT_POSTFIELDS => [
                'token' => $this->config['token'],
                'user' => $this->config['user'],
                'title' => $this->subject,
                'message' => $this->message,
                'sound' => $this->getSound(),
            ],
            CURLOPT_SAFE_UPLOAD => true,
        ]);
        curl_exec($ch);
        curl_close($ch);
    }

    /**
     * Returns the proper sound for the notification type according to the config file
     * @return string The sound string to use
     */
    private function getSound()
    {
        $sounds = isset($this->config['sounds']) ? $this->config['sounds'] : ['success' => 'pushover', 'error' => 'siren'];

        $sound = $this->type === static::TYPE_SUCCESS ? $sounds['success'] : $sounds['error'];

        return $sound;
    }

}


1			<?php
2
3			namespace Spatie\Backup\Notifications\Senders;
4
5			use Illuminate\Contracts\Config\Repository;
6			use Spatie\Backup\Notifications\BaseSender;
7
8			class Pushover extends BaseSender
9			{
10			/** @var array */
11			protected $config;
12
13			/**
14			* @param Repository $config
15			*/
16			public function __construct(Repository $config)
17			{
18			$this->config = $config->get('laravel-backup.notifications.pushover');
			0 ignored issues – show Documentation Bug introduced 2016-03-16 14:32 UTC by Report Bug Copy Issue Report It seems like `$config->get('laravel-ba...otifications.pushover')` of type `*` is incompatible with the declared type `array` of property `$config`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
19			}
20
21			/**
22			* Sends the message to the Pushover API
23			* @return void
24			*/
25			public function send()
26			{
27			curl_setopt_array($ch = curl_init(), [
28			CURLOPT_URL => 'https://api.pushover.net/1/messages.json',
29			CURLOPT_POSTFIELDS => [
30			'token' => $this->config['token'],
31			'user' => $this->config['user'],
32			'title' => $this->subject,
33			'message' => $this->message,
34			'sound' => $this->getSound(),
35			],
36			CURLOPT_SAFE_UPLOAD => true,
37			]);
38			curl_exec($ch);
39			curl_close($ch);
40			}
41
42			/**
43			* Returns the proper sound for the notification type according to the config file
44			* @return string The sound string to use
45			*/
46			private function getSound()
47			{
48			$sounds = isset($this->config['sounds']) ? $this->config['sounds'] : ['success' => 'pushover', 'error' => 'siren'];
49
50			$sound = $this->type === static::TYPE_SUCCESS ? $sounds['success'] : $sounds['error'];
51
52			return $sound;
53			}
54
55			}
56

spatie / laravel-backup

Pull Request — master (#104)

Pushover::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like