Backup::disk() - Code Metrics - Inspection of "Add disk getter function on Backup (#974)" - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3f3235...f2098d )

by Freek

created 2019-10-08 12:45 UTC

Backup::disk() A

↳ Parent: Backup

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Spatie\Backup\BackupDestination;

use Carbon\Carbon;
use Illuminate\Contracts\Filesystem\Filesystem;

class Backup
{
    /** @var \Illuminate\Contracts\Filesystem\Filesystem */
    protected $disk;

    /** @var string */
    protected $path;

    /** @var bool */
    protected $exists;

    /** @var Carbon */
    protected $date;

    /** @var int */
    protected $size;

    public function __construct(Filesystem $disk, string $path)
    {
        $this->disk = $disk;

        $this->path = $path;
    }

    public function disk(): Filesystem
    {
        return $this->disk;
    }

    public function path(): string
    {
        return $this->path;
    }

    public function exists(): bool
    {
        if ($this->exists === null) {
            $this->exists = $this->disk->exists($this->path);
        }

        return $this->exists;
    }

    public function date(): Carbon
    {
        if ($this->date === null) {
            $this->date = Carbon::createFromTimestamp($this->disk->lastModified($this->path));
        }

        return $this->date;
    }

    /**
     * Get the size in bytes.
     */
    public function size(): int
    {
        if ($this->size === null) {
            if (! $this->exists()) {
                return 0;
            }

            $this->size = $this->disk->size($this->path);
        }

        return $this->size;
    }

    public function stream()
    {
        return $this->disk->readStream($this->path);
    }

    public function delete()
    {
        $this->exists = null;

        $this->disk->delete($this->path);

        consoleOutput()->info("Deleted backup `{$this->path}`.");
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}


1			<?php
2
3			namespace Spatie\Backup\BackupDestination;
4
5			use Carbon\Carbon;
6			use Illuminate\Contracts\Filesystem\Filesystem;
7
8			class Backup
9			{
10			/** @var \Illuminate\Contracts\Filesystem\Filesystem */
11			protected $disk;
12
13			/** @var string */
14			protected $path;
15
16			/** @var bool */
17			protected $exists;
18
19			/** @var Carbon */
20			protected $date;
21
22			/** @var int */
23			protected $size;
24
25			public function __construct(Filesystem $disk, string $path)
26			{
27			$this->disk = $disk;
28
29			$this->path = $path;
30			}
31
32			public function disk(): Filesystem
33			{
34			return $this->disk;
35			}
36
37			public function path(): string
38			{
39			return $this->path;
40			}
41
42			public function exists(): bool
43			{
44			if ($this->exists === null) {
45			$this->exists = $this->disk->exists($this->path);
46			}
47
48			return $this->exists;
49			}
50
51			public function date(): Carbon
52			{
53			if ($this->date === null) {
54			$this->date = Carbon::createFromTimestamp($this->disk->lastModified($this->path));
55			}
56
57			return $this->date;
58			}
59
60			/**
61			* Get the size in bytes.
62			*/
63			public function size(): int
64			{
65			if ($this->size === null) {
66			if (! $this->exists()) {
67			return 0;
68			}
69
70			$this->size = $this->disk->size($this->path);
71			}
72
73			return $this->size;
74			}
75
76			public function stream()
77			{
78			return $this->disk->readStream($this->path);
79			}
80
81			public function delete()
82			{
83			$this->exists = null;
84
85			$this->disk->delete($this->path);
86
87			consoleOutput()->info("Deleted backup `{$this->path}`.");
			0 ignored issues – show Documentation Bug introduced 2016-09-16 15:34 UTC by Report Bug Copy Issue Report The method `info` does not exist on `object<Spatie\Backup\Helpers\ConsoleOutput>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
88			}
89			}
90

spatie / laravel-backup

Push — master ( 3f3235...f2098d )

Backup::disk() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like