PgSQLDatabase::dump() - Code Metrics - Inspection of "fix syntax error" - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02927c...6d0ead )

by Freek

created 2016-02-25 20:24 UTC

PgSQLDatabase::dump() A

↳ Parent: PgSQLDatabase

Complexity

Conditions	2
Paths	1

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
rs	9.4285
cc	2
eloc	12
nc	1
nop	1

<?php

namespace Spatie\Backup\BackupHandlers\Database\Databases;

use Spatie\Backup\Console;

class PgSQLDatabase implements DatabaseInterface
{
    protected $console;
    protected $database;
    protected $schema;
    protected $username;
    protected $password;
    protected $host;
    protected $port;

    /**
     * @param Console $console
     * @param $database
     * @param string $schema
     * @param string $username
     * @param $password
     * @param string string $host
     * @param int $port
     */
    public function __construct(Console $console, $database, $schema, $username, $password, $host, $port)

    {
        $this->console = $console;
        $this->database = $database;
        $this->schema = $schema;
        $this->username = $username;
        $this->password = $password;
        $this->host = $host;
        $this->port = $port;
    }

    /**
     * Create a database dump.
     *
     * @param $destinationFile
     *
     * @return bool
     */
    public function dump($destinationFile)
    {
        $command = sprintf('export PGHOST && %spg_dump ' . (!$this->useCopy() ? '--inserts' : '') . ' --schema=%s %s > %s',
            $this->getDumpCommandPath(),
            escapeshellarg($this->schema),
            escapeshellarg($this->database),
            escapeshellarg($destinationFile)
        );

        $env = [
            'PGHOST' => $this->host,
            'PGUSER' => $this->username,
            'PGPASSWORD' => $this->password,
            'PGPORT' => $this->port,
        ];

        return $this->console->run($command, config('laravel-backup.pgsql.timeoutInSeconds'), $env);

    }

    /**
     * Return the file extension of a dump file (sql, ...).
     *
     * @return string
     */
    public function getFileExtension()
    {
        return 'sql';
    }

    /**
     * Get the path to the pgsql_dump.
     *
     * @return string
     */
    protected function getDumpCommandPath()
    {
        $path = config('laravel-backup.pgsql.dump_command_path');

        if ($path != '') {
            $path = str_finish($path, '/');
        }

        return $path;

        return $path;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * Determine if COPY should be used instead of INSERT.
     */
    protected function useCopy()
    {
        return config('laravel-backup.pgsql.use_copy');
    }
}


1		<?php
2
3		namespace Spatie\Backup\BackupHandlers\Database\Databases;
4
5		use Spatie\Backup\Console;
6
7		class PgSQLDatabase implements DatabaseInterface
8		{
9		protected $console;
10		protected $database;
11		protected $schema;
12		protected $username;
13		protected $password;
14		protected $host;
15		protected $port;
16
17		/**
18		* @param Console $console
19		* @param $database
20		* @param string $schema
21		* @param string $username
22		* @param $password
23		* @param string string $host
24		* @param int $port
25		*/
26	View Code Duplication	public function __construct(Console $console, $database, $schema, $username, $password, $host, $port)
		0 ignored issues – show Duplication introduced 2016-01-01 23:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$this->console = $console;
29		$this->database = $database;
30		$this->schema = $schema;
31		$this->username = $username;
32		$this->password = $password;
33		$this->host = $host;
34		$this->port = $port;
35		}
36
37		/**
38		* Create a database dump.
39		*
40		* @param $destinationFile
41		*
42		* @return bool
43		*/
44		public function dump($destinationFile)
45		{
46		$command = sprintf('export PGHOST && %spg_dump ' . (!$this->useCopy() ? '--inserts' : '') . ' --schema=%s %s > %s',
47		$this->getDumpCommandPath(),
48		escapeshellarg($this->schema),
49		escapeshellarg($this->database),
50		escapeshellarg($destinationFile)
51		);
52
53		$env = [
54		'PGHOST' => $this->host,
55		'PGUSER' => $this->username,
56		'PGPASSWORD' => $this->password,
57		'PGPORT' => $this->port,
58		];
59
60		return $this->console->run($command, config('laravel-backup.pgsql.timeoutInSeconds'), $env);
		0 ignored issues – show Bug Compatibility introduced 2016-02-24 10:52 UTC by Report Bug Copy Issue Report The expression `$this->console->run($com...eoutInSeconds'), $env);` of type `boolean\|string` adds the type `string` to the return on line 60 which is incompatible with the return type declared by the interface `Spatie\Backup\BackupHand...DatabaseInterface::dump` of type `boolean`. Loading history...
61		}
62
63		/**
64		* Return the file extension of a dump file (sql, ...).
65		*
66		* @return string
67		*/
68		public function getFileExtension()
69		{
70		return 'sql';
71		}
72
73		/**
74		* Get the path to the pgsql_dump.
75		*
76		* @return string
77		*/
78		protected function getDumpCommandPath()
79		{
80		$path = config('laravel-backup.pgsql.dump_command_path');
81
82		if ($path != '') {
83		$path = str_finish($path, '/');
84		}
85
86		return $path;
87
88		return $path;
		0 ignored issues – show Unused Code introduced 2016-02-25 20:29 UTC by Report Bug Copy Issue Report `return $path;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
89		}
90
91		/**
92		* Determine if COPY should be used instead of INSERT.
93		*/
94		protected function useCopy()
95		{
96		return config('laravel-backup.pgsql.use_copy');
97		}
98		}
99

spatie / laravel-backup

Push — master ( 02927c...6d0ead )

PgSQLDatabase::dump() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like