BackupJobFactory - Code Metrics - Inspection of "use port configuration" - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 179317...aa300d )

by Freek

created 2016-04-13 08:49 UTC

BackupJobFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	81
Duplicated Lines	37.04 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	9
Bugs	0	Features	5

Metric	Value
wmc	12
c	9
b	0
f	5
lcom	0
cbo	6
dl	30
loc	81
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	createFromArray()	0	9	1
A	getFileSelection()	0	5	1
C	getDbDumpers()	30	47	10

How to fix Duplicated Code

<?php

namespace Spatie\Backup\Tasks\Backup;

use Spatie\Backup\BackupDestination\BackupDestinationFactory;
use Spatie\Backup\Exceptions\InvalidConfiguration;
use Spatie\DbDumper\Databases\MySql;
use Spatie\DbDumper\Databases\PostgreSql;

class BackupJobFactory
{
    /**
     * @param array $config
     *
     * @return \Spatie\Backup\Tasks\Backup\BackupJob
     */
    public static function createFromArray(array $config)
    {
        $backupJob = (new BackupJob())
            ->setFileSelection(static::getFileSelection($config['backup']['source']['files']))
            ->setDbDumpers(static::getDbDumpers($config['backup']['source']['databases']))
            ->setBackupDestinations(BackupDestinationFactory::createFromArray($config['backup']));

        return $backupJob;
    }

    /**
     * @param array $sourceFiles
     *
     * @return \Spatie\Backup\Tasks\Backup\FileSelection
     */
    protected static function getFileSelection(array $sourceFiles)
    {
        return (new FileSelection($sourceFiles['include']))
            ->excludeFilesFrom($sourceFiles['exclude']);
    }

    /**
     * @param array $dbConnectionNames
     *
     * @return array
     */
    protected static function getDbDumpers(array $dbConnectionNames)
    {
        $dbDumpers = array_map(function ($dbConnectionName) {

            $dbConfig = config("database.connections.{$dbConnectionName}");

            switch ($dbConfig['driver']) {
                case 'mysql':

                    $dbDumper =  MySql::create()
                        ->setHost($dbConfig['host'])
                        ->setDbName($dbConfig['database'])
                        ->setUserName($dbConfig['username'])
                        ->setPassword($dbConfig['password'])
                        ->setDumpBinaryPath(isset($dbConfig['dump_command_path']) ? $dbConfig['dump_command_path'] : '')
                        ->setTimeout(isset($dbConfig['dump_command_timeout']) ? $dbConfig['dump_command_timeout'] : null);

                    if (isset($dbConfig['port'])) {
                        $dbDumper->setPort($dbConfig['port']);
                    }

                    return $dbDumper;
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

                case 'pgsql':

                    $dbDumper =  PostgreSql::create()
                        ->setHost($dbConfig['host'])
                        ->setDbName($dbConfig['database'])
                        ->setUserName($dbConfig['username'])
                        ->setPassword($dbConfig['password'])
                        ->setDumpBinaryPath(isset($dbConfig['dump_command_path']) ? $dbConfig['dump_command_path'] : '')
                        ->setTimeout(isset($dbConfig['dump_command_timeout']) ? $dbConfig['dump_command_timeout'] : null);

                    if (isset($dbConfig['dump_use_inserts']) && $dbConfig['dump_use_inserts'] == true) {
                        $dbDumper->useInserts();
                    }

                    return $dbDumper;
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

                default :
switch ($expr) {
    default : //wrong
        doSomething();
        break;
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
                    throw InvalidConfiguration::cannotUseUnsupportedDriver($dbConnectionName, $dbConfig['driver']);
                    break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            }
        }, $dbConnectionNames);

        return $dbDumpers;
    }
}


1		<?php
2
3		namespace Spatie\Backup\Tasks\Backup;
4
5		use Spatie\Backup\BackupDestination\BackupDestinationFactory;
6		use Spatie\Backup\Exceptions\InvalidConfiguration;
7		use Spatie\DbDumper\Databases\MySql;
8		use Spatie\DbDumper\Databases\PostgreSql;
9
10		class BackupJobFactory
11		{
12		/**
13		* @param array $config
14		*
15		* @return \Spatie\Backup\Tasks\Backup\BackupJob
16		*/
17		public static function createFromArray(array $config)
18		{
19		$backupJob = (new BackupJob())
20		->setFileSelection(static::getFileSelection($config['backup']['source']['files']))
21		->setDbDumpers(static::getDbDumpers($config['backup']['source']['databases']))
22		->setBackupDestinations(BackupDestinationFactory::createFromArray($config['backup']));
23
24		return $backupJob;
25		}
26
27		/**
28		* @param array $sourceFiles
29		*
30		* @return \Spatie\Backup\Tasks\Backup\FileSelection
31		*/
32		protected static function getFileSelection(array $sourceFiles)
33		{
34		return (new FileSelection($sourceFiles['include']))
35		->excludeFilesFrom($sourceFiles['exclude']);
36		}
37
38		/**
39		* @param array $dbConnectionNames
40		*
41		* @return array
42		*/
43		protected static function getDbDumpers(array $dbConnectionNames)
44		{
45		$dbDumpers = array_map(function ($dbConnectionName) {
46
47		$dbConfig = config("database.connections.{$dbConnectionName}");
48
49		switch ($dbConfig['driver']) {
50	View Code Duplication	case 'mysql':
		0 ignored issues – show Duplication introduced 2016-03-13 07:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		$dbDumper = MySql::create()
52		->setHost($dbConfig['host'])
53		->setDbName($dbConfig['database'])
54		->setUserName($dbConfig['username'])
55		->setPassword($dbConfig['password'])
56		->setDumpBinaryPath(isset($dbConfig['dump_command_path']) ? $dbConfig['dump_command_path'] : '')
57		->setTimeout(isset($dbConfig['dump_command_timeout']) ? $dbConfig['dump_command_timeout'] : null);
58
59		if (isset($dbConfig['port'])) {
60		$dbDumper->setPort($dbConfig['port']);
61		}
62
63		return $dbDumper;
64		break;
		0 ignored issues – show Unused Code introduced 2016-03-13 07:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
65
66	View Code Duplication	case 'pgsql':
		0 ignored issues – show Duplication introduced 2016-03-13 07:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		$dbDumper = PostgreSql::create()
68		->setHost($dbConfig['host'])
69		->setDbName($dbConfig['database'])
70		->setUserName($dbConfig['username'])
71		->setPassword($dbConfig['password'])
72		->setDumpBinaryPath(isset($dbConfig['dump_command_path']) ? $dbConfig['dump_command_path'] : '')
73		->setTimeout(isset($dbConfig['dump_command_timeout']) ? $dbConfig['dump_command_timeout'] : null);
74
75		if (isset($dbConfig['dump_use_inserts']) && $dbConfig['dump_use_inserts'] == true) {
76		$dbDumper->useInserts();
77		}
78
79		return $dbDumper;
80		break;
		0 ignored issues – show Unused Code introduced 2016-03-13 07:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
81
82		default :
		0 ignored issues – show Coding Style introduced 2016-03-16 14:24 UTC by Report Bug Copy Issue Report There must be no space before the colon in a DEFAULT statement As per the PSR-2 coding standard, there must not be a space in front of the colon in the default statement. switch ($expr) { default : //wrong doSomething(); break; } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
83		throw InvalidConfiguration::cannotUseUnsupportedDriver($dbConnectionName, $dbConfig['driver']);
84		break;
		0 ignored issues – show Unused Code introduced 2016-03-13 07:59 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
85		}
86		}, $dbConnectionNames);
87
88		return $dbDumpers;
89		}
90		}
91

spatie / laravel-backup

Push — master ( 179317...aa300d )

BackupJobFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like