PgSQLDatabase - Code Metrics - Inspection of "Merge pull request #60 from Jamesking56/feature/po..." - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 410526...963b63 )

by Freek

created 2016-01-04 18:09 UTC

PgSQLDatabase A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	85
Duplicated Lines	11.76 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	6
c	1
b	0
f	0
lcom	1
cbo	1
dl	10
loc	85
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	10	10	1
A	dump()	0	18	2
A	getFileExtension()	0	4	1
A	getDumpCommandPath()	0	4	1
A	useCopy()	0	4	1

How to fix Duplicated Code

<?php

namespace Spatie\Backup\BackupHandlers\Database\Databases;

use Spatie\Backup\Console;

class PgSQLDatabase implements DatabaseInterface
{
    protected $console;
    protected $database;
    protected $schema;
    protected $username;
    protected $password;
    protected $host;
    protected $port;

    /**
     * @param Console $console
     * @param $database
     * @param string $schema
     * @param $username
     * @param $password
     * @param string $host
     * @param int $port
     * @param string $socket
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(Console $console, $database, $schema, $username, $password, $host, $port)

    {
        $this->console = $console;
        $this->database = $database;
        $this->schema = $schema;
        $this->username = $username;
        $this->password = $password;
        $this->host = $host;
        $this->port = $port;
    }

    /**
     * Create a database dump.
     *
     * @param $destinationFile
     *
     * @return bool
     */
    public function dump($destinationFile)
    {
        $command = sprintf('export PGHOST && %spg_dump '.(!$this->useCopy() ? '--inserts' : '').' --schema=%s %s > %s',
            $this->getDumpCommandPath(),
            escapeshellarg($this->schema),
            escapeshellarg($this->database),
            escapeshellarg($destinationFile)
        );

        $env = [
            'PGHOST' => $this->host,
            'PGUSER' => $this->username,
            'PGPASSWORD' => $this->password,
            'PGPORT' => $this->port
        ];

        return $this->console->run($command, config('laravel-backup.pgsql.timeoutInSeconds'), $env);

    }

    /**
     * Return the file extension of a dump file (sql, ...).
     *
     * @return string
     */
    public function getFileExtension()
    {
        return 'sql';
    }

    /**
     * Get the path to the pgsql_dump.
     *
     * @return string
     */
    protected function getDumpCommandPath()
    {
        return config('laravel-backup.pgsql.dump_command_path');
    }

    /**
     * Determine if COPY should be used instead of INSERT.
     */
    protected function useCopy()
    {
        return config('laravel-backup.pgsql.use_copy');
    }
}

1		<?php
2
3		namespace Spatie\Backup\BackupHandlers\Database\Databases;
4
5		use Spatie\Backup\Console;
6
7		class PgSQLDatabase implements DatabaseInterface
8		{
9		protected $console;
10		protected $database;
11		protected $schema;
12		protected $username;
13		protected $password;
14		protected $host;
15		protected $port;
16
17		/**
18		* @param Console $console
19		* @param $database
20		* @param string $schema
21		* @param $username
22		* @param $password
23		* @param string $host
24		* @param int $port
25		* @param string $socket
		0 ignored issues – show Bug introduced 2016-01-01 23:24 UTC by Report Bug Copy Issue Report There is no parameter named `$socket`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
26		*/
27	View Code Duplication	public function __construct(Console $console, $database, $schema, $username, $password, $host, $port)
		0 ignored issues – show Duplication introduced 2016-01-01 23:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$this->console = $console;
30		$this->database = $database;
31		$this->schema = $schema;
32		$this->username = $username;
33		$this->password = $password;
34		$this->host = $host;
35		$this->port = $port;
36		}
37
38		/**
39		* Create a database dump.
40		*
41		* @param $destinationFile
42		*
43		* @return bool
44		*/
45		public function dump($destinationFile)
46		{
47		$command = sprintf('export PGHOST && %spg_dump '.(!$this->useCopy() ? '--inserts' : '').' --schema=%s %s > %s',
48		$this->getDumpCommandPath(),
49		escapeshellarg($this->schema),
50		escapeshellarg($this->database),
51		escapeshellarg($destinationFile)
52		);
53
54		$env = [
55		'PGHOST' => $this->host,
56		'PGUSER' => $this->username,
57		'PGPASSWORD' => $this->password,
58		'PGPORT' => $this->port
59		];
60
61		return $this->console->run($command, config('laravel-backup.pgsql.timeoutInSeconds'), $env);
		0 ignored issues – show Bug Compatibility introduced 2016-01-01 23:24 UTC by Report Bug Copy Issue Report The expression `$this->console->run($com...eoutInSeconds'), $env);` of type `boolean\|string` adds the type `string` to the return on line 61 which is incompatible with the return type declared by the interface `Spatie\Backup\BackupHand...DatabaseInterface::dump` of type `boolean`. Loading history...
62		}
63
64		/**
65		* Return the file extension of a dump file (sql, ...).
66		*
67		* @return string
68		*/
69		public function getFileExtension()
70		{
71		return 'sql';
72		}
73
74		/**
75		* Get the path to the pgsql_dump.
76		*
77		* @return string
78		*/
79		protected function getDumpCommandPath()
80		{
81		return config('laravel-backup.pgsql.dump_command_path');
82		}
83
84		/**
85		* Determine if COPY should be used instead of INSERT.
86		*/
87		protected function useCopy()
88		{
89		return config('laravel-backup.pgsql.use_copy');
90		}
91		}

spatie / laravel-backup

Push — master ( 410526...963b63 )

PgSQLDatabase A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like