BackupCommand::fire() - Code Metrics - Inspection of "fix tests" - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f62f21...f72c97 )

by Freek

created 2016-03-07 17:54 UTC

BackupCommand::fire() B

↳ Parent: Project

Complexity

Conditions	4
Paths	5

Size

Total Lines	32
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	10
Bugs	3	Features	3

Metric	Value
c	10
b	3
f	3
dl	0
loc	32
rs	8.5806
cc	4
eloc	16
nc	5
nop	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	BackupCommand::guardAgainstInvalidOptions()	0	6	3

<?php

namespace Spatie\Backup\Commands;

use Spatie\Backup\Events\BackupHasFailed;
use Spatie\Backup\Exceptions\InvalidCommand;
use Spatie\Backup\Tasks\Backup\BackupJobFactory;
use Exception;

class BackupCommand extends BaseCommand
{
    /**
     * @var string
     */
    protected $signature = 'backup:run {--only-db} {--only-files}';

    /**
     * @var string
     */
    protected $description = 'Run the backup.';

    public function handle()
    {
        consoleOutput()->comment('Starting backup.');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        try {
            $this->guardAgainstInvalidOptions();

            $backupJob = BackupJobFactory::createFromArray(config('laravel-backup'));

            if ($this->option('only-db')) {
                $backupJob->doNotBackupFilesystem();
            }

            if ($this->option('only-files')) {
                $backupJob->doNotBackupDatabases();
            }

            $backupJob->run();

            consoleOutput()->comment('Backup completed!');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } catch (Exception $exception) {
            event(new BackupHasFailed($exception));

            throw $exception;
        }
    }

    protected function guardAgainstInvalidOptions()
    {
        if ($this->option('only-db') && $this->option('only-files')) {
            throw InvalidCommand::create('Cannot use only-db and only-files together');
        }
    }
}


1			<?php
2
3			namespace Spatie\Backup\Commands;
4
5			use Spatie\Backup\Events\BackupHasFailed;
6			use Spatie\Backup\Exceptions\InvalidCommand;
7			use Spatie\Backup\Tasks\Backup\BackupJobFactory;
8			use Exception;
9
10			class BackupCommand extends BaseCommand
11			{
12			/**
13			* @var string
14			*/
15			protected $signature = 'backup:run {--only-db} {--only-files}';
16
17			/**
18			* @var string
19			*/
20			protected $description = 'Run the backup.';
21
22			public function handle()
23			{
24			consoleOutput()->comment('Starting backup.');
			0 ignored issues – show Documentation Bug introduced 2016-03-07 17:59 UTC by Report Bug Copy Issue Report The method `comment` does not exist on `object<Spatie\Backup\Helpers\ConsoleOutput>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
25
26			try {
27			$this->guardAgainstInvalidOptions();
28
29			$backupJob = BackupJobFactory::createFromArray(config('laravel-backup'));
30
31			if ($this->option('only-db')) {
32			$backupJob->doNotBackupFilesystem();
33			}
34
35			if ($this->option('only-files')) {
36			$backupJob->doNotBackupDatabases();
37			}
38
39			$backupJob->run();
40
41			consoleOutput()->comment('Backup completed!');
			0 ignored issues – show Documentation Bug introduced 2016-03-07 17:59 UTC by Report Bug Copy Issue Report The method `comment` does not exist on `object<Spatie\Backup\Helpers\ConsoleOutput>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
42			} catch (Exception $exception) {
43			event(new BackupHasFailed($exception));
44
45			throw $exception;
46			}
47			}
48
49			protected function guardAgainstInvalidOptions()
50			{
51			if ($this->option('only-db') && $this->option('only-files')) {
52			throw InvalidCommand::create('Cannot use only-db and only-files together');
53			}
54			}
55			}
56

spatie / laravel-backup

Push — master ( f62f21...f72c97 )

BackupCommand::fire() B

Complexity

Size

Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like