AnalyticsClientFactory::createForConfig() - Code Metrics - Inspection of "fix insights issue" - spatie/laravel-analytics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0b2f36...19d6a1 )

by Freek

created 2016-06-20 12:08 UTC

AnalyticsClientFactory::createForConfig() A

↳ Parent: AnalyticsClientFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	1
eloc	4
nc	1
nop	1

<?php

namespace Spatie\Analytics;

use Google_Client;
use Google_Service_Analytics;
use Illuminate\Contracts\Cache\Repository;

class AnalyticsClientFactory
{
    public static function createForConfig(array $analyticsConfig)
    {
        $authenticatedClient = self::createAuthenticatedGoogleClient($analyticsConfig);

        $googleService = new Google_Service_Analytics($authenticatedClient);

        return self::createAnalyticsClient($analyticsConfig, $googleService);
    }

    public static function createAuthenticatedGoogleClient(array $config): Google_Client
    {
        $client = new Google_Client();

        $credentials = $client->loadServiceAccountJson(
            $config['service_account_credentials_json'],
            'https://www.googleapis.com/auth/analytics.readonly'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $client->setAssertionCredentials($credentials);

        return $client;
    }

    protected static function createAnalyticsClient(array $analyticsConfig, Google_Service_Analytics $googleService): AnalyticsClient
    {
        $client = new AnalyticsClient($googleService, app(Repository::class));

        $client->setCacheLifeTimeInMinutes($analyticsConfig['cache_lifetime_in_minutes']);

        return $client;
    }
}


1			<?php
2
3			namespace Spatie\Analytics;
4
5			use Google_Client;
6			use Google_Service_Analytics;
7			use Illuminate\Contracts\Cache\Repository;
8
9			class AnalyticsClientFactory
10			{
11			public static function createForConfig(array $analyticsConfig)
12			{
13			$authenticatedClient = self::createAuthenticatedGoogleClient($analyticsConfig);
14
15			$googleService = new Google_Service_Analytics($authenticatedClient);
16
17			return self::createAnalyticsClient($analyticsConfig, $googleService);
18			}
19
20			public static function createAuthenticatedGoogleClient(array $config): Google_Client
21			{
22			$client = new Google_Client();
23
24			$credentials = $client->loadServiceAccountJson(
25			$config['service_account_credentials_json'],
26			'https://www.googleapis.com/auth/analytics.readonly'
			0 ignored issues – show Documentation introduced 2016-06-20 12:17 UTC by Report Bug Copy Issue Report `'https://www.googleapis....uth/analytics.readonly'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			);
28
29			$client->setAssertionCredentials($credentials);
30
31			return $client;
32			}
33
34			protected static function createAnalyticsClient(array $analyticsConfig, Google_Service_Analytics $googleService): AnalyticsClient
35			{
36			$client = new AnalyticsClient($googleService, app(Repository::class));
37
38			$client->setCacheLifeTimeInMinutes($analyticsConfig['cache_lifetime_in_minutes']);
39
40			return $client;
41			}
42			}
43

spatie / laravel-analytics

Push — master ( 0b2f36...19d6a1 )

AnalyticsClientFactory::createForConfig() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like