DetectsChanges::getChangedValues() - Code Metrics - Inspection of "wip" - spatie/laravel-activitylog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba36ea...c404ca )

by Freek

created 2016-06-24 16:26 UTC

DetectsChanges::getChangedValues() A

↳ Parent: DetectsChanges

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	10
nc	2
nop	0
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0

<?php

namespace Spatie\Activitylog\Traits;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Collection;

trait DetectsChanges
{
    protected $oldValues = [];

    protected $newValues = [];

    protected static function bootDetectsChanges()
    {
        collect(['updating', 'deleting'])->each(function ($eventName) {

            return static::$eventName(function (Model $model) {

                $model->oldValues = $model->fresh()->toArray();

                $model->newValues = $model->getDirty();

            });
        });
    }

    public function getChangedAttributeNames(): array
    {
        return array_keys(array_intersect_key($this->oldValues, $this->newValues));
    }

    public function getChangedValues(): Collection
    {

        if (!isset($this->logChangesOnAttributes)) {
            return collect();
        }

        return collect($this->getChangedAttributeNames())
            ->filter(function (string $attributeName) {
               return collect($this->logChangesOnAttributes)->contains($attributeName);
class MyClass { }

$x = new MyClass();
$x->foo = true;
            })
            ->map(function (string $changedAttributeName) {
                return [
                    'old' => $this->oldValues[$changedAttributeName],
                    'new' => $this->newValues[$changedAttributeName],
                ];
            });
    }
}


1			<?php
2
3			namespace Spatie\Activitylog\Traits;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Illuminate\Support\Collection;
7
8			trait DetectsChanges
9			{
10			protected $oldValues = [];
11
12			protected $newValues = [];
13
14			protected static function bootDetectsChanges()
15			{
16			collect(['updating', 'deleting'])->each(function ($eventName) {
17
18			return static::$eventName(function (Model $model) {
19
20			$model->oldValues = $model->fresh()->toArray();
21
22			$model->newValues = $model->getDirty();
23
24			});
25			});
26			}
27
28			public function getChangedAttributeNames(): array
29			{
30			return array_keys(array_intersect_key($this->oldValues, $this->newValues));
31			}
32
33			public function getChangedValues(): Collection
34			{
35
36			if (!isset($this->logChangesOnAttributes)) {
37			return collect();
38			}
39
40			return collect($this->getChangedAttributeNames())
41			->filter(function (string $attributeName) {
42			return collect($this->logChangesOnAttributes)->contains($attributeName);
			0 ignored issues – show Bug introduced 2016-06-24 16:28 UTC by Report Bug Copy Issue Report The property `logChangesOnAttributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
43			})
44			->map(function (string $changedAttributeName) {
45			return [
46			'old' => $this->oldValues[$changedAttributeName],
47			'new' => $this->newValues[$changedAttributeName],
48			];
49			});
50			}
51			}
52

spatie / laravel-activitylog

Push — master ( ba36ea...c404ca )

DetectsChanges::getChangedValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like