DetectsChanges::shouldlogUnguarded() - Code Metrics - Inspection of "refactor long conditional" - spatie/laravel-activitylog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 11b2e0...68eb6e )

by Freek

created 2018-10-17 22:30 UTC

DetectsChanges::shouldlogUnguarded() A

↳ Parent: DetectsChanges

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	4
nop	0
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0

<?php

namespace Spatie\Activitylog\Traits;

use Illuminate\Database\Eloquent\Model;
use Spatie\Activitylog\Exceptions\CouldNotLogChanges;

trait DetectsChanges
{
    protected $oldAttributes = [];

    protected static function bootDetectsChanges()
    {
        if (static::eventsToBeRecorded()->contains('updated')) {
            static::updating(function (Model $model) {

                //temporary hold the original attributes on the model
                //as we'll need these in the updating event
                $oldValues = $model->replicate()->setRawAttributes($model->getOriginal());

                $model->oldAttributes = static::logChanges($oldValues);

            });
        }
    }

    public function attributesToBeLogged(): array
    {
        $attributes = [];

        if (isset(static::$logFillable) && static::$logFillable) {
            $attributes = array_merge($attributes, $this->getFillable());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        if ($this->shouldlogUnguarded()) {
            $attributes = array_merge($attributes, array_diff(array_keys($this->getAttributes()), $this->getGuarded()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        if (isset(static::$logAttributes) && is_array(static::$logAttributes)) {
            $attributes = array_merge($attributes, array_diff(static::$logAttributes, ['*']));

            if (in_array('*', static::$logAttributes)) {
                $attributes = array_merge($attributes, array_keys($this->getAttributes()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }

        if (isset(static::$logAttributesToIgnore) && is_array(static::$logAttributesToIgnore)) {
            $attributes = array_diff($attributes, static::$logAttributesToIgnore);
        }

        return $attributes;
    }

    public function shouldlogOnlyDirty(): bool
    {
        if (! isset(static::$logOnlyDirty)) {
            return false;
        }

        return static::$logOnlyDirty;
    }

    public function shouldlogUnguarded(): bool
    {
        if (! isset(static::$logUnguarded)) {
            return false;
        }

        if (! static::$logUnguarded) {
            return false;
        }

        if (in_array('*', $this->getGuarded())) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return false;
        }

        return true;
    }

    public function attributeValuesToBeLogged(string $processingEvent): array
    {
        if (! count($this->attributesToBeLogged())) {
            return [];
        }

        $properties['attributes'] = static::logChanges(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $this->exists
class MyClass { }

$x = new MyClass();
$x->foo = true;
                ? $this->fresh() ?? $this
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                : $this
        );

        if (static::eventsToBeRecorded()->contains('updated') && $processingEvent == 'updated') {
            $nullProperties = array_fill_keys(array_keys($properties['attributes']), null);

            $properties['old'] = array_merge($nullProperties, $this->oldAttributes);
        }

        if ($this->shouldlogOnlyDirty() && isset($properties['old'])) {
            $properties['attributes'] = array_udiff_assoc(
                $properties['attributes'],
                $properties['old'],
                function ($new, $old) {
                    return $new <=> $old;
                }
            );
            $properties['old'] = collect($properties['old'])
                ->only(array_keys($properties['attributes']))
                ->all();
        }

        return $properties;
    }

    public static function logChanges(Model $model): array
    {
        $changes = [];
        foreach ($model->attributesToBeLogged() as $attribute) {
            if (str_contains($attribute, '.')) {
                $changes += self::getRelatedModelAttributeValue($model, $attribute);
            } else {
                $changes += collect($model)->only($attribute)->toArray();
            }
        }

        return $changes;
    }

    protected static function getRelatedModelAttributeValue(Model $model, string $attribute): array
    {
        if (substr_count($attribute, '.') > 1) {
            throw CouldNotLogChanges::invalidAttribute($attribute);
        }

        list($relatedModelName, $relatedAttribute) = explode('.', $attribute);

        $relatedModel = $model->$relatedModelName ?? $model->$relatedModelName();

        return ["{$relatedModelName}.{$relatedAttribute}" => $relatedModel->$relatedAttribute ?? null];
    }
}


1			<?php
2
3			namespace Spatie\Activitylog\Traits;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Spatie\Activitylog\Exceptions\CouldNotLogChanges;
7
8			trait DetectsChanges
9			{
10			protected $oldAttributes = [];
11
12			protected static function bootDetectsChanges()
13			{
14			if (static::eventsToBeRecorded()->contains('updated')) {
15			static::updating(function (Model $model) {
16
17			//temporary hold the original attributes on the model
18			//as we'll need these in the updating event
19			$oldValues = $model->replicate()->setRawAttributes($model->getOriginal());
20
21			$model->oldAttributes = static::logChanges($oldValues);
			0 ignored issues – show Bug introduced 2016-07-28 09:24 UTC by Report Bug Copy Issue Report The property `oldAttributes` does not seem to exist. Did you mean `attributes`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
22			});
23			}
24			}
25
26			public function attributesToBeLogged(): array
27			{
28			$attributes = [];
29
30			if (isset(static::$logFillable) && static::$logFillable) {
31			$attributes = array_merge($attributes, $this->getFillable());
			0 ignored issues – show Bug introduced 2018-10-16 15:15 UTC by Report Bug Copy Issue Report It seems like `getFillable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			}
33
34			if ($this->shouldlogUnguarded()) {
35			$attributes = array_merge($attributes, array_diff(array_keys($this->getAttributes()), $this->getGuarded()));
			0 ignored issues – show Bug introduced 2018-10-16 15:15 UTC by Report Bug Copy Issue Report It seems like `getAttributes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-10-16 15:15 UTC by Report Bug Copy Issue Report It seems like `getGuarded()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			}
37
38			if (isset(static::$logAttributes) && is_array(static::$logAttributes)) {
39			$attributes = array_merge($attributes, array_diff(static::$logAttributes, ['*']));
40
41			if (in_array('*', static::$logAttributes)) {
42			$attributes = array_merge($attributes, array_keys($this->getAttributes()));
			0 ignored issues – show Bug introduced 2018-10-16 15:15 UTC by Report Bug Copy Issue Report It seems like `getAttributes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			}
44			}
45
46			if (isset(static::$logAttributesToIgnore) && is_array(static::$logAttributesToIgnore)) {
47			$attributes = array_diff($attributes, static::$logAttributesToIgnore);
48			}
49
50			return $attributes;
51			}
52
53			public function shouldlogOnlyDirty(): bool
54			{
55			if (! isset(static::$logOnlyDirty)) {
56			return false;
57			}
58
59			return static::$logOnlyDirty;
60			}
61
62			public function shouldlogUnguarded(): bool
63			{
64			if (! isset(static::$logUnguarded)) {
65			return false;
66			}
67
68			if (! static::$logUnguarded) {
69			return false;
70			}
71
72			if (in_array('*', $this->getGuarded())) {
			0 ignored issues – show Bug introduced 2018-10-18 01:11 UTC by Report Bug Copy Issue Report It seems like `getGuarded()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
73			return false;
74			}
75
76			return true;
77			}
78
79			public function attributeValuesToBeLogged(string $processingEvent): array
80			{
81			if (! count($this->attributesToBeLogged())) {
82			return [];
83			}
84
85			$properties['attributes'] = static::logChanges(
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-09-28 06:30 UTC by Report Bug Copy Issue Report `$properties` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$properties = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
86			$this->exists
			0 ignored issues – show Bug introduced 2017-09-28 06:30 UTC by Report Bug Copy Issue Report The property `exists` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
87			? $this->fresh() ?? $this
			0 ignored issues – show Bug introduced 2017-09-28 06:30 UTC by Report Bug Copy Issue Report It seems like `fresh()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
88			: $this
89			);
90
91			if (static::eventsToBeRecorded()->contains('updated') && $processingEvent == 'updated') {
92			$nullProperties = array_fill_keys(array_keys($properties['attributes']), null);
93
94			$properties['old'] = array_merge($nullProperties, $this->oldAttributes);
95			}
96
97			if ($this->shouldlogOnlyDirty() && isset($properties['old'])) {
98			$properties['attributes'] = array_udiff_assoc(
99			$properties['attributes'],
100			$properties['old'],
101			function ($new, $old) {
102			return $new <=> $old;
103			}
104			);
105			$properties['old'] = collect($properties['old'])
106			->only(array_keys($properties['attributes']))
107			->all();
108			}
109
110			return $properties;
111			}
112
113			public static function logChanges(Model $model): array
114			{
115			$changes = [];
116			foreach ($model->attributesToBeLogged() as $attribute) {
117			if (str_contains($attribute, '.')) {
118			$changes += self::getRelatedModelAttributeValue($model, $attribute);
119			} else {
120			$changes += collect($model)->only($attribute)->toArray();
121			}
122			}
123
124			return $changes;
125			}
126
127			protected static function getRelatedModelAttributeValue(Model $model, string $attribute): array
128			{
129			if (substr_count($attribute, '.') > 1) {
130			throw CouldNotLogChanges::invalidAttribute($attribute);
131			}
132
133			list($relatedModelName, $relatedAttribute) = explode('.', $attribute);
134
135			$relatedModel = $model->$relatedModelName ?? $model->$relatedModelName();
136
137			return ["{$relatedModelName}.{$relatedAttribute}" => $relatedModel->$relatedAttribute ?? null];
138			}
139			}
140

spatie / laravel-activitylog

Push — master ( 11b2e0...68eb6e )

DetectsChanges::shouldlogUnguarded() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like