Parser - Code Metrics - spatie/emoji - Measure and Improve Code Quality continuously with Scrutinizer

Parser A
last analyzed 2020-10-12 09:02 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	14
lcom	1
cbo	1
dl	0
loc	86
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	parse()	8	2
A	getEmojis()	4	1
A	getGroups()	4	1
B	parseLine()	36	8
A	addEmoji()	7	1

<?php

namespace Spatie\Emoji\Generator;

class Parser
{
    /** @var string */
    protected $body;

    /** @var string */
    protected $group;

    /** @var string */
    protected $subgroup;

    /** @var array */
    protected $emojis = [];

    /** @var array */
    protected $groups = [];

    public function __construct(string $body)
    {
        $this->body = $body;
    }

    public function parse()
    {
        $lines = explode("\n", $this->body);

        foreach ($lines as $line) {
            $this->parseLine(trim($line));
        }
    }

    public function getEmojis(): array
    {
        return $this->emojis;
    }

    public function getGroups(): array
    {
        return $this->groups;
    }

    protected function parseLine(string $line)
    {
        if (strlen($line) === 0) {
            return;
        }

        if (strpos($line, '# group:') === 0) {
            $this->group = trim(str_replace('# group:', '', $line));

            return;
        }

        if (strpos($line, '# subgroup:') === 0) {
            $this->subgroup = trim(str_replace('# subgroup:', '', $line));

            return;
        }

        if (strpos($line, '#') === 0) {
            return;
        }

        preg_match('/^([A-Z\d ]+)\s+;\s+(fully-qualified|component)\s+# [^a-z ]* (.+)$/', $line, $matches);
        if (count($matches) === 4) {
            [, $code, , $name] = $matches;
function someFunction() {
    $x = 5;
    echo $x;
}

            if (
                $this->subgroup === 'country-flag'
                || $this->subgroup === 'subdivision-flag'
            ) {
                $name = 'flags for: '.$name;
function someFunction() {
    $x = 5;
    echo $x;
}
            }

            $this->addEmoji(trim($code), trim($name));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
    }

    protected function addEmoji(string $code, string $name)
    {
        $emoji = new Emoji($name, $code);

        $this->groups[$this->group][$this->subgroup][$code] = $emoji;
        $this->emojis[$code] = $emoji;
    }
}


1			<?php
2
3			namespace Spatie\Emoji\Generator;
4
5			class Parser
6			{
7			/** @var string */
8			protected $body;
9
10			/** @var string */
11			protected $group;
12
13			/** @var string */
14			protected $subgroup;
15
16			/** @var array */
17			protected $emojis = [];
18
19			/** @var array */
20			protected $groups = [];
21
22			public function __construct(string $body)
23			{
24			$this->body = $body;
25			}
26
27			public function parse()
28			{
29			$lines = explode("\n", $this->body);
30
31			foreach ($lines as $line) {
32			$this->parseLine(trim($line));
33			}
34			}
35
36			public function getEmojis(): array
37			{
38			return $this->emojis;
39			}
40
41			public function getGroups(): array
42			{
43			return $this->groups;
44			}
45
46			protected function parseLine(string $line)
47			{
48			if (strlen($line) === 0) {
49			return;
50			}
51
52			if (strpos($line, '# group:') === 0) {
53			$this->group = trim(str_replace('# group:', '', $line));
54
55			return;
56			}
57
58			if (strpos($line, '# subgroup:') === 0) {
59			$this->subgroup = trim(str_replace('# subgroup:', '', $line));
60
61			return;
62			}
63
64			if (strpos($line, '#') === 0) {
65			return;
66			}
67
68			preg_match('/^([A-Z\d ]+)\s+;\s+(fully-qualified\|component)\s+# [^a-z ]* (.+)$/', $line, $matches);
69			if (count($matches) === 4) {
70			[, $code, , $name] = $matches;
			0 ignored issues – show Bug introduced 2019-07-24 19:25 UTC by Report Bug Copy Issue Report The variable `$code` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2019-07-24 19:25 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
71
72			if (
73			$this->subgroup === 'country-flag'
74			\|\| $this->subgroup === 'subdivision-flag'
75			) {
76			$name = 'flags for: '.$name;
			0 ignored issues – show Bug introduced 2019-07-24 19:25 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
77			}
78
79			$this->addEmoji(trim($code), trim($name));
			0 ignored issues – show Bug introduced 2019-07-24 19:25 UTC by Report Bug Copy Issue Report The variable `$name` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
80			}
81			}
82
83			protected function addEmoji(string $code, string $name)
84			{
85			$emoji = new Emoji($name, $code);
86
87			$this->groups[$this->group][$this->subgroup][$code] = $emoji;
88			$this->emojis[$code] = $emoji;
89			}
90			}
91

spatie / emoji

GitHub Access Token became invalid

Parser A last analyzed 2020-10-12 09:02 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

Parser A
last analyzed 2020-10-12 09:02 UTC