Spatie\EmailConcealer\ConcealedEmailCollection

Complexity

Total Complexity

10

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	make()	0	4	1
A	fill()	0	8	2
A	getIterator()	0	4	1
A	add()	0	14	3
A	addOrUpdateIncrement()	0	13	2

<?php

namespace Spatie\EmailConcealer;

use ArrayIterator;
use IteratorAggregate;

final class ConcealedEmailCollection implements IteratorAggregate
{
    /** @var string */
    private $domain;

    /** @var array */
    private $dictionary = [];

    public function __construct(string $domain)
    {
        $this->domain = $domain;
    }

    public static function make(string $domain): self
    {
        return new self($domain);
    }

    public function fill(iterable $emails): self
    {
        foreach ($emails as $email) {
            $this->add($email);
        }

        return $this;
    }

    public function getIterator()
    {
        return new ArrayIterator($this->dictionary);
    }

    private function add(string $email)
    {
        if (array_key_exists($email, $this->dictionary)) {
            return;
        }

        [$localPart] = explode('@', $email);

The variable $localPart seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

        while (in_array($localPart.'@'.$this->domain, $this->dictionary)) {

The variable $localPart does not seem to be defined for all execution paths leading up to this point.

            $localPart = $this->addOrUpdateIncrement($localPart);
        }

        $this->dictionary[$email] = $localPart.'@'.$this->domain;
    }

    private function addOrUpdateIncrement(string $string): string
    {
        $pattern = '/-(\d+$)/';
        $matches = [];

        if (! preg_match($pattern, $string, $matches)) {
            return $string.'-1';
        }

        $increment = $matches[1] + 1;

        return preg_replace($pattern, "-{$increment}", $string);
    }
}