SortableTrait - Code Metrics - Inspection of "Add Feature: sorting scopes" - spatie/eloquent-sortable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#38)

unknown

created 2017-04-05 08:52 UTC

SortableTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	263
Duplicated Lines	15.59 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	8
Bugs	1	Features	1

Metric	Value
wmc	33
c	8
b	1
f	1
lcom	1
cbo	1
dl	41
loc	263
rs	9.3999

15 Methods

Rating	Name	Duplication	Size	Complexity
A	bootSortableTrait()	0	8	3
A	setHighestOrderNumber()	0	6	1
A	getHighestOrderNumber()	0	9	2
A	scopeOrdered()	0	4	1
A	setNewOrder()	0	17	4
A	determineOrderColumnName()	0	11	3
A	determineSortScope()	0	10	3
A	hasSortScope()	0	3	1
A	shouldSortWhenCreating()	0	4	1
A	moveOrderDown()	21	21	3
A	moveOrderUp()	20	20	3
A	swapOrderWithModel()	0	14	1
A	swapOrder()	0	4	1
B	moveToStart()	0	25	3
B	moveToEnd()	0	26	3

How to fix Duplicated Code

<?php

namespace Spatie\EloquentSortable;

use ArrayAccess;
use InvalidArgumentException;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\SoftDeletingScope;

trait SortableTrait
{
    public static function bootSortableTrait()
    {
        static::creating(function ($model) {

            if ($model instanceof Sortable && $model->shouldSortWhenCreating()) {
                $model->setHighestOrderNumber();
            }
        });
    }

    /**
     * Modify the order column value.
     */
    public function setHighestOrderNumber()
    {
        $orderColumnName = $this->determineOrderColumnName();

        $this->$orderColumnName = $this->getHighestOrderNumber() + 1;
    }

    /**
     * Determine the Record with the highest order (located at the "End").
     *
     * @return int
     */
    public function getHighestOrderNumber(): int
    {
        if ($this->hasSortScope()) {
            return static::where($this->determineSortScope(), $this->{$this->determineSortScope()})
                ->max($this->determineOrderColumnName());
        }

        return (int) static::max($this->determineOrderColumnName());
    }

    /**
     * Let's be nice and provide an ordered scope.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param string $direction
     *
     * @return \Illuminate\Database\Query\Builder
     */
    public function scopeOrdered(Builder $query, string $direction = 'asc')
    {
        return $query->orderBy($this->determineOrderColumnName(), $direction);

    }

    /**
     * This function reorders the records: the record with the first id in the array
     * will get order 1, the record with the second it will get order 2, ...
     *
     * A starting order number can be optionally supplied (defaults to 1).
     *
     * @param array|\ArrayAccess $ids
     * @param int $startOrder
     */
    public static function setNewOrder($ids, int $startOrder = 1)
    {
        if (! is_array($ids) && ! $ids instanceof ArrayAccess) {
            throw new InvalidArgumentException('You must pass an array or ArrayAccess object to setNewOrder');
        }

        $model = new static;

        $orderColumnName = $model->determineOrderColumnName();
        $primaryKeyColumn = $model->getKeyName();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        foreach ($ids as $id) {
            static::withoutGlobalScope(SoftDeletingScope::class)
                ->where($primaryKeyColumn, $id)
                ->update([$orderColumnName => $startOrder++]);
        }
    }

    /*
     * Determine the column name of the order column.
     */
    protected function determineOrderColumnName(): string
    {
        if (
            isset($this->sortable['order_column_name']) &&
            ! empty($this->sortable['order_column_name'])
        ) {
            return $this->sortable['order_column_name'];
        }

        return 'order_column';
    }

    public function determineSortScope() {
        if (
            isset($this->sortable['sort_scope']) &&
            ! empty($this->sortable['sort_scope'])
        ) {
            return $this->sortable['sort_scope'];
        }

        return '';
    }

    public function hasSortScope() {
        return !empty($this->determineSortScope());
    }

    /**
     * Determine if the order column should be set when saving a new model instance.
     */
    public function shouldSortWhenCreating(): bool
    {
        return $this->sortable['sort_when_creating'] ?? true;
    }

    /**
     * Swaps the order of this model with the model 'below' this model.
     *
     * @return $this
     */
    public function moveOrderDown()

    {
        $orderColumnName = $this->determineOrderColumnName();

        $swapWithModel = static::limit(1)
            ->ordered()
            ->where($orderColumnName, '>', $this->$orderColumnName);


        if ($this->hasSortScope()) {
            $swapWithModel = $swapWithModel->where($this->determineSortScope(), $this->{$this->determineSortScope()});
        }

        $swapWithModel = $swapWithModel->first();

        if (! $swapWithModel) {
            return $this;
        }

        return $this->swapOrderWithModel($swapWithModel);
    }
        
    /**
     * Swaps the order of this model with the model 'above' this model.
     *
     * @return $this
     */
    public function moveOrderUp()

    {
        $orderColumnName = $this->determineOrderColumnName();

        $swapWithModel = static::limit(1)
            ->ordered('desc')
            ->where($orderColumnName, '<', $this->$orderColumnName);

        if ($this->hasSortScope()) {
            $swapWithModel = $swapWithModel->where($this->determineSortScope(), $this->{$this->determineSortScope()});
        }

        $swapWithModel = $swapWithModel->first();

        if (! $swapWithModel) {
            return $this;
        }

        return $this->swapOrderWithModel($swapWithModel);
    }

    /**
     * Swap the order of this model with the order of another model.
     *
     * @param \Spatie\EloquentSortable\Sortable $otherModel
     *
     * @return $this
     */
    public function swapOrderWithModel(Sortable $otherModel)
    {
        $orderColumnName = $this->determineOrderColumnName();

        $oldOrderOfOtherModel = $otherModel->$orderColumnName;

        $otherModel->$orderColumnName = $this->$orderColumnName;
        $otherModel->save();

        $this->$orderColumnName = $oldOrderOfOtherModel;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    /**
     * Swap the order of two models.
     *
     * @param \Spatie\EloquentSortable\Sortable $model
     * @param \Spatie\EloquentSortable\Sortable $otherModel
     */
    public static function swapOrder(Sortable $model, Sortable $otherModel)
    {
        $model->swapOrderWithModel($otherModel);
    }

    /**
     * Moves this model to the first position.
     *
     * @return $this
     */
    public function moveToStart()
    {
        $firstModel = static::limit(1)
            ->ordered()
            ->first();

        if ($firstModel->id === $this->id) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return $this;
        }

        $orderColumnName = $this->determineOrderColumnName();

        $this->$orderColumnName = $firstModel->$orderColumnName;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $fixOtherRecords = static::where($this->getKeyName(), '!=', $this->id);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        if ($this->hasSortScope()) {
            $fixOtherRecords = $fixOtherRecords->where($this->determineSortScope(), $this->{$this->determineSortScope()});
        }
            
        $fixOtherRecords->increment($orderColumnName);

        return $this;
    }

    /**
     * Moves this model to the last position.
     *
     * @return $this
     */
    public function moveToEnd()
    {
        $maxOrder = $this->getHighestOrderNumber();

        $orderColumnName = $this->determineOrderColumnName();

        if ($this->$orderColumnName === $maxOrder) {
            return $this;
        }

        $oldOrder = $this->$orderColumnName;

        $this->$orderColumnName = $maxOrder;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $fixOtherRecords = static::where($this->getKeyName(), '!=', $this->id)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where($orderColumnName, '>', $oldOrder);

        if ($this->hasSortScope()) {
            $fixOtherRecords = $fixOtherRecords->where($this->determineSortScope(), $this->{$this->determineSortScope()});
        }

        $fixOtherRecords->decrement($orderColumnName);

        return $this;
    }
}


1		<?php
2
3		namespace Spatie\EloquentSortable;
4
5		use ArrayAccess;
6		use InvalidArgumentException;
7		use Illuminate\Database\Eloquent\Builder;
8		use Illuminate\Database\Eloquent\SoftDeletingScope;
9
10		trait SortableTrait
11		{
12		public static function bootSortableTrait()
13		{
14		static::creating(function ($model) {
		0 ignored issues – show Bug introduced 2016-10-21 22:32 UTC by Report Bug Copy Issue Report The method `creating()` does not exist on `Spatie\EloquentSortable\SortableTrait`. Did you maybe mean `shouldSortWhenCreating()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
15		if ($model instanceof Sortable && $model->shouldSortWhenCreating()) {
16		$model->setHighestOrderNumber();
17		}
18		});
19		}
20
21		/**
22		* Modify the order column value.
23		*/
24		public function setHighestOrderNumber()
25		{
26		$orderColumnName = $this->determineOrderColumnName();
27
28		$this->$orderColumnName = $this->getHighestOrderNumber() + 1;
29		}
30
31		/**
32		* Determine the Record with the highest order (located at the "End").
33		*
34		* @return int
35		*/
36		public function getHighestOrderNumber(): int
37		{
38		if ($this->hasSortScope()) {
39		return static::where($this->determineSortScope(), $this->{$this->determineSortScope()})
40		->max($this->determineOrderColumnName());
41		}
42
43		return (int) static::max($this->determineOrderColumnName());
44		}
45
46		/**
47		* Let's be nice and provide an ordered scope.
48		*
49		* @param \Illuminate\Database\Eloquent\Builder $query
50		* @param string $direction
51		*
52		* @return \Illuminate\Database\Query\Builder
53		*/
54		public function scopeOrdered(Builder $query, string $direction = 'asc')
55		{
56		return $query->orderBy($this->determineOrderColumnName(), $direction);
		0 ignored issues – show Bug introduced 2017-04-05 09:01 UTC by Report Bug Copy Issue Report The method `orderBy()` does not exist on `Illuminate\Database\Eloquent\Builder`. Did you maybe mean `enforceOrderBy()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
57		}
58
59		/**
60		* This function reorders the records: the record with the first id in the array
61		* will get order 1, the record with the second it will get order 2, ...
62		*
63		* A starting order number can be optionally supplied (defaults to 1).
64		*
65		* @param array\|\ArrayAccess $ids
66		* @param int $startOrder
67		*/
68		public static function setNewOrder($ids, int $startOrder = 1)
69		{
70		if (! is_array($ids) && ! $ids instanceof ArrayAccess) {
71		throw new InvalidArgumentException('You must pass an array or ArrayAccess object to setNewOrder');
72		}
73
74		$model = new static;
75
76		$orderColumnName = $model->determineOrderColumnName();
77		$primaryKeyColumn = $model->getKeyName();
		0 ignored issues – show Bug introduced 2016-10-18 22:46 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
78
79		foreach ($ids as $id) {
80		static::withoutGlobalScope(SoftDeletingScope::class)
81		->where($primaryKeyColumn, $id)
82		->update([$orderColumnName => $startOrder++]);
83		}
84		}
85
86		/*
87		* Determine the column name of the order column.
88		*/
89		protected function determineOrderColumnName(): string
90		{
91		if (
92		isset($this->sortable['order_column_name']) &&
93		! empty($this->sortable['order_column_name'])
94		) {
95		return $this->sortable['order_column_name'];
96		}
97
98		return 'order_column';
99		}
100
101		public function determineSortScope() {
102		if (
103		isset($this->sortable['sort_scope']) &&
104		! empty($this->sortable['sort_scope'])
105		) {
106		return $this->sortable['sort_scope'];
107		}
108
109		return '';
110		}
111
112		public function hasSortScope() {
113		return !empty($this->determineSortScope());
114		}
115
116		/**
117		* Determine if the order column should be set when saving a new model instance.
118		*/
119		public function shouldSortWhenCreating(): bool
120		{
121		return $this->sortable['sort_when_creating'] ?? true;
122		}
123
124		/**
125		* Swaps the order of this model with the model 'below' this model.
126		*
127		* @return $this
128		*/
129	View Code Duplication	public function moveOrderDown()
		0 ignored issues – show Duplication introduced 2016-02-14 14:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
130		{
131		$orderColumnName = $this->determineOrderColumnName();
132
133		$swapWithModel = static::limit(1)
134		->ordered()
135		->where($orderColumnName, '>', $this->$orderColumnName);
136
137
138		if ($this->hasSortScope()) {
139		$swapWithModel = $swapWithModel->where($this->determineSortScope(), $this->{$this->determineSortScope()});
140		}
141
142		$swapWithModel = $swapWithModel->first();
143
144		if (! $swapWithModel) {
145		return $this;
146		}
147
148		return $this->swapOrderWithModel($swapWithModel);
149		}
150
151		/**
152		* Swaps the order of this model with the model 'above' this model.
153		*
154		* @return $this
155		*/
156	View Code Duplication	public function moveOrderUp()
		0 ignored issues – show Duplication introduced 2016-02-14 14:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
157		{
158		$orderColumnName = $this->determineOrderColumnName();
159
160		$swapWithModel = static::limit(1)
161		->ordered('desc')
162		->where($orderColumnName, '<', $this->$orderColumnName);
163
164		if ($this->hasSortScope()) {
165		$swapWithModel = $swapWithModel->where($this->determineSortScope(), $this->{$this->determineSortScope()});
166		}
167
168		$swapWithModel = $swapWithModel->first();
169
170		if (! $swapWithModel) {
171		return $this;
172		}
173
174		return $this->swapOrderWithModel($swapWithModel);
175		}
176
177		/**
178		* Swap the order of this model with the order of another model.
179		*
180		* @param \Spatie\EloquentSortable\Sortable $otherModel
181		*
182		* @return $this
183		*/
184		public function swapOrderWithModel(Sortable $otherModel)
185		{
186		$orderColumnName = $this->determineOrderColumnName();
187
188		$oldOrderOfOtherModel = $otherModel->$orderColumnName;
189
190		$otherModel->$orderColumnName = $this->$orderColumnName;
191		$otherModel->save();
192
193		$this->$orderColumnName = $oldOrderOfOtherModel;
194		$this->save();
		0 ignored issues – show Bug introduced 2016-10-19 14:01 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
195
196		return $this;
197		}
198
199		/**
200		* Swap the order of two models.
201		*
202		* @param \Spatie\EloquentSortable\Sortable $model
203		* @param \Spatie\EloquentSortable\Sortable $otherModel
204		*/
205		public static function swapOrder(Sortable $model, Sortable $otherModel)
206		{
207		$model->swapOrderWithModel($otherModel);
208		}
209
210		/**
211		* Moves this model to the first position.
212		*
213		* @return $this
214		*/
215		public function moveToStart()
216		{
217		$firstModel = static::limit(1)
218		->ordered()
219		->first();
220
221		if ($firstModel->id === $this->id) {
		0 ignored issues – show Bug introduced 2016-10-18 21:42 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
222		return $this;
223		}
224
225		$orderColumnName = $this->determineOrderColumnName();
226
227		$this->$orderColumnName = $firstModel->$orderColumnName;
228		$this->save();
		0 ignored issues – show Bug introduced 2017-04-05 09:01 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
229
230		$fixOtherRecords = static::where($this->getKeyName(), '!=', $this->id);
		0 ignored issues – show Bug introduced 2017-04-05 09:01 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
231
232		if ($this->hasSortScope()) {
233		$fixOtherRecords = $fixOtherRecords->where($this->determineSortScope(), $this->{$this->determineSortScope()});
234		}
235
236		$fixOtherRecords->increment($orderColumnName);
237
238		return $this;
239		}
240
241		/**
242		* Moves this model to the last position.
243		*
244		* @return $this
245		*/
246		public function moveToEnd()
247		{
248		$maxOrder = $this->getHighestOrderNumber();
249
250		$orderColumnName = $this->determineOrderColumnName();
251
252		if ($this->$orderColumnName === $maxOrder) {
253		return $this;
254		}
255
256		$oldOrder = $this->$orderColumnName;
257
258		$this->$orderColumnName = $maxOrder;
259		$this->save();
		0 ignored issues – show Bug introduced 2017-04-05 09:01 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
260
261		$fixOtherRecords = static::where($this->getKeyName(), '!=', $this->id)
		0 ignored issues – show Bug introduced 2017-04-05 09:01 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
262		->where($orderColumnName, '>', $oldOrder);
263
264		if ($this->hasSortScope()) {
265		$fixOtherRecords = $fixOtherRecords->where($this->determineSortScope(), $this->{$this->determineSortScope()});
266		}
267
268		$fixOtherRecords->decrement($orderColumnName);
269
270		return $this;
271		}
272		}
273

spatie / eloquent-sortable

Pull Request — master (#38)

SortableTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like