Spatie\EloquentSortable\SortableTrait

Complexity

Total Complexity

17

Size/Duplication

Total Lines	162
Duplicated Lines	18.52 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	5
Bugs	1	Features	1

9 Methods

Rating	Name	Duplication	Size	Complexity
A	setHighestOrderNumber()	0	5	1
A	getHighestOrderNumber()	0	4	1
A	scopeOrdered()	0	4	1
A	setNewOrder()	0	13	3
A	determineOrderColumnName()	0	11	3
A	shouldSortWhenCreating()	0	12	3
A	moveOrderDown()	15	15	2
A	moveOrderUp()	15	15	2
A	swapOrderWithModel()	0	15	1

<?php

namespace Spatie\EloquentSortable;

trait SortableTrait
{
    /**
     * Modify the order column value.
     */
    public function setHighestOrderNumber()
    {
        $orderColumnName = $this->determineOrderColumnName();
        $this->$orderColumnName = $this->getHighestOrderNumber() + 1;
    }

    /**
     * Determine the order value for the new record.
     *
     * @return int
     */
    public function getHighestOrderNumber()
    {
        return ((int) static::max($this->determineOrderColumnName()));
    }

    /**
     * Let's be nice and provide an ordered scope.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     *
     * @return \Illuminate\Database\Query\Builder
     */
    public function scopeOrdered(\Illuminate\Database\Eloquent\Builder $query)
    {
        return $query->orderBy($this->determineOrderColumnName());
    }

    /**
     * This function reorders the records: the record with the first id in the array
     * will get order 1, the record with the second it will get order 2, ...
     *
     * A starting order number can be optionally supplied (defaults to 1).
     *
     * @param array $ids
     * @param int   $startOrder
     *
     * @throws SortableException
     */
    public static function setNewOrder($ids, $startOrder = 1)
    {
        if (!is_array($ids)) {
            throw new SortableException('You must pass an array to setNewOrder');
        }

        foreach ($ids as $id) {
            $model = static::find($id);
            $orderColumnName = $model->determineOrderColumnName();
            $model->$orderColumnName = $startOrder++;
            $model->save();
        }
    }

    /**
     * Determine the column name of the order column.
     *
     * @return string
     */
    public function determineOrderColumnName()
    {
        if (
            isset($this->sortable['order_column_name']) &&
            !empty($this->sortable['order_column_name'])
        ) {
            return $this->sortable['order_column_name'];
        }

        return 'order_column';
    }

    /**
     * Determine if the order column should be set when saving a new model instance.
     *
     * @return bool
     */
    public function shouldSortWhenCreating()
    {
        if (!isset($this->sortable)) {
            return true;
        }

        if (!isset($this->sortable['sort_when_creating'])) {
            return true;
        }

        return $this->sortable['sort_when_creating'];
    }

    /**
     * Swaps the order of this model with the model 'below' this model
     *
     * @return $this
     *
     * @throws SortableException
     */
    public function moveOrderDown()

This method seems to be duplicated in your project.

    {
        $orderColumnName = $this->determineOrderColumnName();

        $swapWithModel = static::limit(1)
            ->ordered()
            ->where($orderColumnName, '>', $this->$orderColumnName)
            ->first();

        if (!$swapWithModel) {
            throw new SortableException('The model you try to move down has already the lowest order');
        }

        return $this->swapOrderWithModel($swapWithModel);
    }

    /**
     * Swaps the order of this model with the model 'above' this model
     *
     * @return $this
     *
     * @throws SortableException
     */
    public function moveOrderUp()

This method seems to be duplicated in your project.

    {
        $orderColumnName = $this->determineOrderColumnName();

        $swapWithModel = static::limit(1)
            ->ordered()
            ->where($orderColumnName, '<', $this->$orderColumnName)
            ->first();

        if (!$swapWithModel) {
            throw new SortableException('The model you try to move up has already the highest order');
        }

        return $this->swapOrderWithModel($swapWithModel);
    }

    /**
     * Swap the order of this model with the order of another model
     *
     * @param \Spatie\EloquentSortable\Sortable $model
     *
     * @return $this
     */
    protected function swapOrderWithModel(Sortable $model)
    {
        $thisModelColumnName  = $this->determineOrderColumnName();
        $otherModelColumnName = $model->determineOrderColumnName();

        $currentOtherModelOrder = $model->$otherModelColumnName;

        $model->$otherModelColumnName = $this->$thisModelColumnName;
        $model->save();

        $this->$thisModelColumnName = $currentOtherModelOrder;
        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this;
    }
}