Issues in DocblockFieldValidator.php (master) - Issues in master - spatie/data-transfer-object - Measure and Improve Code Quality continuously with Scrutinizer

Issues (13)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/DocblockFieldValidator.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Spatie\DataTransferObject;

class DocblockFieldValidator extends FieldValidator
{
    public const DOCBLOCK_REGEX = <<<REGEXP
        /
        @var (                               # Starting with `@var `, we'll capture the definition the follows
        
             (?:                             # Not explicitly capturing this group,
                                             # which contains repeated sets of type definitions
        
                 (?:                         # Not explicitly capturing this group
                     [\w?|\\\\<>,\s]         # Matches type definitions like `int|string|\My\Object|array<int, string>`
                 )+                          # These definitions can be repeated
        
                 (?:                         # Not explicitly capturing this group
                     \[]                     # Matches array definitions like `int[]`
                 )?                          # Array definitions are optional though
        
             )+                              # Repeated sets of type definitions
        
        )                                    # The whole definition after `@var ` is captured in one group
        /x
REGEXP;

    public function __construct(string $definition, bool $hasDefaultValue = false)
    {
        preg_match(
            DocblockFieldValidator::DOCBLOCK_REGEX,
            $definition,
            $matches
        );

        $definition = trim($matches[1] ?? '');

        $this->hasTypeDeclaration = $definition !== '';
        $this->hasDefaultValue = $hasDefaultValue;
        $this->isNullable = $this->resolveNullable($definition);
        $this->isMixed = $this->resolveIsMixed($definition);
        $this->isMixedArray = $this->resolveIsMixedArray($definition);
        $this->allowedTypes = $this->resolveAllowedTypes($definition);
        $this->allowedArrayTypes = $this->resolveAllowedArrayTypes($definition);
        $this->allowedArrayKeyTypes = $this->resolveAllowedArrayKeyTypes($definition);
    }

    private function resolveNullable(string $definition): bool
    {
        if (! $definition) {
            return true;
        }

        if (Str::contains($definition, ['mixed', 'null', '?'])) {
            return true;
        }

        return false;
    }

    private function resolveIsMixed(string $definition): bool
    {
        return Str::contains($definition, ['mixed']);
    }

    private function resolveIsMixedArray(string $definition): bool
    {
        $types = $this->normaliseTypes(...explode('|', $definition));

        foreach ($types as $type) {
            if (in_array($type, ['iterable', 'array'])) {
                return true;
            }
        }

        return false;
    }

    private function resolveAllowedTypes(string $definition): array
    {
        return $this->normaliseTypes(...explode('|', $definition));
    }

    private function resolveAllowedArrayTypes(string $definition): array
    {
        return $this->normaliseTypes(...array_map(
            function (string $type) {
                if (! $type) {
                    return;
                }

                if (strpos($type, '[]') !== false) {
                    return str_replace('[]', '', $type);
                }

                if (strpos($type, '>') !== false) {
                    preg_match('/([\w\\\\]+)(>)/', $type, $matches);

                    return $matches[1];
                }

                return null;
            },
            explode('|', $definition)
        ));
    }

    private function resolveAllowedArrayKeyTypes(string $definition): array
    {
        return $this->normaliseTypes(...array_map(
            function (string $type) {
                if (strpos($type, '<') === false) {
                    return;
                }

                preg_match('/(<)([\w\\\\]+)(,)/', $type, $matches);

                return $matches[2] ?? null;
            },
            explode('|', $definition)
        ));
    }

    private function normaliseTypes(?string ...$types): array
    {
        return array_filter(array_map(
            fn (?string $type) => self::$typeMapping[$type] ?? $type,

            $types
        ));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Spatie\DataTransferObject;
6
7			class DocblockFieldValidator extends FieldValidator
8			{
9			public const DOCBLOCK_REGEX = <<<REGEXP
10			/
11			@var ( # Starting with `@var `, we'll capture the definition the follows
12
13			(?: # Not explicitly capturing this group,
14			# which contains repeated sets of type definitions
15
16			(?: # Not explicitly capturing this group
17			[\w?\|\\\\<>,\s] # Matches type definitions like `int\|string\|\My\Object\|array<int, string>`
18			)+ # These definitions can be repeated
19
20			(?: # Not explicitly capturing this group
21			\[] # Matches array definitions like `int[]`
22			)? # Array definitions are optional though
23
24			)+ # Repeated sets of type definitions
25
26			) # The whole definition after `@var ` is captured in one group
27			/x
28			REGEXP;
29
30			public function __construct(string $definition, bool $hasDefaultValue = false)
31			{
32			preg_match(
33			DocblockFieldValidator::DOCBLOCK_REGEX,
34			$definition,
35			$matches
36			);
37
38			$definition = trim($matches[1] ?? '');
39
40			$this->hasTypeDeclaration = $definition !== '';
41			$this->hasDefaultValue = $hasDefaultValue;
42			$this->isNullable = $this->resolveNullable($definition);
43			$this->isMixed = $this->resolveIsMixed($definition);
44			$this->isMixedArray = $this->resolveIsMixedArray($definition);
45			$this->allowedTypes = $this->resolveAllowedTypes($definition);
46			$this->allowedArrayTypes = $this->resolveAllowedArrayTypes($definition);
47			$this->allowedArrayKeyTypes = $this->resolveAllowedArrayKeyTypes($definition);
48			}
49
50			private function resolveNullable(string $definition): bool
51			{
52			if (! $definition) {
53			return true;
54			}
55
56			if (Str::contains($definition, ['mixed', 'null', '?'])) {
57			return true;
58			}
59
60			return false;
61			}
62
63			private function resolveIsMixed(string $definition): bool
64			{
65			return Str::contains($definition, ['mixed']);
66			}
67
68			private function resolveIsMixedArray(string $definition): bool
69			{
70			$types = $this->normaliseTypes(...explode('\|', $definition));
71
72			foreach ($types as $type) {
73			if (in_array($type, ['iterable', 'array'])) {
74			return true;
75			}
76			}
77
78			return false;
79			}
80
81			private function resolveAllowedTypes(string $definition): array
82			{
83			return $this->normaliseTypes(...explode('\|', $definition));
84			}
85
86			private function resolveAllowedArrayTypes(string $definition): array
87			{
88			return $this->normaliseTypes(...array_map(
89			function (string $type) {
90			if (! $type) {
91			return;
92			}
93
94			if (strpos($type, '[]') !== false) {
95			return str_replace('[]', '', $type);
96			}
97
98			if (strpos($type, '>') !== false) {
99			preg_match('/([\w\\\\]+)(>)/', $type, $matches);
100
101			return $matches[1];
102			}
103
104			return null;
105			},
106			explode('\|', $definition)
107			));
108			}
109
110			private function resolveAllowedArrayKeyTypes(string $definition): array
111			{
112			return $this->normaliseTypes(...array_map(
113			function (string $type) {
114			if (strpos($type, '<') === false) {
115			return;
116			}
117
118			preg_match('/(<)([\w\\\\]+)(,)/', $type, $matches);
119
120			return $matches[2] ?? null;
121			},
122			explode('\|', $definition)
123			));
124			}
125
126			private function normaliseTypes(?string ...$types): array
127			{
128			return array_filter(array_map(
129			fn (?string $type) => self::$typeMapping[$type] ?? $type,
			0 ignored issues – show Bug introduced 2020-05-08 06:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected '?' Loading history...
130			$types
131			));
132			}
133			}
134

GitHub Access Token became invalid

Issues (13)

Security Analysis no request data

src/DocblockFieldValidator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

spatie / data-transfer-object

GitHub Access Token became invalid

Issues (13)

Security Analysis no request data

src/DocblockFieldValidator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like