DataTransferObject::all() - Code Metrics - Inspection of "Override protected attributes" - spatie/data-transfer-object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#141)

by Sergey

created 2020-09-09 15:20 UTC

DataTransferObject::all() A

↳ Parent: DataTransferObject

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	19
Ratio	100 %

Importance

Changes

Metric	Value
dl	19
loc	19
rs	9.6333
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php

declare(strict_types=1);

namespace Spatie\DataTransferObject;

use ReflectionClass;
use ReflectionProperty;

abstract class DataTransferObject
{
    /**
     * @param array $parameters
     *
     * @return \Spatie\DataTransferObject\ImmutableDataTransferObject|static
     */
    public static function immutable(array $parameters = []): ImmutableDataTransferObject
    {
        return new ImmutableDataTransferObject(new static($parameters));
    }

    /**
     * @param array $arrayOfParameters
     *
     * @return \Spatie\DataTransferObject\ImmutableDataTransferObject[]|static[]
     */
    public static function arrayOf(array $arrayOfParameters): array
    {
        return array_map(
            function ($parameters) {
                return new static($parameters);
            },
            $arrayOfParameters
        );
    }

    public function __construct(array $parameters = [])
    {
        $validators = $this->getFieldValidators();

        $valueCaster = $this->getValueCaster();

        /** string[] */
        $invalidTypes = [];

        foreach ($validators as $field => $validator) {
            if (
                ! isset($parameters[$field])
                && ! $validator->hasDefaultValue
                && ! $validator->isNullable
            ) {
                throw DataTransferObjectError::uninitialized(
                    static::class,
                    $field
                );
            }

            $value = $parameters[$field] ?? $this->{$field} ?? null;

            $value = $this->castValue($valueCaster, $validator, $value);

            if (! $validator->isValidType($value)) {
                $invalidTypes[] = DataTransferObjectError::invalidTypeMessage(
                    static::class,
                    $field,
                    $validator->allowedTypes,
                    $value
                );

                continue;
            }

            $this->{$field} = $value;

            unset($parameters[$field]);
        }

        if ($invalidTypes) {

            DataTransferObjectError::invalidTypes($invalidTypes);
        }

        if (! $this->ignoreMissing() && count($parameters)) {
            throw DataTransferObjectError::unknownProperties(array_keys($parameters), static::class);
        }
    }

    protected function ignoreMissing(): bool
    {
        return false;
    }

    public function all(): array

    {
        $data = [];

        $class = new ReflectionClass(static::class);

        $properties = $class->getProperties(ReflectionProperty::IS_PUBLIC);

        foreach ($properties as $reflectionProperty) {
            // Skip static properties
            if ($reflectionProperty->isStatic()) {
                continue;
            }

            $data[$reflectionProperty->getName()] = $reflectionProperty->getValue($this);
        }

        return $data;
    }

    public function only(string ...$keys): DataTransferObjectArray
    {
        return new DataTransferObjectArray(Arr::only($this->toArray(), $keys));
    }

    public function except(string ...$keys): DataTransferObjectArray
    {
        return new DataTransferObjectArray(Arr::except($this->toArray(), $keys));
    }

    public function toArray(): array
    {
        return $this->parseArray($this->all());
    }

    protected function parseArray(array $array): array
    {
        foreach ($array as $key => $value) {
            if (
                $value instanceof DataTransferObject
                || $value instanceof DataTransferObjectCollection
if ($x instanceof DoesNotExist) {
    // Do something.
}
            ) {
                $array[$key] = $value->toArray();

                continue;
            }

            if (! is_array($value)) {
                continue;
            }

            $array[$key] = $this->parseArray($value);
        }

        return $array;
    }

    /**
     * @param \ReflectionClass $class
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return \Spatie\DataTransferObject\FieldValidator[]
     */
    protected function getFieldValidators(): array
    {
        return DTOCache::resolve(static::class, function () {

            $class = new ReflectionClass(static::class);

            $properties = [];

            foreach ($class->getProperties(ReflectionProperty::IS_PUBLIC) as $reflectionProperty) {
                // Skip static properties
                if ($reflectionProperty->isStatic()) {
                    continue;
                }

                $field = $reflectionProperty->getName();

                $properties[$field] = FieldValidator::fromReflection($reflectionProperty);
            }

            return $properties;
        });
    }

    /**
     * @param \Spatie\DataTransferObject\ValueCaster $valueCaster
     * @param \Spatie\DataTransferObject\FieldValidator $fieldValidator
     * @param mixed $value
     *
     * @return mixed
     */
    protected function castValue(ValueCaster $valueCaster, FieldValidator $fieldValidator, $value)
    {
        if (is_array($value)) {
            return $valueCaster->cast($value, $fieldValidator);
        }

        return $value;
    }

    protected function getValueCaster(): ValueCaster
    {
        return new ValueCaster();
    }
}


GitHub Access Token became invalid

Pull Request — master (#141)

DataTransferObject::all() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		declare(strict_types=1);
4
5		namespace Spatie\DataTransferObject;
6
7		use ReflectionClass;
8		use ReflectionProperty;
9
10		abstract class DataTransferObject
11		{
12		/**
13		* @param array $parameters
14		*
15		* @return \Spatie\DataTransferObject\ImmutableDataTransferObject\|static
16		*/
17		public static function immutable(array $parameters = []): ImmutableDataTransferObject
18		{
19		return new ImmutableDataTransferObject(new static($parameters));
20		}
21
22		/**
23		* @param array $arrayOfParameters
24		*
25		* @return \Spatie\DataTransferObject\ImmutableDataTransferObject[]\|static[]
26		*/
27		public static function arrayOf(array $arrayOfParameters): array
28		{
29		return array_map(
30		function ($parameters) {
31		return new static($parameters);
32		},
33		$arrayOfParameters
34		);
35		}
36
37		public function __construct(array $parameters = [])
38		{
39		$validators = $this->getFieldValidators();
40
41		$valueCaster = $this->getValueCaster();
42
43		/** string[] */
44		$invalidTypes = [];
45
46		foreach ($validators as $field => $validator) {
47		if (
48		! isset($parameters[$field])
49		&& ! $validator->hasDefaultValue
50		&& ! $validator->isNullable
51		) {
52		throw DataTransferObjectError::uninitialized(
53		static::class,
54		$field
55		);
56		}
57
58		$value = $parameters[$field] ?? $this->{$field} ?? null;
59
60		$value = $this->castValue($valueCaster, $validator, $value);
61
62		if (! $validator->isValidType($value)) {
63		$invalidTypes[] = DataTransferObjectError::invalidTypeMessage(
64		static::class,
65		$field,
66		$validator->allowedTypes,
67		$value
68		);
69
70		continue;
71		}
72
73		$this->{$field} = $value;
74
75		unset($parameters[$field]);
76		}
77
78		if ($invalidTypes) {
		0 ignored issues – show Bug Best Practice introduced 2020-09-09 15:21 UTC by Report Bug Copy Issue Report The expression `$invalidTypes` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
79		DataTransferObjectError::invalidTypes($invalidTypes);
80		}
81
82		if (! $this->ignoreMissing() && count($parameters)) {
83		throw DataTransferObjectError::unknownProperties(array_keys($parameters), static::class);
84		}
85		}
86
87		protected function ignoreMissing(): bool
88		{
89		return false;
90		}
91
92	View Code Duplication	public function all(): array
		0 ignored issues – show Duplication introduced 2020-09-09 15:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		{
94		$data = [];
95
96		$class = new ReflectionClass(static::class);
97
98		$properties = $class->getProperties(ReflectionProperty::IS_PUBLIC);
99
100		foreach ($properties as $reflectionProperty) {
101		// Skip static properties
102		if ($reflectionProperty->isStatic()) {
103		continue;
104		}
105
106		$data[$reflectionProperty->getName()] = $reflectionProperty->getValue($this);
107		}
108
109		return $data;
110		}
111
112		public function only(string ...$keys): DataTransferObjectArray
113		{
114		return new DataTransferObjectArray(Arr::only($this->toArray(), $keys));
115		}
116
117		public function except(string ...$keys): DataTransferObjectArray
118		{
119		return new DataTransferObjectArray(Arr::except($this->toArray(), $keys));
120		}
121
122		public function toArray(): array
123		{
124		return $this->parseArray($this->all());
125		}
126
127		protected function parseArray(array $array): array
128		{
129		foreach ($array as $key => $value) {
130		if (
131		$value instanceof DataTransferObject
132		\|\| $value instanceof DataTransferObjectCollection
		0 ignored issues – show Bug introduced 2020-09-09 15:21 UTC by Report Bug Copy Issue Report The class `Spatie\DataTransferObjec...ransferObjectCollection` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
133		) {
134		$array[$key] = $value->toArray();
135
136		continue;
137		}
138
139		if (! is_array($value)) {
140		continue;
141		}
142
143		$array[$key] = $this->parseArray($value);
144		}
145
146		return $array;
147		}
148
149		/**
150		* @param \ReflectionClass $class
		0 ignored issues – show Bug introduced 2019-03-26 17:09 UTC by Report Bug Copy Issue Report There is no parameter named `$class`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
151		*
152		* @return \Spatie\DataTransferObject\FieldValidator[]
153		*/
154		protected function getFieldValidators(): array
155		{
156	View Code Duplication	return DTOCache::resolve(static::class, function () {
		0 ignored issues – show Duplication introduced 2019-12-18 08:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
157		$class = new ReflectionClass(static::class);
158
159		$properties = [];
160
161		foreach ($class->getProperties(ReflectionProperty::IS_PUBLIC) as $reflectionProperty) {
162		// Skip static properties
163		if ($reflectionProperty->isStatic()) {
164		continue;
165		}
166
167		$field = $reflectionProperty->getName();
168
169		$properties[$field] = FieldValidator::fromReflection($reflectionProperty);
170		}
171
172		return $properties;
173		});
174		}
175
176		/**
177		* @param \Spatie\DataTransferObject\ValueCaster $valueCaster
178		* @param \Spatie\DataTransferObject\FieldValidator $fieldValidator
179		* @param mixed $value
180		*
181		* @return mixed
182		*/
183		protected function castValue(ValueCaster $valueCaster, FieldValidator $fieldValidator, $value)
184		{
185		if (is_array($value)) {
186		return $valueCaster->cast($value, $fieldValidator);
187		}
188
189		return $value;
190		}
191
192		protected function getValueCaster(): ValueCaster
193		{
194		return new ValueCaster();
195		}
196		}
197

spatie / data-transfer-object

GitHub Access Token became invalid

Pull Request — master (#141)

DataTransferObject::all() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like