DataTransferObjectDefinition::__construct() - Code Metrics - Inspection of "Support fqcn aliasses" - spatie/data-transfer-object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Brent

created 2018-11-08 09:02 UTC

DataTransferObjectDefinition::__construct() A

↳ Parent: DataTransferObjectDefinition

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Spatie\DataTransferObject;

use ReflectionProperty;
use ReflectionClass as BaseReflectionClass;

class DataTransferObjectDefinition extends BaseReflectionClass
{
    /** @var array */
    protected $uses = [];

    /** @var \Spatie\DataTransferObject\DataTransferObject */
    protected $dataTransferObject;

    public function __construct(DataTransferObject $dataTransferObject)
    {
        parent::__construct($dataTransferObject);

        $this->dataTransferObject = $dataTransferObject;

        $this->resolveUseStatements();
    }

    protected function resolveUseStatements()
    {
        $handle = fopen($this->getFileName(), 'r');

        while ($line = fgets($handle)) {
            $line = trim($line);

            if (strpos($line, 'use ') !== 0) {
                continue;
            }

            $fqcn = str_replace(['use ', ';'], '', $line);

            $classParts = explode('\\', $fqcn);

            $alias = end($classParts);

            $this->uses[$alias] = $fqcn;

            if (strpos($line, 'class') !== false) {
                break;
            }
        }

        fclose($handle);
    }

    public function hasAlias(string $alias): bool
    {
        return isset($this->uses[$alias]);
    }

    public function resolveAlias(string $alias): string
    {
        return $this->uses[$alias];
    }

    /**
     * @return \Spatie\DataTransferObject\DataTransferObjectProperty[]
     */
    public function getDataTransferObjectProperties(): array
    {
        $properties = [];

        foreach (parent::getProperties(ReflectionProperty::IS_PUBLIC) as $reflectionProperty) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            $properties[$reflectionProperty->getName()] = DataTransferObjectProperty::fromReflection(
                $this->dataTransferObject,
                $this,
                $reflectionProperty
            );
        }

        return $properties;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Spatie\DataTransferObject;
6
7			use ReflectionProperty;
8			use ReflectionClass as BaseReflectionClass;
9
10			class DataTransferObjectDefinition extends BaseReflectionClass
11			{
12			/** @var array */
13			protected $uses = [];
14
15			/** @var \Spatie\DataTransferObject\DataTransferObject */
16			protected $dataTransferObject;
17
18			public function __construct(DataTransferObject $dataTransferObject)
19			{
20			parent::__construct($dataTransferObject);
21
22			$this->dataTransferObject = $dataTransferObject;
23
24			$this->resolveUseStatements();
25			}
26
27			protected function resolveUseStatements()
28			{
29			$handle = fopen($this->getFileName(), 'r');
30
31			while ($line = fgets($handle)) {
32			$line = trim($line);
33
34			if (strpos($line, 'use ') !== 0) {
35			continue;
36			}
37
38			$fqcn = str_replace(['use ', ';'], '', $line);
39
40			$classParts = explode('\\', $fqcn);
41
42			$alias = end($classParts);
43
44			$this->uses[$alias] = $fqcn;
45
46			if (strpos($line, 'class') !== false) {
47			break;
48			}
49			}
50
51			fclose($handle);
52			}
53
54			public function hasAlias(string $alias): bool
55			{
56			return isset($this->uses[$alias]);
57			}
58
59			public function resolveAlias(string $alias): string
60			{
61			return $this->uses[$alias];
62			}
63
64			/**
65			* @return \Spatie\DataTransferObject\DataTransferObjectProperty[]
66			*/
67			public function getDataTransferObjectProperties(): array
68			{
69			$properties = [];
70
71			foreach (parent::getProperties(ReflectionProperty::IS_PUBLIC) as $reflectionProperty) {
			0 ignored issues – show Comprehensibility Bug introduced 2018-11-08 08:56 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getProperties()` instead of `getDataTransferObjectProperties()`). Are you sure this is correct? If so, you might want to change this to `$this->getProperties()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
72			$properties[$reflectionProperty->getName()] = DataTransferObjectProperty::fromReflection(
73			$this->dataTransferObject,
74			$this,
75			$reflectionProperty
76			);
77			}
78
79			return $properties;
80			}
81			}
82

spatie / data-transfer-object

GitHub Access Token became invalid

Pull Request — master (#14)

DataTransferObjectDefinition::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like