spatie / code-outliner

src/Elements/Line.php

<?php

namespace Spatie\CodeOutline\Elements;

use Spatie\Typed\Collection;
use Spatie\Typed\T;

class Line extends Collection
{
    public function __construct(int ...$values)
    {
        parent::__construct(T::int());

        $this->set($values);
    }

    public static function make(int $indentationCount, int $characterCount): self
    {
        $indentationValues = array_fill(0, $indentationCount, -1);

        $characterValues = array_fill(0, $characterCount, 1);

        $lineValues = array_merge($indentationValues, $characterValues);

        return new self(...$lineValues);
    }

    public function merge(self $line): self
    {
        $mergedLine = clone $this;

        foreach ($line as $position => $value) {
            $mergedLine[$position] = ($this[$position] ?? 0) + $value;
        }

        return $mergedLine;
    }

    public function getMaximumCharacterPositionDensity(): int
    {
        return $this->count()
            ? max($this->data)
            : 0;
    }

    public function offsetGet($offset): int
    {
        return parent::offsetGet($offset);

The expression return parent::offsetGet($offset) could return the type null which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }
}