Line::make() - Code Metrics - Inspection of "OO(oooh) refactor" - spatie/code-outliner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#8)

by Brent

created 2018-07-23 13:54 UTC

Line::make() A

↳ Parent: Line

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	2
dl	0
loc	9
rs	10
c	0
b	0
f	0

<?php

namespace Spatie\CodeOutline\Elements;

use Spatie\Typed\Collection;
use Spatie\Typed\T;

class Line extends Collection
{
    public function __construct(int ...$values)
    {
        parent::__construct(T::int());

        $this->set($values);
    }

    public static function make(int $indentationCount, int $characterCount): self
    {
        $indentationValues = array_fill(0, $indentationCount, -1);

        $characterValues = array_fill(0, $characterCount, 1);

        $lineValues = array_merge($indentationValues, $characterValues);

        return new self(...$lineValues);
    }

    public function merge(Line $line): Line
    {
        $mergedLine = clone $this;

        foreach ($line as $position => $value) {
            $mergedLine[$position] = ($this[$position] ?? 0) + $value;
        }

        return $mergedLine;
    }

    public function getMaximumCharacterPositionDensity(): int
    {
        return $this->count()
            ? max($this->data)
            : 0;
    }

    public function offsetGet($offset): int
    {
        return parent::offsetGet($offset);

    }
}


1			<?php
2
3			namespace Spatie\CodeOutline\Elements;
4
5			use Spatie\Typed\Collection;
6			use Spatie\Typed\T;
7
8			class Line extends Collection
9			{
10			public function __construct(int ...$values)
11			{
12			parent::__construct(T::int());
13
14			$this->set($values);
15			}
16
17			public static function make(int $indentationCount, int $characterCount): self
18			{
19			$indentationValues = array_fill(0, $indentationCount, -1);
20
21			$characterValues = array_fill(0, $characterCount, 1);
22
23			$lineValues = array_merge($indentationValues, $characterValues);
24
25			return new self(...$lineValues);
26			}
27
28			public function merge(Line $line): Line
29			{
30			$mergedLine = clone $this;
31
32			foreach ($line as $position => $value) {
33			$mergedLine[$position] = ($this[$position] ?? 0) + $value;
34			}
35
36			return $mergedLine;
37			}
38
39			public function getMaximumCharacterPositionDensity(): int
40			{
41			return $this->count()
42			? max($this->data)
43			: 0;
44			}
45
46			public function offsetGet($offset): int
47			{
48			return parent::offsetGet($offset);
			0 ignored issues – show Bug Best Practice introduced 2018-07-20 17:31 UTC by Report Bug Copy Issue Report The expression `return parent::offsetGet($offset)` could return the type `null` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
49			}
50			}
51

spatie / code-outliner

GitHub Access Token became invalid

Pull Request — master (#8)

Line::make() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like