Line::merge() - Code Metrics - Inspection of "OO(oooh) refactor" - spatie/code-outliner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#8)

by Brent

created 2018-07-23 13:52 UTC

Line::merge() A

↳ Parent: Line

Complexity

Conditions	4
Paths	8

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	8
nop	1
dl	0
loc	17
rs	9.9666
c	0
b	0
f	0

<?php

namespace Spatie\CodeOutline\Elements;

use Spatie\Typed\Collection;
use Spatie\Typed\T;

class Line extends Collection
{
    public function __construct(int ...$values)
    {
        parent::__construct(T::int());

        $this->set($values);
    }

    public static function make(int $indentationCount, int $characterCount): self
    {
        $indentationValues = array_fill(0, $indentationCount, -1);

        $characterValues = array_fill(0, $characterCount, 1);

        $lineValues = array_merge($indentationValues, $characterValues);

        return new self(...$lineValues);
    }

    public function merge(Line $line): Line
    {
        $mergedLine = new Line();

        $largestLine = $this->count() > $line->count()
            ? $this
            : $line;

        foreach ($largestLine as $position => $value) {
            $mergedLine[$position] = ($this[$position] ?? 0) + ($line[$position] ?? 0);
        }

        if (! $largestLine->count()) {
            return new EmptyLine();
        }

        return $mergedLine;
    }

    public function getMaximumCharacterPositionDensity(): int
    {
        return $this->count()
            ? max($this->data)
            : 0;
    }

    public function offsetGet($offset): int
    {
        return parent::offsetGet($offset);

    }
}


1			<?php
2
3			namespace Spatie\CodeOutline\Elements;
4
5			use Spatie\Typed\Collection;
6			use Spatie\Typed\T;
7
8			class Line extends Collection
9			{
10			public function __construct(int ...$values)
11			{
12			parent::__construct(T::int());
13
14			$this->set($values);
15			}
16
17			public static function make(int $indentationCount, int $characterCount): self
18			{
19			$indentationValues = array_fill(0, $indentationCount, -1);
20
21			$characterValues = array_fill(0, $characterCount, 1);
22
23			$lineValues = array_merge($indentationValues, $characterValues);
24
25			return new self(...$lineValues);
26			}
27
28			public function merge(Line $line): Line
29			{
30			$mergedLine = new Line();
31
32			$largestLine = $this->count() > $line->count()
33			? $this
34			: $line;
35
36			foreach ($largestLine as $position => $value) {
37			$mergedLine[$position] = ($this[$position] ?? 0) + ($line[$position] ?? 0);
38			}
39
40			if (! $largestLine->count()) {
41			return new EmptyLine();
42			}
43
44			return $mergedLine;
45			}
46
47			public function getMaximumCharacterPositionDensity(): int
48			{
49			return $this->count()
50			? max($this->data)
51			: 0;
52			}
53
54			public function offsetGet($offset): int
55			{
56			return parent::offsetGet($offset);
			0 ignored issues – show Bug Best Practice introduced 2018-07-20 17:31 UTC by Report Bug Copy Issue Report The expression `return parent::offsetGet($offset)` could return the type `null` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
57			}
58			}
59

spatie / code-outliner

GitHub Access Token became invalid

Pull Request — master (#8)

Line::merge() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like