Spatie\Async\Process\ProcessCallbacks

Complexity

Total Complexity

11

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	then()	0	6	1
A	catch()	0	6	1
A	timeout()	0	6	1
A	triggerSuccess()	0	16	3
A	triggerError()	0	12	3
A	triggerTimeout()	0	6	2

<?php

namespace Spatie\Async\Process;

trait ProcessCallbacks
{
    protected $successCallbacks = [];
    protected $errorCallbacks = [];
    protected $timeoutCallbacks = [];

    public function then(callable $callback): self
    {
        $this->successCallbacks[] = $callback;

        return $this;
    }

    public function catch(callable $callback): self

Possible parse error: non-abstract method defined as abstract

It is generally advisable to only define one property per statement.

    {
        $this->errorCallbacks[] = $callback;

        return $this;

The visibility should be declared for property $this.

    }

    public function timeout(callable $callback): self
    {
        $this->timeoutCallbacks[] = $callback;

        return $this;
    }

    public function triggerSuccess()
    {
        if ($this->getErrorOutput()) {

It seems like getErrorOutput() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->triggerError();

            return;
        }

        $output = $this->getOutput();

It seems like getOutput() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($this->successCallbacks as $callback) {
            call_user_func_array($callback, [$output]);
        }

        return $output;
    }

    public function triggerError()
    {
        $exception = $this->resolveErrorOutput();

It seems like resolveErrorOutput() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($this->errorCallbacks as $callback) {
            call_user_func_array($callback, [$exception]);
        }

        if (! $this->errorCallbacks) {
            throw $exception;
        }
    }

    public function triggerTimeout()
    {
        foreach ($this->timeoutCallbacks as $callback) {
            call_user_func_array($callback, []);
        }
    }
}