ArrayToXml - Code Metrics - Inspection of "Fixes #88: Adds numeric array keys support (#94)" - spatie/array-to-xml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e917f0...308de2 )

by Freek

created 2019-05-06 06:27 UTC

ArrayToXml B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	286
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	46
lcom	1
cbo	0
dl	0
loc	286
rs	8.72
c	0
b	0
f	0

14 Methods

Rating	Name	Size	Complexity
A	__construct()	15	3
A	setNumericTagNamePrefix()	4	1
A	convert()	6	1
A	toXml()	4	1
A	toDom()	4	1
C	convertElement()	38	17
A	addNumericNode()	6	2
A	addNode()	10	2
A	addCollectionNode()	12	3
A	addSequentialNode()	12	2
A	isArrayAllKeySequential()	16	4
A	addAttributes()	6	2
B	createRootElement()	22	6
A	removeControlCharacters()	4	1

How to fix Complexity

<?php

namespace Spatie\ArrayToXml;

use DOMElement;
use DOMDocument;
use DOMException;

class ArrayToXml
{
    /**
     * The root DOM Document.
     *
     * @var DOMDocument
     */
    protected $document;

    /**
     * Set to enable replacing space with underscore.
     *
     * @var bool
     */
    protected $replaceSpacesByUnderScoresInKeyNames = true;

    /**
     * Prefix for the tags with numeric names.
     *
     * @var string
     */
    protected $numericTagNamePrefix = 'num_';

    /**
     * Construct a new instance.
     *
     * @param string[] $array
     * @param string|array $rootElement
     * @param bool $replaceSpacesByUnderScoresInKeyNames
     * @param string $xmlEncoding
     * @param string $xmlVersion
     *
     * @throws DOMException
     */
    public function __construct(array $array, $rootElement = '', $replaceSpacesByUnderScoresInKeyNames = true, $xmlEncoding = null, $xmlVersion = '1.0')
    {
        $this->document = new DOMDocument($xmlVersion, $xmlEncoding);
        $this->replaceSpacesByUnderScoresInKeyNames = $replaceSpacesByUnderScoresInKeyNames;

        if ($this->isArrayAllKeySequential($array) && ! empty($array)) {
            throw new DOMException('Invalid Character Error');
        }

        $root = $this->createRootElement($rootElement);

        $this->document->appendChild($root);

        $this->convertElement($root, $array);
    }

    public function setNumericTagNamePrefix(string $prefix)
    {
        $this->numericTagNamePrefix = $prefix;
    }

    /**
     * Convert the given array to an xml string.
     *
     * @param string[] $array
     * @param string|array $rootElement
     * @param bool $replaceSpacesByUnderScoresInKeyNames
     * @param string $xmlEncoding
     * @param string $xmlVersion
     *
     * @return string
     */
    public static function convert(array $array, $rootElement = '', $replaceSpacesByUnderScoresInKeyNames = true, $xmlEncoding = null, $xmlVersion = '1.0')
    {
        $converter = new static($array, $rootElement, $replaceSpacesByUnderScoresInKeyNames, $xmlEncoding, $xmlVersion);

        return $converter->toXml();
    }

    /**
     * Return as XML.
     *
     * @return string
     */
    public function toXml()
    {
        return $this->document->saveXML();
    }

    /**
     * Return as DOM object.
     *
     * @return DOMDocument
     */
    public function toDom()
    {
        return $this->document;
    }

    /**
     * Parse individual element.
     *
     * @param DOMElement $element
     * @param string|string[] $value
     */
    private function convertElement(DOMElement $element, $value)
    {
        $sequential = $this->isArrayAllKeySequential($value);

        if (! is_array($value)) {
            $value = htmlspecialchars($value);

            $value = $this->removeControlCharacters($value);

            $element->nodeValue = $value;

            return;
        }

        foreach ($value as $key => $data) {
            if (! $sequential) {
                if (($key === '_attributes') || ($key === '@attributes')) {
                    $this->addAttributes($element, $data);
                } elseif ((($key === '_value') || ($key === '@value')) && is_string($data)) {
                    $element->nodeValue = htmlspecialchars($data);
                } elseif ((($key === '_cdata') || ($key === '@cdata')) && is_string($data)) {
                    $element->appendChild($this->document->createCDATASection($data));
                } elseif ((($key === '_mixed') || ($key === '@mixed')) && is_string($data)) {
                    $fragment = $this->document->createDocumentFragment();
                    $fragment->appendXML($data);
                    $element->appendChild($fragment);
                } elseif ($key === '__numeric') {
                    $this->addNumericNode($element, $data);
                } else {
                    $this->addNode($element, $key, $data);
                }
            } elseif (is_array($data)) {
                $this->addCollectionNode($element, $data);
            } else {
                $this->addSequentialNode($element, $data);
            }
        }
    }

    /**
     * Add node with numeric keys.
     *
     * @param DOMElement $element
     * @param string|string[] $value
     */
    protected function addNumericNode(DOMElement $element, $value)
    {
        foreach ($value as $key => $item) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->convertElement($element, [$this->numericTagNamePrefix.$key => $value]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    /**
     * Add node.
     *
     * @param DOMElement $element
     * @param string $key
     * @param string|string[] $value
     */
    protected function addNode(DOMElement $element, $key, $value)
    {
        if ($this->replaceSpacesByUnderScoresInKeyNames) {
            $key = str_replace(' ', '_', $key);
        }

        $child = $this->document->createElement($key);
        $element->appendChild($child);
        $this->convertElement($child, $value);
    }

    /**
     * Add collection node.
     *
     * @param DOMElement $element
     * @param string|string[] $value
     *
     * @internal param string $key
     */
    protected function addCollectionNode(DOMElement $element, $value)
    {
        if ($element->childNodes->length === 0 && $element->attributes->length === 0) {

            $this->convertElement($element, $value);

            return;
        }

        $child = $this->document->createElement($element->tagName);
        $element->parentNode->appendChild($child);
        $this->convertElement($child, $value);
    }

    /**
     * Add sequential node.
     *
     * @param DOMElement $element
     * @param string|string[] $value
     *
     * @internal param string $key
     */
    protected function addSequentialNode(DOMElement $element, $value)
    {
        if (empty($element->nodeValue)) {
            $element->nodeValue = htmlspecialchars($value);

            return;
        }

        $child = new DOMElement($element->tagName);
        $child->nodeValue = htmlspecialchars($value);
        $element->parentNode->appendChild($child);
    }

    /**
     * Check if array are all sequential.
     *
     * @param array|string $value
     *
     * @return bool
     */
    protected function isArrayAllKeySequential($value)
    {
        if (! is_array($value)) {
            return false;
        }

        if (count($value) <= 0) {
            return true;
        }

        if (\key($value) === '__numeric') {
            return false;
        }

        return array_unique(array_map('is_int', array_keys($value))) === [true];
    }

    /**
     * Add attributes.
     *
     * @param DOMElement $element
     * @param string[] $data
     */
    protected function addAttributes($element, $data)
    {
        foreach ($data as $attrKey => $attrVal) {
            $element->setAttribute($attrKey, $attrVal);
        }
    }

    /**
     * Create the root element.
     *
     * @param  string|array $rootElement
     * @return DOMElement
     */
    protected function createRootElement($rootElement)
    {
        if (is_string($rootElement)) {
            $rootElementName = $rootElement ?: 'root';

            return $this->document->createElement($rootElementName);
        }

        $rootElementName = $rootElement['rootElementName'] ?? 'root';

        $element = $this->document->createElement($rootElementName);

        foreach ($rootElement as $key => $value) {
            if ($key !== '_attributes' && $key !== '@attributes') {
                continue;
            }

            $this->addAttributes($element, $rootElement[$key]);
        }

        return $element;
    }

    /**
     * @param $valuet
     * @return string
     */
    protected function removeControlCharacters($value)
    {
        return preg_replace('/[\x00-\x09\x0B\x0C\x0E-\x1F\x7F]/', '', $value);
    }
}


GitHub Access Token became invalid

Push — master ( e917f0...308de2 )

ArrayToXml B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Complexity

Complex Class

1			<?php
2
3			namespace Spatie\ArrayToXml;
4
5			use DOMElement;
6			use DOMDocument;
7			use DOMException;
8
9			class ArrayToXml
10			{
11			/**
12			* The root DOM Document.
13			*
14			* @var DOMDocument
15			*/
16			protected $document;
17
18			/**
19			* Set to enable replacing space with underscore.
20			*
21			* @var bool
22			*/
23			protected $replaceSpacesByUnderScoresInKeyNames = true;
24
25			/**
26			* Prefix for the tags with numeric names.
27			*
28			* @var string
29			*/
30			protected $numericTagNamePrefix = 'num_';
31
32			/**
33			* Construct a new instance.
34			*
35			* @param string[] $array
36			* @param string\|array $rootElement
37			* @param bool $replaceSpacesByUnderScoresInKeyNames
38			* @param string $xmlEncoding
39			* @param string $xmlVersion
40			*
41			* @throws DOMException
42			*/
43			public function __construct(array $array, $rootElement = '', $replaceSpacesByUnderScoresInKeyNames = true, $xmlEncoding = null, $xmlVersion = '1.0')
44			{
45			$this->document = new DOMDocument($xmlVersion, $xmlEncoding);
46			$this->replaceSpacesByUnderScoresInKeyNames = $replaceSpacesByUnderScoresInKeyNames;
47
48			if ($this->isArrayAllKeySequential($array) && ! empty($array)) {
49			throw new DOMException('Invalid Character Error');
50			}
51
52			$root = $this->createRootElement($rootElement);
53
54			$this->document->appendChild($root);
55
56			$this->convertElement($root, $array);
57			}
58
59			public function setNumericTagNamePrefix(string $prefix)
60			{
61			$this->numericTagNamePrefix = $prefix;
62			}
63
64			/**
65			* Convert the given array to an xml string.
66			*
67			* @param string[] $array
68			* @param string\|array $rootElement
69			* @param bool $replaceSpacesByUnderScoresInKeyNames
70			* @param string $xmlEncoding
71			* @param string $xmlVersion
72			*
73			* @return string
74			*/
75			public static function convert(array $array, $rootElement = '', $replaceSpacesByUnderScoresInKeyNames = true, $xmlEncoding = null, $xmlVersion = '1.0')
76			{
77			$converter = new static($array, $rootElement, $replaceSpacesByUnderScoresInKeyNames, $xmlEncoding, $xmlVersion);
78
79			return $converter->toXml();
80			}
81
82			/**
83			* Return as XML.
84			*
85			* @return string
86			*/
87			public function toXml()
88			{
89			return $this->document->saveXML();
90			}
91
92			/**
93			* Return as DOM object.
94			*
95			* @return DOMDocument
96			*/
97			public function toDom()
98			{
99			return $this->document;
100			}
101
102			/**
103			* Parse individual element.
104			*
105			* @param DOMElement $element
106			* @param string\|string[] $value
107			*/
108			private function convertElement(DOMElement $element, $value)
109			{
110			$sequential = $this->isArrayAllKeySequential($value);
111
112			if (! is_array($value)) {
113			$value = htmlspecialchars($value);
114
115			$value = $this->removeControlCharacters($value);
116
117			$element->nodeValue = $value;
118
119			return;
120			}
121
122			foreach ($value as $key => $data) {
123			if (! $sequential) {
124			if (($key === '_attributes') \|\| ($key === '@attributes')) {
125			$this->addAttributes($element, $data);
126			} elseif ((($key === '_value') \|\| ($key === '@value')) && is_string($data)) {
127			$element->nodeValue = htmlspecialchars($data);
128			} elseif ((($key === '_cdata') \|\| ($key === '@cdata')) && is_string($data)) {
129			$element->appendChild($this->document->createCDATASection($data));
130			} elseif ((($key === '_mixed') \|\| ($key === '@mixed')) && is_string($data)) {
131			$fragment = $this->document->createDocumentFragment();
132			$fragment->appendXML($data);
133			$element->appendChild($fragment);
134			} elseif ($key === '__numeric') {
135			$this->addNumericNode($element, $data);
136			} else {
137			$this->addNode($element, $key, $data);
138			}
139			} elseif (is_array($data)) {
140			$this->addCollectionNode($element, $data);
141			} else {
142			$this->addSequentialNode($element, $data);
143			}
144			}
145			}
146
147			/**
148			* Add node with numeric keys.
149			*
150			* @param DOMElement $element
151			* @param string\|string[] $value
152			*/
153			protected function addNumericNode(DOMElement $element, $value)
154			{
155			foreach ($value as $key => $item) {
			0 ignored issues – show Bug introduced 2019-04-30 12:02 UTC by Report Bug Copy Issue Report The expression `$value` of type `string\|array<integer,string>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
156			$this->convertElement($element, [$this->numericTagNamePrefix.$key => $value]);
			0 ignored issues – show Documentation introduced 2019-04-30 12:02 UTC by Report Bug Copy Issue Report `array($this->numericTagN...refix . $key => $value)` is of type `array<string,string\|array<integer,string>>`, but the function expects a `string\|array<integer,string>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
157			}
158			}
159
160			/**
161			* Add node.
162			*
163			* @param DOMElement $element
164			* @param string $key
165			* @param string\|string[] $value
166			*/
167			protected function addNode(DOMElement $element, $key, $value)
168			{
169			if ($this->replaceSpacesByUnderScoresInKeyNames) {
170			$key = str_replace(' ', '_', $key);
171			}
172
173			$child = $this->document->createElement($key);
174			$element->appendChild($child);
175			$this->convertElement($child, $value);
176			}
177
178			/**
179			* Add collection node.
180			*
181			* @param DOMElement $element
182			* @param string\|string[] $value
183			*
184			* @internal param string $key
185			*/
186			protected function addCollectionNode(DOMElement $element, $value)
187			{
188			if ($element->childNodes->length === 0 && $element->attributes->length === 0) {
			0 ignored issues – show Bug introduced 2017-08-27 15:06 UTC by Report Bug Copy Issue Report The property `length` does not seem to exist in `DOMNamedNodeMap`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
189			$this->convertElement($element, $value);
190
191			return;
192			}
193
194			$child = $this->document->createElement($element->tagName);
195			$element->parentNode->appendChild($child);
196			$this->convertElement($child, $value);
197			}
198
199			/**
200			* Add sequential node.
201			*
202			* @param DOMElement $element
203			* @param string\|string[] $value
204			*
205			* @internal param string $key
206			*/
207			protected function addSequentialNode(DOMElement $element, $value)
208			{
209			if (empty($element->nodeValue)) {
210			$element->nodeValue = htmlspecialchars($value);
211
212			return;
213			}
214
215			$child = new DOMElement($element->tagName);
216			$child->nodeValue = htmlspecialchars($value);
217			$element->parentNode->appendChild($child);
218			}
219
220			/**
221			* Check if array are all sequential.
222			*
223			* @param array\|string $value
224			*
225			* @return bool
226			*/
227			protected function isArrayAllKeySequential($value)
228			{
229			if (! is_array($value)) {
230			return false;
231			}
232
233			if (count($value) <= 0) {
234			return true;
235			}
236
237			if (\key($value) === '__numeric') {
238			return false;
239			}
240
241			return array_unique(array_map('is_int', array_keys($value))) === [true];
242			}
243
244			/**
245			* Add attributes.
246			*
247			* @param DOMElement $element
248			* @param string[] $data
249			*/
250			protected function addAttributes($element, $data)
251			{
252			foreach ($data as $attrKey => $attrVal) {
253			$element->setAttribute($attrKey, $attrVal);
254			}
255			}
256
257			/**
258			* Create the root element.
259			*
260			* @param string\|array $rootElement
261			* @return DOMElement
262			*/
263			protected function createRootElement($rootElement)
264			{
265			if (is_string($rootElement)) {
266			$rootElementName = $rootElement ?: 'root';
267
268			return $this->document->createElement($rootElementName);
269			}
270
271			$rootElementName = $rootElement['rootElementName'] ?? 'root';
272
273			$element = $this->document->createElement($rootElementName);
274
275			foreach ($rootElement as $key => $value) {
276			if ($key !== '_attributes' && $key !== '@attributes') {
277			continue;
278			}
279
280			$this->addAttributes($element, $rootElement[$key]);
281			}
282
283			return $element;
284			}
285
286			/**
287			* @param $valuet
288			* @return string
289			*/
290			protected function removeControlCharacters($value)
291			{
292			return preg_replace('/[\x00-\x09\x0B\x0C\x0E-\x1F\x7F]/', '', $value);
293			}
294			}
295

spatie / array-to-xml

GitHub Access Token became invalid

Push — master ( e917f0...308de2 )

ArrayToXml B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like