Issues in HtmlBuilder.php (master) - Issues in master - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Issues (161)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Services/Html/HtmlBuilder.php (3 issues)

Labels

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Services\Html;

use Form;
use Session;
use App\Services\Auth\User;
use Collective\Html\HtmlBuilder as BaseHtmlBuilder;

class HtmlBuilder extends BaseHtmlBuilder
{
    public function flashMessage(): string
    {
        if (! Session::has('flash_notification.message')) {
            return '';
        }

        $level = Session::get('flash_notification.level');

        return el("div.alert.-{$level}", Session::get('flash_notification.message'));
    }

    public function error($message, $name = ''): string
    {
        if (empty($message) && empty($name)) {
            return '';
        }

        $attributes = empty($name) ? [] : ['data-validation-error' => $name];

        return el(
            'div.alert.-danger',
            $attributes,
            $message
        );
    }

    public function message($message, string $classes = ''): string
    {
        if (empty($message)) {
            return '';
        }

        return el('div.alert.-success', ['class' => $classes], $message);
    }

    public function info($message, string $classes = ''): string

    {
        if (empty($message)) {
            return '';
        }

        return el(
            'div.alert.-info',
            ['class' => $classes],
            el('span.fa.fa-info-circle').' '.$message
        );
    }

    public function warning($message, string $classes = ''): string

    {
        if (empty($message)) {
            return '';
        }

        return el(
            'div.alert.-warning',
            ['class' => $classes],
            el('span.fa.fa-exclamation-triangle').' '.$message
        );
    }

    public function avatar(User $user, string $classes = ''): string
    {
        return el('span.avatar', [
            'class' => $classes,
            'style' => "background-image: url('{$user->avatar}')",
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        ], '');
    }

    public function deleteButton(string $url): string
    {
        return Form::openButton(
            [
                'url' => $url,
                'method' => 'delete',
            ],
            [
                'class' => 'button--delete-row',
            ]
        ).el('span.fa.fa-trash').Form::closeButton();
    }

    public function onlineIndicator(bool $online): string
    {
        $state = $online ? 'on' : 'off';
        $icon = $online ? 'circle' : 'circle-o';
        $title = $online ? 'Online' : 'Offline';

        return el(
            "span.status.-{$state}",
            ['title' => $title],
            el("i.fa.fa-{$icon}")
        );
    }

    public function backToIndex(string $action, array $parameters = []): string
    {
        return el('a.breadcrumb--back', ['href' => action($action, $parameters)], fragment('back.backToIndex'));
    }
}


1		<?php
2
3		namespace App\Services\Html;
4
5		use Form;
6		use Session;
7		use App\Services\Auth\User;
8		use Collective\Html\HtmlBuilder as BaseHtmlBuilder;
9
10		class HtmlBuilder extends BaseHtmlBuilder
11		{
12		public function flashMessage(): string
13		{
14		if (! Session::has('flash_notification.message')) {
15		return '';
16		}
17
18		$level = Session::get('flash_notification.level');
19
20		return el("div.alert.-{$level}", Session::get('flash_notification.message'));
21		}
22
23		public function error($message, $name = ''): string
24		{
25		if (empty($message) && empty($name)) {
26		return '';
27		}
28
29		$attributes = empty($name) ? [] : ['data-validation-error' => $name];
30
31		return el(
32		'div.alert.-danger',
33		$attributes,
34		$message
35		);
36		}
37
38		public function message($message, string $classes = ''): string
39		{
40		if (empty($message)) {
41		return '';
42		}
43
44		return el('div.alert.-success', ['class' => $classes], $message);
45		}
46
47	View Code Duplication	public function info($message, string $classes = ''): string
		0 ignored issues – show Duplication introduced 2016-08-30 10:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		{
49		if (empty($message)) {
50		return '';
51		}
52
53		return el(
54		'div.alert.-info',
55		['class' => $classes],
56		el('span.fa.fa-info-circle').' '.$message
57		);
58		}
59
60	View Code Duplication	public function warning($message, string $classes = ''): string
		0 ignored issues – show Duplication introduced 2016-08-30 10:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		if (empty($message)) {
63		return '';
64		}
65
66		return el(
67		'div.alert.-warning',
68		['class' => $classes],
69		el('span.fa.fa-exclamation-triangle').' '.$message
70		);
71		}
72
73		public function avatar(User $user, string $classes = ''): string
74		{
75		return el('span.avatar', [
76		'class' => $classes,
77		'style' => "background-image: url('{$user->avatar}')",
		0 ignored issues – show Documentation introduced 2016-08-27 00:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `avatar` does not exist on `object<App\Services\Auth\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
78		], '');
79		}
80
81		public function deleteButton(string $url): string
82		{
83		return Form::openButton(
84		[
85		'url' => $url,
86		'method' => 'delete',
87		],
88		[
89		'class' => 'button--delete-row',
90		]
91		).el('span.fa.fa-trash').Form::closeButton();
92		}
93
94		public function onlineIndicator(bool $online): string
95		{
96		$state = $online ? 'on' : 'off';
97		$icon = $online ? 'circle' : 'circle-o';
98		$title = $online ? 'Online' : 'Offline';
99
100		return el(
101		"span.status.-{$state}",
102		['title' => $title],
103		el("i.fa.fa-{$icon}")
104		);
105		}
106
107		public function backToIndex(string $action, array $parameters = []): string
108		{
109		return el('a.breadcrumb--back', ['href' => action($action, $parameters)], fragment('back.backToIndex'));
110		}
111		}
112

spatie-custom / blender

Issues (161)

Security Analysis not enabled

app/Services/Html/HtmlBuilder.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like