ContentBlockRequest - Code Metrics - Inspection of "Feature content blocks (#139)" - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d58309...398f96 )

by Sebastian

created 2017-01-10 16:43 UTC

ContentBlockRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
dl	18
loc	18
rs	10
c	0
b	0
f	0
wmc	2
lcom	0
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	10	10	1
A	failedValidation()	4	4	1

How to fix Duplicated Code

<?php

namespace App\Http\Requests\Back;

use App\Http\Requests\Request;
use Illuminate\Contracts\Validation\Validator;

class ContentBlockRequest extends Request

{
    public function rules(): array
    {
        return [
            'model_name' => 'required',
            'model_id' => 'required',
            'collection_name' => 'required',
        ];

        return $rules;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    protected function failedValidation(Validator $validator)
    {
        return response()->json($validator->messages(), 400);
    }
}


1		<?php
2
3		namespace App\Http\Requests\Back;
4
5		use App\Http\Requests\Request;
6		use Illuminate\Contracts\Validation\Validator;
7
8	View Code Duplication	class ContentBlockRequest extends Request
		0 ignored issues – show Duplication introduced 2016-12-20 11:07 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		public function rules(): array
11		{
12		return [
13		'model_name' => 'required',
14		'model_id' => 'required',
15		'collection_name' => 'required',
16		];
17
18		return $rules;
		0 ignored issues – show Unused Code introduced 2016-12-20 11:07 UTC by Report Bug Copy Issue Report `return $rules;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
19		}
20
21		protected function failedValidation(Validator $validator)
22		{
23		return response()->json($validator->messages(), 400);
24		}
25		}
26

spatie-custom / blender

Push — master ( d58309...398f96 )

ContentBlockRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like