App\Http\Controllers\Back\MembersController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	102
Duplicated Lines	25.49 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	6	1
A	create()	0	4	1
A	store()	0	22	1
A	edit()	0	10	2
A	update()	0	17	1
A	destroy()	12	12	1
A	getEventDescriptionFor()	14	14	2

<?php

namespace App\Http\Controllers\Back;

use App\Services\Auth\Front\Enums\UserRole;
use App\Services\Auth\Front\Enums\UserStatus;
use App\Services\Auth\Front\Events\UserCreatedThroughBack;
use App\Http\Requests\Back\FrontUserRequest;
use App\Services\Auth\Front\User;
use App\Services\Auth\Front\UserUpdater;
use App\Repositories\FrontUserRepository;

class MembersController
{
    /** @var \App\Repositories\FrontUserRepository */
    protected $frontUserRepository;

    public function __construct(FrontUserRepository $frontUserRepository)
    {
        $this->frontUserRepository = $frontUserRepository;
    }

    public function index()
    {
        $users = $this->frontUserRepository->getAll();

        return view('back.members.index')->with(compact('users'));

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

    }

    public function create()
    {
        return view('back.members.create', ['user' => new User()]);
    }

    public function store(FrontUserRequest $request)
    {
        $user = new User();

        $user->email = $request->get('email');
        $user->first_name = $request->get('first_name');
        $user->last_name = $request->get('last_name');
        $user->locale = $request->get('locale', 'nl');

        $user->role = UserRole::MEMBER();
        $user->status = UserStatus::ACTIVE();

        $this->frontUserRepository->save($user);

        $eventDescription = $this->getEventDescriptionFor('created', $user);
        activity($eventDescription);
        flash()->success(strip_tags($eventDescription).'. '.fragment('back.members.passwordMailSent'));

        event(new UserCreatedThroughBack($user));

        return redirect()->action('Back\MembersController@index');
    }

    public function edit($id)
    {
        $user = $this->frontUserRepository->find($id);

        if (!$user) {
            abort(404);
        }

        return view('back.members.edit')->with(compact('user'));

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

    }

    public function update($id, FrontUserRequest $request)
    {
        abort_unless($user = $this->frontUserRepository->find($id), 500);

$user = $this->frontUserRepository->find($id) is of type object<Illuminate\Database\Eloquent\Model>|null, but the function expects a boolean.

        $user->email = $request->get('email');
        $user->first_name = $request->get('first_name');
        $user->last_name = $request->get('last_name');
        $user->locale = $request->get('locale', 'nl');

        $this->frontUserRepository->save($user);

        $eventDescription = $this->getEventDescriptionFor('updated', $user);
        activity()->on($user)->log($eventDescription);
        flash()->success(strip_tags($eventDescription));

        return redirect()->action('Back\MembersController@index');
    }

    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $user = $this->frontUserRepository->find($id);

        $this->frontUserRepository->delete($user);

It seems like $user defined by $this->frontUserRepository->find($id) on line 89 can be null; however, App\Foundation\Repositories\Repository::delete() does not accept null, maybe add an additional type check?

        $eventDescription = $this->getEventDescriptionFor('deleted', $user);

It seems like $user defined by $this->frontUserRepository->find($id) on line 89 can be null; however, App\Http\Controllers\Back\MembersController::getEventDescriptionFor() does not accept null, maybe add an additional type check?

        activity()->log($eventDescription);
        flash()->success(strip_tags($eventDescription));

        return redirect()->action('Back\MembersController@index');
    }

    protected function getEventDescriptionFor(string $event, User $user): string

This method seems to be duplicated in your project.

    {
        $name = sprintf(
            '<a href="%s">%s</a>',
            action('Back\MembersController@edit', [$user->id]),
            $user->email
        );

        if ($event === 'deleted') {
            $name = $user->email;
        }

        return trans("back.events.$event", ['model' => fragment('back.members.member'), 'name' => $name]);
    }
}