Article::findByTechnicalName() - Code Metrics - Inspection of "CS fix" - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 704c19...051415 )

by Sebastian

created 2016-05-31 16:20 UTC

Article::findByTechnicalName() A

↳ Parent: Article

Complexity

Conditions	2
Paths	1

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	1
nop	1
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0

<?php

namespace app\Models;

use App\Foundation\Models\Base\ModuleModel;
use App\Foundation\Models\Traits\HasSlug;
use Cache;
use Exception;
use Illuminate\Support\Collection;

class Article extends ModuleModel
{
    use HasSlug;

    protected $with = ['media'];

    public $mediaLibraryCollections = ['images', 'downloads'];
    public $translatable = ['name', 'text', 'url'];

    public static function findByTechnicalName(string $technicalName): Article
    {
        return Cache::rememberForever(
            "article.findByTechnicalName.{$technicalName}",
            function () use ($technicalName): Article {
                $article = static::where('technical_name', $technicalName)->first();

                if ($article === null) {
                    throw new Exception("Article `{$technicalName}` not found");
                }

                return $article;
            }
        );
    }

    public static function getWithTechnicalNameLike(string $technicalName): Collection
    {
        return Cache::rememberForever(
            "article.getWithTechnicalNameLike.{$technicalName}",
            function () use ($technicalName): Collection {
                return static::where('technical_name', 'like', "{$technicalName}.%")
                    ->orderBy('order_column')
                    ->get();
            }
        );
    }

    public function isDeletable(): bool
    {
        return !(bool) $this->technical_name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace app\Models;
4
5			use App\Foundation\Models\Base\ModuleModel;
6			use App\Foundation\Models\Traits\HasSlug;
7			use Cache;
8			use Exception;
9			use Illuminate\Support\Collection;
10
11			class Article extends ModuleModel
12			{
13			use HasSlug;
14
15			protected $with = ['media'];
16
17			public $mediaLibraryCollections = ['images', 'downloads'];
18			public $translatable = ['name', 'text', 'url'];
19
20			public static function findByTechnicalName(string $technicalName): Article
21			{
22			return Cache::rememberForever(
23			"article.findByTechnicalName.{$technicalName}",
24			function () use ($technicalName): Article {
25			$article = static::where('technical_name', $technicalName)->first();
26
27			if ($article === null) {
28			throw new Exception("Article `{$technicalName}` not found");
29			}
30
31			return $article;
32			}
33			);
34			}
35
36			public static function getWithTechnicalNameLike(string $technicalName): Collection
37			{
38			return Cache::rememberForever(
39			"article.getWithTechnicalNameLike.{$technicalName}",
40			function () use ($technicalName): Collection {
41			return static::where('technical_name', 'like', "{$technicalName}.%")
42			->orderBy('order_column')
43			->get();
44			}
45			);
46			}
47
48			public function isDeletable(): bool
49			{
50			return !(bool) $this->technical_name;
			0 ignored issues – show Documentation introduced 2016-05-31 16:25 UTC by Report Bug Copy Issue Report The property `technical_name` does not exist on `object<app\Models\Article>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51			}
52			}
53

spatie-custom / blender

Push — master ( 704c19...051415 )

Article::findByTechnicalName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like