FragmentsController::update() - Code Metrics - Inspection of "Autumn cleanup" - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#79)

by Sebastian

created 2016-10-18 11:37 UTC

FragmentsController::update() A

↳ Parent: FragmentsController

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	10
nc	2
nop	2
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Http\Controllers\Back;

use App\Http\Requests\Back\FragmentRequest;
use App\Models\Fragment;
use Spatie\FragmentImporter\Exporter;

class FragmentsController
{
    public function index()
    {
        $fragments = Fragment::where('hidden', false)->get();

        return view('back.fragments.index')->with(compact('fragments'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function hidden()
    {
        $fragments = Fragment::where('hidden', true)->get();

        return view('back.fragments.index')->with(compact('fragments'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function create()
    {
        $fragment = new Fragment();
        $fragment->save();

        return redirect()->action('Back\FragmentsController@edit', [$fragment->id]);
    }

    public function edit($id)
    {
        $fragment = Fragment::find($id);

        return view('back.fragments.edit')->with(compact('fragment'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function update($id, FragmentRequest $request)
    {
        $fragment = Fragment::find($id);

        foreach (locales() as $locale) {
            $requestAttribute = "translated_{$locale}_text";

            $fragment->setTranslation($locale, $request->get($requestAttribute));
        }

        $fragment->save();
        app('cache')->flush();

        $eventDescription = fragment('back.events.updated', ['model' => 'Fragment', 'name' => $fragment->name]);

        flash()->success(strip_tags($eventDescription));

        return redirect()->action('Back\FragmentsController@index');
    }

    public function download()
    {
        Exporter::sendExportToBrowser();
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Back;
4
5			use App\Http\Requests\Back\FragmentRequest;
6			use App\Models\Fragment;
7			use Spatie\FragmentImporter\Exporter;
8
9			class FragmentsController
10			{
11			public function index()
12			{
13			$fragments = Fragment::where('hidden', false)->get();
14
15			return view('back.fragments.index')->with(compact('fragments'));
			0 ignored issues – show Bug introduced 2016-10-18 11:00 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
16			}
17
18			public function hidden()
19			{
20			$fragments = Fragment::where('hidden', true)->get();
21
22			return view('back.fragments.index')->with(compact('fragments'));
			0 ignored issues – show Bug introduced 2015-11-23 22:38 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23			}
24
25			public function create()
26			{
27			$fragment = new Fragment();
28			$fragment->save();
29
30			return redirect()->action('Back\FragmentsController@edit', [$fragment->id]);
31			}
32
33			public function edit($id)
34			{
35			$fragment = Fragment::find($id);
36
37			return view('back.fragments.edit')->with(compact('fragment'));
			0 ignored issues – show Bug introduced 2015-11-23 22:38 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38			}
39
40			public function update($id, FragmentRequest $request)
41			{
42			$fragment = Fragment::find($id);
43
44			foreach (locales() as $locale) {
45			$requestAttribute = "translated_{$locale}_text";
46
47			$fragment->setTranslation($locale, $request->get($requestAttribute));
48			}
49
50			$fragment->save();
51			app('cache')->flush();
52
53			$eventDescription = fragment('back.events.updated', ['model' => 'Fragment', 'name' => $fragment->name]);
54
55			flash()->success(strip_tags($eventDescription));
56
57			return redirect()->action('Back\FragmentsController@index');
58			}
59
60			public function download()
61			{
62			Exporter::sendExportToBrowser();
63			}
64			}
65

spatie-custom / blender

Pull Request — master (#79)

FragmentsController::update() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like