Completed
Pull Request — master (#47)
by Chris
03:39
created
app/Services/Html/HtmlServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
      */
32 32
     protected function registerHtmlBuilder()
33 33
     {
34
-        $this->app->singleton('html', function ($app) {
34
+        $this->app->singleton('html', function($app) {
35 35
             return new HtmlBuilder($app['url']);
36 36
         });
37 37
     }
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
      */
42 42
     protected function registerFormBuilder()
43 43
     {
44
-        $this->app->singleton('form', function ($app) {
44
+        $this->app->singleton('form', function($app) {
45 45
             $formBuilder = new FormBuilder($app['html'], $app['url'], $app['session.store']->getToken());
46 46
 
47 47
             $formBuilder->setSessionStore($app['session.store']);
Please login to merge, or discard this patch.
app/Http/Requests/Request.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
     /**
36 36
      * Get a parameter of the current route.
37 37
      *
38
-     * @param $key
38
+     * @param string $key
39 39
      *
40 40
      * @return object|string
41 41
      */
Please login to merge, or discard this patch.
app/Http/Controllers/Front/AuthController.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@
 block discarded – undo
38 38
         return fragment('auth.failed');
39 39
     }
40 40
 
41
+    /**
42
+     * @param Request $request
43
+     */
41 44
     protected function sendInactiveAccountResponse($request)
42 45
     {
43 46
         return redirect()->back()
Please login to merge, or discard this patch.
app/Http/Routes/front_auth.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-Route::group(['middleware' => 'guest'], function () {
3
+Route::group(['middleware' => 'guest'], function() {
4 4
 
5 5
     Route::get('login', 'AuthController@getLogin');
6 6
     Route::post('login', 'AuthController@postLogin');
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     Route::get('password/reset/{token}', 'PasswordController@getReset');
11 11
     Route::post('password/reset/{token}', 'PasswordController@postReset');
12 12
 
13
-    Route::get('password', function () {
13
+    Route::get('password', function() {
14 14
         return redirect()->action('PasswordController@getEmail');
15 15
     });
16 16
 });
Please login to merge, or discard this patch.
app/Providers/RouteServiceProvider.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -21,14 +21,14 @@  discard block
 block discarded – undo
21 21
 
22 22
     public function map(Router $router)
23 23
     {
24
-        $router->group(['namespace' => $this->namespace], function () {
24
+        $router->group(['namespace' => $this->namespace], function() {
25 25
             require app_path('Http/Routes/routes.php');
26 26
         });
27 27
     }
28 28
 
29 29
     protected function registerMacros(Router $router)
30 30
     {
31
-        $router->macro('module', function ($slug, $className, $sortable = false) use ($router) {
31
+        $router->macro('module', function($slug, $className, $sortable = false) use ($router) {
32 32
             if ($sortable) {
33 33
                 $router->patch("{$slug}/changeOrder", "{$className}Controller@changeOrder");
34 34
             }
@@ -36,15 +36,15 @@  discard block
 block discarded – undo
36 36
             $router->resource($slug, "{$className}Controller");
37 37
         });
38 38
 
39
-        $router->macro('articleList', function ($technicalNamePrefix, $action) use ($router) {
39
+        $router->macro('articleList', function($technicalNamePrefix, $action) use ($router) {
40 40
 
41 41
             $articles = Article::getWithTechnicalNameLike($technicalNamePrefix);
42 42
 
43
-            $router->get(app()->getLocale().'/'.fragment_slug("navigation.{$technicalNamePrefix}"),  function () use ($articles) {
43
+            $router->get(app()->getLocale().'/'.fragment_slug("navigation.{$technicalNamePrefix}"), function() use ($articles) {
44 44
                 return redirect(route("{$articles->first()->technical_name}"));
45 45
             })->name($technicalNamePrefix);
46 46
 
47
-            $articles->map(function ($article) use ($technicalNamePrefix, $action, $router) {
47
+            $articles->map(function($article) use ($technicalNamePrefix, $action, $router) {
48 48
                 $router->get(app()->getLocale().'/'.fragment_slug("navigation.{$technicalNamePrefix}").'/'.$article->url, $action)->name("{$article->technical_name}");
49 49
             });
50 50
         });
Please login to merge, or discard this patch.
app/Http/Controllers/Back/AuthController.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@
 block discarded – undo
38 38
         return fragment('auth.failed');
39 39
     }
40 40
 
41
+    /**
42
+     * @param Request $request
43
+     */
41 44
     protected function sendInactiveAccountResponse($request)
42 45
     {
43 46
         return redirect()->back()
Please login to merge, or discard this patch.
app/Http/Routes/back_auth.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-Route::group(['middleware' => 'guest'], function () {
3
+Route::group(['middleware' => 'guest'], function() {
4 4
 
5 5
     Route::get('login', 'AuthController@getLogin');
6 6
     Route::post('login', 'AuthController@postLogin');
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     Route::get('password/reset/{token}', 'PasswordController@getReset');
11 11
     Route::post('password/reset/{token}', 'PasswordController@postReset');
12 12
 
13
-    Route::get('password', function () {
13
+    Route::get('password', function() {
14 14
         return redirect()->action('PasswordController@getEmail');
15 15
     });
16 16
 });
Please login to merge, or discard this patch.
app/Providers/ValidationServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
     public function boot()
16 16
     {
17
-        Validator::extend('tags_exist', function ($attribute, $tagNames, $parameters) {
17
+        Validator::extend('tags_exist', function($attribute, $tagNames, $parameters) {
18 18
             list($tagType) = $parameters;
19 19
             $tagType = new TagType($tagType);
20 20
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
             return true;
31 31
         });
32 32
 
33
-        Validator::extend('enum', function ($attribute, $value, $parameters) {
33
+        Validator::extend('enum', function($attribute, $value, $parameters) {
34 34
 
35 35
             /** @var \App\Foundation\Models\Enums\Enum $class */
36 36
             $class = $parameters[0];
Please login to merge, or discard this patch.
app/Services/Navigation/Breadcrumbs/Breadcrumbs.php 1 patch
Spacing   +11 added lines, -12 removed lines patch added patch discarded remove patch
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
 
43 43
     protected function registerFragmentBreadcrumbs()
44 44
     {
45
-        BreadCrumbsManager::register('fragments', function ($breadcrumbs) {
45
+        BreadCrumbsManager::register('fragments', function($breadcrumbs) {
46 46
             $breadcrumbs->push(fragment('back.fragments.title'), action('Back\FragmentController@index'));
47 47
         });
48 48
 
49
-        BreadCrumbsManager::register('fragmentDetail', function ($breadcrumbs, $string) {
49
+        BreadCrumbsManager::register('fragmentDetail', function($breadcrumbs, $string) {
50 50
             $breadcrumbs->parent('fragments');
51 51
             $breadcrumbs->push($string->name, action('Back\FragmentController@edit', $string->id));
52 52
         });
@@ -54,30 +54,30 @@  discard block
 block discarded – undo
54 54
 
55 55
     protected function registerUserBreadcrumbs()
56 56
     {
57
-        BreadCrumbsManager::register('backUserListBack', function ($breadcrumbs) {
57
+        BreadCrumbsManager::register('backUserListBack', function($breadcrumbs) {
58 58
             $breadcrumbs->push(fragment('back.backUsers.title'), action('Back\BackUserController@index'));
59 59
         });
60 60
 
61
-        BreadCrumbsManager::register('newBackUserBack', function ($breadcrumbs) {
61
+        BreadCrumbsManager::register('newBackUserBack', function($breadcrumbs) {
62 62
             $breadcrumbs->parent('backUserListBack');
63 63
             $breadcrumbs->push(fragment('back.backUsers.new'), action('Back\BackUserController@create'));
64 64
         });
65 65
 
66
-        BreadCrumbsManager::register('editBackUserBack', function ($breadcrumbs, $user) {
66
+        BreadCrumbsManager::register('editBackUserBack', function($breadcrumbs, $user) {
67 67
             $breadcrumbs->parent('backUserListBack', $user);
68 68
             $breadcrumbs->push($user->present()->fullName, action('Back\BackUserController@edit', $user->id));
69 69
         });
70 70
 
71
-        BreadCrumbsManager::register('frontUserListBack', function ($breadcrumbs) {
71
+        BreadCrumbsManager::register('frontUserListBack', function($breadcrumbs) {
72 72
             $breadcrumbs->push(fragment('back.frontUsers.title'), action('Back\FrontUserController@index'));
73 73
         });
74 74
 
75
-        BreadCrumbsManager::register('newFrontUserBack', function ($breadcrumbs) {
75
+        BreadCrumbsManager::register('newFrontUserBack', function($breadcrumbs) {
76 76
             $breadcrumbs->parent('frontUserListBack');
77 77
             $breadcrumbs->push(fragment('back.frontUsers.new'), action('Back\FrontUserController@create'));
78 78
         });
79 79
 
80
-        BreadCrumbsManager::register('editFrontUserBack', function ($breadcrumbs, $user) {
80
+        BreadCrumbsManager::register('editFrontUserBack', function($breadcrumbs, $user) {
81 81
             $breadcrumbs->parent('frontUserListBack', $user);
82 82
             $breadcrumbs->push($user->present()->fullName, action('Back\FrontUserController@edit', $user->id));
83 83
         });
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
         BreadCrumbsManager::register(
95 95
             "{$singular}ListBack",
96
-            function ($breadcrumbs) use ($ucname, $plural) {
96
+            function($breadcrumbs) use ($ucname, $plural) {
97 97
                 $breadcrumbs->push(
98 98
                     fragment("back.{$plural}.title"),
99 99
                     action("Back\\{$ucname}Controller@index")
@@ -103,12 +103,11 @@  discard block
 block discarded – undo
103 103
 
104 104
         BreadCrumbsManager::register(
105 105
             "{$singular}Back",
106
-            function ($breadcrumbs, $model) use ($singular, $ucname, $plural) {
106
+            function($breadcrumbs, $model) use ($singular, $ucname, $plural) {
107 107
                 $breadcrumbs->parent("{$singular}ListBack");
108 108
 
109 109
                 $breadcrumbs->push(
110
-                    $model->isDraft() ? fragment("back.{$plural}.new") :
111
-                        (isset($model->name) ? $model->name : ucfirst(fragment('back.change'))),
110
+                    $model->isDraft() ? fragment("back.{$plural}.new") : (isset($model->name) ? $model->name : ucfirst(fragment('back.change'))),
112 111
                     action("Back\\{$ucname}Controller@create")
113 112
                 );
114 113
             }
Please login to merge, or discard this patch.