UserPresenter - Code Metrics - Inspection of "Merge branch 'feature/multiple-auth'" - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02f92d...9c9507 )

by Sebastian

created 2016-02-16 15:58 UTC

UserPresenter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	63.64 %

Coupling/Cohesion

Components	0
Dependencies	1

Metric	Value
wmc	5
lcom	0
cbo	1
dl	14
loc	22
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	fullName()	0	4	1
A	lastActivityDate()	14	14	4

How to fix Duplicated Code

<?php

namespace App\Services\Auth\Front;

use Laracasts\Presenter\Presenter;

/** @mixin \App\Services\Auth\Front\User */
class UserPresenter extends Presenter
{
    public function fullName() : string
    {
        return "{$this->first_name} {$this->last_name}";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function lastActivityDate() : string

    {
        if ($this->last_activity === null || $this->last_activity->year == -1) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return fragment('back.frontUsers.neverLoggedIn');
        }

        $lastActivityDate = diff_date_for_humans($this->last_activity);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (str_contains($lastActivityDate, 'second')) {
            $lastActivityDate = fragment('back.frontUsers.justNow');
        }

        return $lastActivityDate;
    }
}


1		<?php
2
3		namespace App\Services\Auth\Front;
4
5		use Laracasts\Presenter\Presenter;
6
7		/** @mixin \App\Services\Auth\Front\User */
8		class UserPresenter extends Presenter
9		{
10		public function fullName() : string
11		{
12		return "{$this->first_name} {$this->last_name}";
		0 ignored issues – show Documentation introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The property `first_name` does not exist on `object<App\Services\Auth\Front\UserPresenter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The property `last_name` does not exist on `object<App\Services\Auth\Front\UserPresenter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
13		}
14
15	View Code Duplication	public function lastActivityDate() : string
		0 ignored issues – show Duplication introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		if ($this->last_activity === null \|\| $this->last_activity->year == -1) {
		0 ignored issues – show Documentation introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The property `last_activity` does not exist on `object<App\Services\Auth\Front\UserPresenter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
18		return fragment('back.frontUsers.neverLoggedIn');
19		}
20
21		$lastActivityDate = diff_date_for_humans($this->last_activity);
		0 ignored issues – show Documentation introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The property `last_activity` does not exist on `object<App\Services\Auth\Front\UserPresenter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
22
23		if (str_contains($lastActivityDate, 'second')) {
24		$lastActivityDate = fragment('back.frontUsers.justNow');
25		}
26
27		return $lastActivityDate;
28		}
29		}
30

spatie-custom / blender

Push — master ( 02f92d...9c9507 )

UserPresenter A

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like