UserPresenter::lastActivityDate() - Code Metrics - Inspection of "User name & password improvements" - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0925b8...107387 )

by Sebastian

created 2016-06-20 12:31 UTC

UserPresenter::lastActivityDate() A

↳ Parent: UserPresenter

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	7
nc	3
nop	0
dl	0
loc	14
rs	9.2
c	0
b	0
f	0

<?php

namespace App\Services\Auth\Front;

use Laracasts\Presenter\Presenter;

/** @mixin \App\Services\Auth\Front\User */
class UserPresenter extends Presenter
{
    public function avatar(): string
    {
        return 'https://www.gravatar.com/avatar/'.md5($this->email).'?d=mm&s=256';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function lastActivityDate(): string
    {
        if ($this->last_activity === null || $this->last_activity->year == -1) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return fragment('back.frontUsers.neverLoggedIn');
        }

        $lastActivityDate = diff_date_for_humans($this->last_activity);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (str_contains($lastActivityDate, 'second')) {
            $lastActivityDate = fragment('back.frontUsers.justNow');
        }

        return $lastActivityDate;
    }
}


1			<?php
2
3			namespace App\Services\Auth\Front;
4
5			use Laracasts\Presenter\Presenter;
6
7			/** @mixin \App\Services\Auth\Front\User */
8			class UserPresenter extends Presenter
9			{
10			public function avatar(): string
11			{
12			return 'https://www.gravatar.com/avatar/'.md5($this->email).'?d=mm&s=256';
			0 ignored issues – show Documentation introduced 2016-04-12 15:11 UTC by Report Bug Copy Issue Report The property `email` does not exist on `object<App\Services\Auth\Front\UserPresenter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
13			}
14
15			public function lastActivityDate(): string
16			{
17			if ($this->last_activity === null \|\| $this->last_activity->year == -1) {
			0 ignored issues – show Documentation introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The property `last_activity` does not exist on `object<App\Services\Auth\Front\UserPresenter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
18			return fragment('back.frontUsers.neverLoggedIn');
19			}
20
21			$lastActivityDate = diff_date_for_humans($this->last_activity);
			0 ignored issues – show Documentation introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The property `last_activity` does not exist on `object<App\Services\Auth\Front\UserPresenter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
22
23			if (str_contains($lastActivityDate, 'second')) {
24			$lastActivityDate = fragment('back.frontUsers.justNow');
25			}
26
27			return $lastActivityDate;
28			}
29			}
30

spatie-custom / blender

Push — master ( 0925b8...107387 )

UserPresenter::lastActivityDate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like