MembersController::update() - Code Metrics - Inspection of "Autumn cleanup" - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#79)

by Sebastian

created 2016-10-18 12:08 UTC

MembersController::update() A

↳ Parent: MembersController

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	11
nc	1
nop	2
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Http\Controllers\Back;

use App\Services\Auth\Front\Enums\UserRole;
use App\Services\Auth\Front\Enums\UserStatus;
use App\Services\Auth\Front\Events\UserCreatedThroughBack;
use App\Http\Requests\Back\FrontUserRequest;
use App\Services\Auth\Front\User;
use App\Services\Auth\Front\UserUpdater;
use App\Repositories\FrontUserRepository;

class MembersController
{
    /** @var \App\Repositories\FrontUserRepository */
    protected $frontUserRepository;

    public function __construct(FrontUserRepository $frontUserRepository)
    {
        $this->frontUserRepository = $frontUserRepository;
    }

    public function index()
    {
        $users = $this->frontUserRepository->getAll();

        return view('back.members.index')->with(compact('users'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function create()
    {
        return view('back.members.create', ['user' => new User()]);
    }

    public function store(FrontUserRequest $request)
    {
        $user = new User();

        $user->email = $request->get('email');
        $user->first_name = $request->get('first_name');
        $user->last_name = $request->get('last_name');
        $user->locale = $request->get('locale', 'nl');

        $user->role = UserRole::MEMBER();
        $user->status = UserStatus::ACTIVE();

        $this->frontUserRepository->save($user);

        $eventDescription = $this->getEventDescriptionFor('created', $user);
        activity($eventDescription);
        flash()->success(strip_tags($eventDescription).'. '.fragment('back.members.passwordMailSent'));

        event(new UserCreatedThroughBack($user));

        return redirect()->action('Back\MembersController@index');
    }

    public function edit($id)
    {
        $user = $this->frontUserRepository->find($id);

        if (!$user) {
            abort(404);
        }

        return view('back.members.edit')->with(compact('user'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function update($id, FrontUserRequest $request)
    {
        abort_unless($user = $this->frontUserRepository->find($id), 500);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $user->email = $request->get('email');
        $user->first_name = $request->get('first_name');
        $user->last_name = $request->get('last_name');
        $user->locale = $request->get('locale', 'nl');

        $this->frontUserRepository->save($user);

        $eventDescription = $this->getEventDescriptionFor('updated', $user);
        activity()->on($user)->log($eventDescription);
        flash()->success(strip_tags($eventDescription));

        return redirect()->action('Back\MembersController@index');
    }

    public function destroy($id)

    {
        $user = $this->frontUserRepository->find($id);

        $this->frontUserRepository->delete($user);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $eventDescription = $this->getEventDescriptionFor('deleted', $user);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        activity()->log($eventDescription);
        flash()->success(strip_tags($eventDescription));

        return redirect()->action('Back\MembersController@index');
    }

    protected function getEventDescriptionFor(string $event, User $user): string

    {
        $name = sprintf(
            '<a href="%s">%s</a>',
            action('Back\MembersController@edit', [$user->id]),
            $user->email
        );

        if ($event === 'deleted') {
            $name = $user->email;
        }

        return trans("back.events.$event", ['model' => fragment('back.members.member'), 'name' => $name]);
    }
}


1		<?php
2
3		namespace App\Http\Controllers\Back;
4
5		use App\Services\Auth\Front\Enums\UserRole;
6		use App\Services\Auth\Front\Enums\UserStatus;
7		use App\Services\Auth\Front\Events\UserCreatedThroughBack;
8		use App\Http\Requests\Back\FrontUserRequest;
9		use App\Services\Auth\Front\User;
10		use App\Services\Auth\Front\UserUpdater;
11		use App\Repositories\FrontUserRepository;
12
13		class MembersController
14		{
15		/** @var \App\Repositories\FrontUserRepository */
16		protected $frontUserRepository;
17
18		public function __construct(FrontUserRepository $frontUserRepository)
19		{
20		$this->frontUserRepository = $frontUserRepository;
21		}
22
23		public function index()
24		{
25		$users = $this->frontUserRepository->getAll();
26
27		return view('back.members.index')->with(compact('users'));
		0 ignored issues – show Bug introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28		}
29
30		public function create()
31		{
32		return view('back.members.create', ['user' => new User()]);
33		}
34
35		public function store(FrontUserRequest $request)
36		{
37		$user = new User();
38
39		$user->email = $request->get('email');
40		$user->first_name = $request->get('first_name');
41		$user->last_name = $request->get('last_name');
42		$user->locale = $request->get('locale', 'nl');
43
44		$user->role = UserRole::MEMBER();
45		$user->status = UserStatus::ACTIVE();
46
47		$this->frontUserRepository->save($user);
48
49		$eventDescription = $this->getEventDescriptionFor('created', $user);
50		activity($eventDescription);
51		flash()->success(strip_tags($eventDescription).'. '.fragment('back.members.passwordMailSent'));
52
53		event(new UserCreatedThroughBack($user));
54
55		return redirect()->action('Back\MembersController@index');
56		}
57
58		public function edit($id)
59		{
60		$user = $this->frontUserRepository->find($id);
61
62		if (!$user) {
63		abort(404);
64		}
65
66		return view('back.members.edit')->with(compact('user'));
		0 ignored issues – show Bug introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
67		}
68
69		public function update($id, FrontUserRequest $request)
70		{
71		abort_unless($user = $this->frontUserRepository->find($id), 500);
		0 ignored issues – show Documentation introduced 2016-08-27 00:12 UTC by Report Bug Copy Issue Report `$user = $this->frontUserRepository->find($id)` is of type `object<Illuminate\Database\Eloquent\Model>\|null`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72
73		$user->email = $request->get('email');
74		$user->first_name = $request->get('first_name');
75		$user->last_name = $request->get('last_name');
76		$user->locale = $request->get('locale', 'nl');
77
78		$this->frontUserRepository->save($user);
79
80		$eventDescription = $this->getEventDescriptionFor('updated', $user);
81		activity()->on($user)->log($eventDescription);
82		flash()->success(strip_tags($eventDescription));
83
84		return redirect()->action('Back\MembersController@index');
85		}
86
87	View Code Duplication	public function destroy($id)
		0 ignored issues – show Duplication introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		{
89		$user = $this->frontUserRepository->find($id);
90
91		$this->frontUserRepository->delete($user);
		0 ignored issues – show Bug introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report It seems like `$user` defined by `$this->frontUserRepository->find($id)` on line `89` can be `null`; however, `App\Foundation\Repositories\Repository::delete()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
92
93		$eventDescription = $this->getEventDescriptionFor('deleted', $user);
		0 ignored issues – show Bug introduced 2016-10-18 11:00 UTC by Report Bug Copy Issue Report It seems like `$user` defined by `$this->frontUserRepository->find($id)` on line `89` can be `null`; however, `App\Http\Controllers\Bac...etEventDescriptionFor()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
94		activity()->log($eventDescription);
95		flash()->success(strip_tags($eventDescription));
96
97		return redirect()->action('Back\MembersController@index');
98		}
99
100	View Code Duplication	protected function getEventDescriptionFor(string $event, User $user): string
		0 ignored issues – show Duplication introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
101		{
102		$name = sprintf(
103		'<a href="%s">%s</a>',
104		action('Back\MembersController@edit', [$user->id]),
105		$user->email
106		);
107
108		if ($event === 'deleted') {
109		$name = $user->email;
110		}
111
112		return trans("back.events.$event", ['model' => fragment('back.members.member'), 'name' => $name]);
113		}
114		}
115

spatie-custom / blender

Pull Request — master (#79)

MembersController::update() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like